6.7 KiB
6.7 KiB
PR #821 Investigation and Fix Todo List
Phase 1: Issue Detection
1.1 Environment Setup
- Ensure we're on v6-alpha branch
- Verify git is clean (no uncommitted changes)
- Run baseline tests to confirm current system works
- Document baseline test results
1.2 Architecture Review
- Read v6-alpha README.md thoroughly
- Review
bmad/,bmd/,src/directory structures - Document v6 agent architecture patterns
- Review sidecar pattern documentation (issue #823)
- Understand module system in
src/modules/
1.3 PR Content Analysis
- Download PR #821 patch file
- Extract and review all changed files
- List all new files and their purposes
- Identify all agent definitions in PR
- Compare with existing agent definitions
1.4 Conflict Detection
- Check for file path conflicts
- Compare agent names (PR vs existing)
- Compare agent functionality (PR vs existing)
- Check for YAML schema differences
- Identify markdown format differences
- Find duplicate or overlapping features
1.5 IDE File Issues
- Check if
.idea/should be gitignored - Review
.gitignorefile - Determine if IDE files should be in PR
Phase 2: Test Creation
2.1 Schema Validation Tests
- Create test for agent markdown frontmatter format
- Create test for team YAML schema
- Create test for checklist format
- Test against existing agent schema validator
- Document schema differences found
2.2 Integration Tests
- Test agent discovery in new structure
- Test CLI compatibility with new agents
- Test module installer with new structure
- Test bundler with new files
- Test against existing workflows
2.3 Regression Tests
- Run full existing test suite
- Verify no existing functionality breaks
- Check that current agents still work
- Verify CLI commands unchanged
- Test existing modules unaffected
2.4 File Structure Tests
- Validate directory naming conventions
- Test file path resolution
- Check for circular dependencies
- Verify module boundaries
Phase 3: Issue Analysis and Resolution Planning
3.1 Document Findings
- Create detailed issue report
- List all conflicts found
- Categorize issues by severity
- Identify breaking vs non-breaking changes
- Document architectural misalignments
3.2 Determine Resolution Strategy
- Evaluate Scenario A: Accept as Module
- List required changes for module integration
- Identify installer configuration needed
- Plan documentation updates
- Estimate effort
- Evaluate Scenario B: Merge with Existing
- Map duplicate functionality
- Identify unique value-add features
- Plan merge strategy
- Estimate effort
- Evaluate Scenario C: External Recommendation
- Document architectural incompatibilities
- Draft recommendation rationale
- Create integration guide
- Estimate effort
3.3 Decision Making
- Review findings with stakeholder perspective
- Make scenario recommendation
- Document decision rationale
- Create implementation plan
Phase 4: Fix Implementation
4.1 Pre-Implementation
- Create new working branch from v6-alpha
- Set up test infrastructure
- Prepare rollback plan
- Document implementation steps
4.2 Scenario A: Module Integration (if chosen)
- Move files to
src/modules/subagentic/ - Create
_module-installer/structure - Add
install-config.yaml - Create
installer.js - Update module README
- Add module to bundler configs
- Remove
.idea/files - Update
.gitignoreif needed - Add comprehensive tests
- Update documentation
4.3 Scenario B: Merge (if chosen)
- Extract unique agents
- Merge agent improvements
- Standardize format to v6 patterns
- Update existing agents with improvements
- Archive duplicate content
- Add tests for new features
- Update documentation
4.4 Scenario C: External (if chosen)
- Create detailed recommendation document
- Document integration points
- Create user guide
- Suggest fork structure
- Close PR with explanation
Phase 5: Testing and Validation
5.1 Unit Testing
- Run new unit tests
- Verify all new tests pass
- Check test coverage
- Add missing test cases
- Document test results
5.2 Integration Testing
- Test CLI integration
- Test module installation
- Test agent activation
- Test bundler output
- Test cross-module compatibility
5.3 Regression Testing
- Run full existing test suite
- Verify no regressions
- Test existing workflows
- Validate backward compatibility
- Document test results
5.4 Manual Testing
- Test agent invocation with @agent_name
- Test team configurations
- Test checklist functionality
- Verify documentation accuracy
- Test user workflows end-to-end
Phase 6: Finalization
6.1 Code Quality
- Run linter on all changes
- Fix all linting errors
- Format code with prettier
- Review code comments
- Check for debug/console statements
6.2 Documentation
- Update main README if needed
- Update CHANGELOG
- Document new features
- Update integration guides
- Add migration notes if needed
6.3 Git Management
- Review all changes
- Create logical commits
- Write descriptive commit messages
- Push to feature branch
- Create pull request (if applicable)
6.4 Final Validation
- Review changes against plan
- Verify all success criteria met
- Confirm no issues remain
- Get stakeholder approval
- Prepare merge strategy
Phase 7: Deployment
7.1 Pre-Deployment
- Final test suite run
- Review deployment plan
- Prepare rollback procedure
- Notify stakeholders
7.2 Deployment Actions
- Merge to v6-alpha (or appropriate branch)
- Tag release if needed
- Update package version if needed
- Deploy documentation updates
7.3 Post-Deployment
- Monitor for issues
- Respond to PR #821 with resolution
- Update issue tracking
- Document lessons learned
Summary Checklist
- Issue detection complete
- Tests created and passing
- Fix implemented
- All tests passing (new and existing)
- Documentation updated
- Code quality checks passed
- Stakeholder approval obtained
- Deployment successful
- PR #821 resolved
Notes
- Keep detailed notes of findings at each phase
- Document decisions and rationale
- Track time spent on each phase
- Update this todo as work progresses
- Flag blockers immediately