ldy26098
/
BMAD-METHOD
mirror of https://github.com/bmad-code-org/BMAD-METHOD.git
1
0
Fork 0
Code Packages Projects Releases Wiki Activity
BMAD-METHOD/expansion-packs/story-implementation/tasks/implement-consolidated-fixe...

7.5 KiB
Raw Blame History

Implement Consolidated Fixes

Task Overview

Agent: dev
Action Type: fix-implementation
Duration: 15-45 minutes (varies by fix count)
LLM-Optimized: Systematic fix implementation with evidence tracking

Purpose

Implement consolidated fixes focusing on REQUIRED-FOR-COMPLETION and QUALITY-STANDARD items with clear documentation for validation.

Context

Systematic implementation of prioritized review feedback:

  • REQUIRED-FOR-COMPLETION and QUALITY-STANDARD priority focus
  • Implementation plan sequencing for efficiency
  • Clear documentation for validation evidence
  • Quality gate maintenance throughout process

Inputs

Required

  • story_file (string): Path to the story file with consolidation summary
  • consolidated_feedback (object): Prioritized feedback from consolidation task

Outputs

  • implementation_status (string): "Complete" | "Partial" | "Blocked"
  • story_file (string): Updated story file with implementation details
  • fixes_summary (string): Summary of changes implemented

Instructions

Step 1: Pre-Implementation Analysis (3-5 minutes)

Consolidation Review:

FIX_ANALYSIS:
- REQUIRED items: [count]
- QUALITY-STANDARD items: [count]
- Implementation phases: [count]
- Estimated effort: [time]
- Dependencies identified: [list]

Technical Scope Assessment:

  • Backend changes: [YES/NO] - [component list]
  • Frontend changes: [YES/NO] - [component list]
  • Integration points: [list]
  • Quality gates impact: [NONE/MINOR/MAJOR]
  • Testing approach: [unit/integration/e2e]

Step 2: Systematic Fix Implementation (10-35 minutes)

Implementation Protocol:

  1. Phase 1: REQUIRED-FOR-COMPLETION fixes (sequential)
  2. Phase 2: QUALITY-STANDARD fixes (grouped by domain)
  3. Continuous quality gate validation
  4. Evidence documentation per fix

Per-Fix Process:

[FIX_ID]: [Description] - [Domain]
Implementation: [Code changes made]
Validation: [How verified]
Quality Gates: [PASS/FAIL status]
Evidence: [Test results/screenshots]

Follow implementation plan sequence:

  • Work through fixes in the order specified by consolidation
  • Complete each phase before moving to next
  • Test each significant change before proceeding
  • Maintain project quality gates throughout

For each fix:

  • Read the specific feedback requirement
  • Implement the change following project coding standards
  • Test the change in isolation where possible
  • Document what was changed and how

  1. Handle different types of fixes

    Architecture fixes:

    • Code structure improvements
    • Security enhancements
    • Performance optimizations
    • Technical debt reduction

    Business fixes:

    • Acceptance criteria adjustments
    • Business rule corrections
    • User journey improvements
    • Data validation enhancements

    Quality fixes:

    • Test coverage improvements
    • Code quality enhancements
    • Error handling additions
    • Documentation updates

    UX fixes:

    • Interface adjustments
    • Accessibility improvements
    • User interaction enhancements
    • Visual design corrections

Quality Validation

  1. Ensure continuous quality

    • Run project quality gates after significant changes
    • Verify existing functionality still works
    • Test new/modified functionality thoroughly
    • Maintain test coverage standards

  2. Document implementation thoroughly

    Update story file with implementation details:

    ## Round 1 Fixes Implementation

### REQUIRED-FOR-COMPLETION Fixes Applied

#### Architecture Fixes
1. **[Fix Description]**
   - **Issue**: [Original feedback]
   - **Solution**: [What was implemented]
   - **Files Changed**: [List of modified files]
   - **Testing**: [How it was validated]

#### Business Fixes  
1. **[Fix Description]**
   - **Issue**: [Original feedback]
   - **Solution**: [What was implemented]
   - **AC Impact**: [Which acceptance criteria affected]
   - **Testing**: [How it was validated]

### QUALITY-STANDARD Fixes Applied

#### Process/Standards Fixes
1. **[Fix Description]**
   - **Issue**: [Original feedback]
   - **Standard**: [Which project standard was violated]
   - **Solution**: [What was implemented]
   - **Testing**: [How it was validated]

#### Quality Fixes
1. **[Fix Description]**
   - **Issue**: [Original feedback]
   - **Standard**: [Test coverage/Code quality/Performance/etc.]
   - **Solution**: [What was implemented]
   - **Testing**: [How it was validated]

#### UX Fixes
1. **[Fix Description]**
   - **Issue**: [Original feedback]
   - **Standard**: [Accessibility/Design consistency/etc.]
   - **Solution**: [What was implemented]
   - **Visual Changes**: [Description of UI changes]
   - **Testing**: [How it was validated - note if Playwright needed]

### Implementation Status
- **REQUIRED-FOR-COMPLETION**: [X/Y completed]
- **QUALITY-STANDARD**: [X/Y completed]
- **Quality Gates**: [PASS/FAIL]
- **Ready for Validation**: [YES/NO]

### IMPROVEMENT Items (Deferred)
[List items marked as IMPROVEMENT that were not implemented]

Completion Verification

  1. Final validation before handoff

    • Verify all REQUIRED-FOR-COMPLETION items addressed
    • Verify all QUALITY-STANDARD items addressed per project requirements
    • Confirm project quality gates pass
    • Test critical user journeys still work
    • Ensure story acceptance criteria still met
    • Document any remaining concerns or blockers

  2. Prepare for architect validation

    • Ensure story documentation is complete and clear
    • Note any UX changes that require Playwright validation
    • Document any technical decisions made during implementation
    • Flag any items that couldn't be completed and why

Success Criteria

  • All REQUIRED-FOR-COMPLETION and QUALITY-STANDARD fixes implemented according to plan
  • Project quality gates continue to pass
  • Story file updated with comprehensive implementation details
  • No regressions in existing functionality
  • Ready for architect validation with clear documentation

Failure Conditions

  • REQUIRED-FOR-COMPLETION or QUALITY-STANDARD fixes incomplete or incorrect
  • Project quality gates failing after implementation
  • Insufficient documentation of changes
  • Existing functionality broken by fixes
  • Critical technical blockers preventing completion

Error Handling

If implementation encounters blockers:

  1. Document the specific blocker and attempted solutions
  2. Identify if blocker affects REQUIRED-FOR-COMPLETION or QUALITY-STANDARD classification
  3. Update story with blocker details and impact
  4. Recommend next steps (escalation, scope change, etc.)
  5. Complete remaining non-blocked fixes

If quality gates fail:

  1. Identify specific failures and root causes
  2. Fix issues systematically
  3. Re-run quality gates after each fix
  4. Document any ongoing quality issues
  5. Do not proceed to validation until gates pass

Notes

  • Focus exclusively on REQUIRED-FOR-COMPLETION and QUALITY-STANDARD items
  • IMPROVEMENT items should be documented but not implemented
  • Story documentation is critical for subsequent architect validation
  • UX changes requiring server interaction should be clearly marked
  • Maintain project coding standards and conventions throughout

Integration Points

  • Input from: consolidate-review-feedback task (architect agent)
  • Output to: validate-consolidated-fixes task (architect agent)
  • Dependencies: Story file with consolidation summary
  • Quality Gates: Project-specific validation commands must pass