Merge branch '2-gabadi/tasks-review' into feature/story-implementation-expansion-pack

expansion-packs/story-implementation/checklists/epic-readiness-checklist.md

@@ -7,7 +7,7 @@
 ## Epic Business Readiness Validation
 
 ### Epic Existence & Status Verification
-- [ ] **Epic file exists**: `docs/epic{epic_number}.md` or alternative location confirmed
+- [ ] **Epic file exists**: Epic file located in `docs/prd/epic-{epic_number}-*.md` or `docs/epics/epic-{epic_number}-*.md` or user-specified location confirmed
 - [ ] **Epic status approved**: Epic status is "Approved" (not Draft/In Progress/Review)
 - [ ] **Epic completion readiness**: Epic has clear business objectives and scope defined
 - [ ] **Epic format compliance**: Epic follows project template and documentation standards

expansion-packs/story-implementation/checklists/story-approval-checklist.md

@@ -52,9 +52,9 @@ APPROVAL DECISION:
 
 [[LLM: Ensure story is right-sized and appropriately prioritized]]
 
-- [ ] **MVP Alignment**: Story scope aligns with MVP boundaries (not over-engineered)
+- [ ] **Scope Appropriateness**: Story scope aligns with project phase and delivery boundaries
-- [ ] **Iteration Size**: Story can be completed in single development iteration
+- [ ] **Deliverable Size**: Story can be completed within project's standard delivery timeframe
-- [ ] **Priority Justification**: Story priority is appropriate for current epic phase
+- [ ] **Priority Justification**: Story priority aligns with current project objectives and constraints
 - [ ] **Dependency Clarity**: Prerequisites and dependencies are clearly identified
 - [ ] **Risk Assessment**: Business risk of implementing/not implementing is understood
 

expansion-packs/story-implementation/tasks/approve-story-for-development.md

@@ -11,7 +11,7 @@ Product Owner validation and approval of story for development readiness. Valida
 
 ### 1. Load Story and Epic Context
 - Read the complete story file
-- Read the parent epic file (`docs/epic{epic_number}.md`) for context
+- Read the parent epic file (located via `docs/prd/epic-{epic_number}-*.md` or `docs/epics/epic-{epic_number}-*.md`) for context
 - Extract story status, user story, acceptance criteria, and business context
 - Understand the story's role within the epic objectives
 

expansion-packs/story-implementation/tasks/setup-development-environment.md

@@ -9,10 +9,10 @@ Ensure development environment is ready and validated for story implementation.
 ## Task Execution
 
 ### 1. Environment Health Check
-- Verify development services are running (database, redis, backend, frontend)
+- Verify project-specific development services are running (check project documentation for required services)
-- Check service connectivity and responsiveness
+- Check service connectivity and responsiveness based on project architecture
-- Validate port availability and configuration
+- Validate port availability and configuration as defined in project setup
-- Ensure no service conflicts or failures
+- Ensure no service conflicts or failures in the development stack
 
 ### 2. Development Dependencies
 - Verify all required dependencies are installed
@@ -27,10 +27,10 @@ Ensure development environment is ready and validated for story implementation.
 - Check that development server starts successfully
 
 ### 4. Authentication and Security
-- Test authentication flow with development credentials
+- Test authentication flow with development credentials (if project requires authentication)
-- Verify authorization rules are working
+- Verify authorization rules are working according to project security model
-- Check security configurations are properly set
+- Check security configurations are properly set per project requirements
-- Validate API access and permissions
+- Validate API access and permissions as defined in project documentation
 
 ### 5. Story-Specific Validation
 - Review story requirements for any special environment needs

expansion-packs/story-implementation/tasks/validate-consolidated-fixes.md

@@ -37,7 +37,7 @@ This task provides efficient architect-only validation after comprehensive Round
 1. **Review implementation documentation**
    - Read story file implementation section thoroughly
    - Compare implemented fixes against original consolidated feedback
-   - Identify any MVP-BLOCKING items that were not addressed
+   - Identify any REQUIRED-FOR-COMPLETION items that were not addressed
    - Note any technical decisions or changes made during implementation
 
 2. **Assess validation approach needed**
@@ -73,29 +73,29 @@ This task provides efficient architect-only validation after comprehensive Round
    **Epic alignment validation:**
    - Ensure changes maintain epic scope and objectives
    - Verify business value delivery still intact
-   - Check that MVP boundaries respected
+   - Check that project phase boundaries respected
 
-5. **Validate UX fixes using browser testing tools**
+5. **Validate UX fixes using project-appropriate testing tools**
    
    **When UX validation needed:**
-   - Visual interface changes described in story
+   - User interface changes described in story (web, desktop, mobile, CLI, etc.)
    - User interaction flow modifications
    - Accessibility improvements requiring testing
    - Design consistency updates
    
-   **Comprehensive Browser MCP Testing Protocol:**
+   **Comprehensive UI Testing Protocol:**
    
    **Phase 1: Environment Setup**
-   - Launch browser MCP session (prefer Playwright MCP for full automation)
+   - Launch UI testing tools as specified in project documentation (check README.md or test configuration)
-   - Use dedicated incognito/private browser context for clean state
+   - Use clean testing environment appropriate for project type (browser, desktop app, mobile simulator, CLI, etc.)
-   - Clear all cache, cookies, and local storage before testing
+   - Clear relevant caches and state according to project architecture
-   - Set viewport to standard desktop resolution (1920x1080)
+   - Set appropriate viewport/window size for project target platform
-   - Configure browser for debugging (enable console logging)
+   - Configure testing environment for debugging (enable logging as per project standards)
    
    **Phase 2: Pre-Testing Validation**
-   - Navigate to application base URL
+   - Navigate to application entry point (URL, app launch, CLI command, etc.)
-   - Verify application loads without errors (check console)
+   - Verify application loads/starts without errors (check relevant logs)
-   - Take baseline screenshot of unaffected areas for comparison
+   - Take baseline screenshot/capture of unaffected areas for comparison
    - Document initial application state and version
    
    **Phase 3: Feature-Specific Testing**
@@ -108,30 +108,30 @@ This task provides efficient architect-only validation after comprehensive Round
      * Capture screenshot AFTER each significant interaction
      * Validate loading states and transitions work correctly
    
-   **Phase 4: Accessibility & Responsive Testing**
+   **Phase 4: Accessibility & Responsive Testing (if applicable to project type)**
-   - Test keyboard navigation for new/changed interactive elements
+   - Test keyboard/alternative navigation for new/changed interactive elements
-   - Verify ARIA labels and roles if accessibility improvements documented
+   - Verify accessibility features if improvements documented (ARIA, screen reader compatibility, etc.)
-   - Test responsive behavior at mobile (375px), tablet (768px), desktop (1920px) viewports
+   - Test responsive behavior according to project target platforms (mobile, tablet, desktop, multiple screen sizes)
-   - Validate color contrast and text readability for visual changes
+   - Validate contrast and readability for visual changes according to project standards
    
-   **Phase 5: Cross-Browser Compatibility (if critical changes)**
+   **Phase 5: Cross-Platform Compatibility (if critical changes)**
-   - Repeat core tests in Chrome, Firefox, and Safari (via MCP if supported)
+   - Repeat core tests across project target platforms (different browsers, OS versions, device types, etc.)
-   - Document any browser-specific issues discovered
+   - Document any platform-specific issues discovered
-   - Capture comparative screenshots across browsers for visual changes
+   - Capture comparative evidence across platforms for visual/behavioral changes
    
    **Phase 6: Evidence Documentation and Cleanup**
-   - Save all screenshots to temporary validation directory with descriptive filenames (feature_state_timestamp.png)
+   - Save all screenshots/captures to temporary validation directory with descriptive filenames (feature_state_timestamp.png)
-   - Record any console errors or warnings encountered
+   - Record any errors or warnings encountered in relevant logs
-   - Document specific browser MCP commands used for reproducibility
+   - Document specific testing commands/tools used for reproducibility
    - Create testing summary with pass/fail status for each tested component
-   - Note: All browser testing artifacts are temporary and will be cleaned up after validation completion
+   - Note: All testing artifacts are temporary and will be cleaned up after validation completion
    
-   **Browser MCP Session Management:**
+   **Testing Session Management:**
-   - Maintain single browser context throughout testing for consistency
+   - Maintain consistent testing context throughout validation for consistency
-   - Use page reload between major test sections to ensure clean state
+   - Reset application state between major test sections to ensure clean state
-   - Close and reopen browser context if session becomes unstable
+   - Restart testing environment if session becomes unstable
-   - Document MCP tool version and configuration used
+   - Document testing tool versions and configuration used (refer to project documentation)
-   - Clean up browser sessions and temporary files after validation
+   - Clean up testing sessions and temporary files after validation
    
    **File Management:**
    - All screenshots and evidence saved to temporary validation workspace
@@ -229,7 +229,7 @@ This task provides efficient architect-only validation after comprehensive Round
    **If APPROVED:**
    - Mark story as ready for delivery
    - Document successful completion
-   - Note any POST-MVP items for future tracking
+   - Note any IMPROVEMENT items for future tracking
    
    **If NEEDS_FIXES:**
    - Provide specific, actionable feedback
@@ -298,7 +298,7 @@ If browser MCP testing fails:
    - Consider scope adjustment if UX changes cannot be properly validated via available MCP tools
 
 If validation reveals new issues:
-1. Classify as MVP-BLOCKING vs POST-MVP
+1. Classify as REQUIRED-FOR-COMPLETION vs IMPROVEMENT
 2. Provide clear guidance for resolution
 3. Update feedback for next implementation cycle
 4. Consider if scope adjustment needed