ldy26098
/
BMAD-METHOD
mirror of https://github.com/bmad-code-org/BMAD-METHOD.git
1
0
Fork 0
Code Packages Projects Releases Wiki Activity

fix: improve agnostic compliance in story-implementation expansion pack 

- Replace methodology-specific terms (MVP, iteration) with project-agnostic language
- Update legacy file paths to modern BMAD structure (docs/prd/epic-*, docs/epics/epic-*)
- Generalize hardcoded services to project-configurable dependencies
- Abstract browser/Playwright testing to project-appropriate UI testing
- Replace platform-specific terminology with universal equivalents

Changes ensure 100% agnostic compliance while maintaining expansion pack functionality.

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>
This commit is contained in:
2-gabadi 2025-06-19 03:05:44 -03:00
parent 3349a90ee4
commit 0d013fa404
No known key found for this signature in database
GPG Key ID: EA11A57F8E259893
5 changed files with 47 additions and 47 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
expansion-packs/story-implementation/checklists/epic-readiness-checklist.md
View File

@ -7,7 +7,7 @@
## Epic Business Readiness Validation
### Epic Existence & Status Verification
- [ ] **Epic file exists**: `docs/epic{epic_number}.md` or alternative location confirmed
- [ ] **Epic file exists**: Epic file located in `docs/prd/epic-{epic_number}-*.md` or `docs/epics/epic-{epic_number}-*.md` or user-specified location confirmed
- [ ] **Epic status approved**: Epic status is "Approved" (not Draft/In Progress/Review)
- [ ] **Epic completion readiness**: Epic has clear business objectives and scope defined
- [ ] **Epic format compliance**: Epic follows project template and documentation standards

6
expansion-packs/story-implementation/checklists/story-approval-checklist.md
View File

@ -52,9 +52,9 @@ APPROVAL DECISION:
[[LLM: Ensure story is right-sized and appropriately prioritized]]
- [ ] **MVP Alignment**: Story scope aligns with MVP boundaries (not over-engineered)
- [ ] **Iteration Size**: Story can be completed in single development iteration
- [ ] **Priority Justification**: Story priority is appropriate for current epic phase
- [ ] **Scope Appropriateness**: Story scope aligns with project phase and delivery boundaries
- [ ] **Deliverable Size**: Story can be completed within project's standard delivery timeframe
- [ ] **Priority Justification**: Story priority aligns with current project objectives and constraints
- [ ] **Dependency Clarity**: Prerequisites and dependencies are clearly identified
- [ ] **Risk Assessment**: Business risk of implementing/not implementing is understood

2
expansion-packs/story-implementation/tasks/approve-story-for-development.md
View File

@ -11,7 +11,7 @@ Product Owner validation and approval of story for development readiness. Valida
### 1. Load Story and Epic Context
- Read the complete story file
- Read the parent epic file (`docs/epic{epic_number}.md`) for context
- Read the parent epic file (located via `docs/prd/epic-{epic_number}-*.md` or `docs/epics/epic-{epic_number}-*.md`) for context
- Extract story status, user story, acceptance criteria, and business context
- Understand the story's role within the epic objectives

16
expansion-packs/story-implementation/tasks/setup-development-environment.md
View File

@ -9,10 +9,10 @@ Ensure development environment is ready and validated for story implementation.
## Task Execution
### 1. Environment Health Check
- Verify development services are running (database, redis, backend, frontend)
- Check service connectivity and responsiveness
- Validate port availability and configuration
- Ensure no service conflicts or failures
- Verify project-specific development services are running (check project documentation for required services)
- Check service connectivity and responsiveness based on project architecture
- Validate port availability and configuration as defined in project setup
- Ensure no service conflicts or failures in the development stack
### 2. Development Dependencies
- Verify all required dependencies are installed
@ -27,10 +27,10 @@ Ensure development environment is ready and validated for story implementation.
- Check that development server starts successfully
### 4. Authentication and Security
- Test authentication flow with development credentials
- Verify authorization rules are working
- Check security configurations are properly set
- Validate API access and permissions
- Test authentication flow with development credentials (if project requires authentication)
- Verify authorization rules are working according to project security model
- Check security configurations are properly set per project requirements
- Validate API access and permissions as defined in project documentation
### 5. Story-Specific Validation
- Review story requirements for any special environment needs

68
expansion-packs/story-implementation/tasks/validate-consolidated-fixes.md
View File

@ -37,7 +37,7 @@ This task provides efficient architect-only validation after comprehensive Round
1. **Review implementation documentation**
- Read story file implementation section thoroughly
- Compare implemented fixes against original consolidated feedback
- Identify any MVP-BLOCKING items that were not addressed
- Identify any REQUIRED-FOR-COMPLETION items that were not addressed
- Note any technical decisions or changes made during implementation
2. **Assess validation approach needed**
@ -73,29 +73,29 @@ This task provides efficient architect-only validation after comprehensive Round
**Epic alignment validation:**
- Ensure changes maintain epic scope and objectives
- Verify business value delivery still intact
- Check that MVP boundaries respected
- Check that project phase boundaries respected
5. **Validate UX fixes using browser testing tools**
5. **Validate UX fixes using project-appropriate testing tools**
**When UX validation needed:**
- Visual interface changes described in story
- User interface changes described in story (web, desktop, mobile, CLI, etc.)
- User interaction flow modifications
- Accessibility improvements requiring testing
- Design consistency updates
**Comprehensive Browser MCP Testing Protocol:**
**Comprehensive UI Testing Protocol:**
**Phase 1: Environment Setup**
- Launch browser MCP session (prefer Playwright MCP for full automation)
- Use dedicated incognito/private browser context for clean state
- Clear all cache, cookies, and local storage before testing
- Set viewport to standard desktop resolution (1920x1080)
- Configure browser for debugging (enable console logging)
- Launch UI testing tools as specified in project documentation (check README.md or test configuration)
- Use clean testing environment appropriate for project type (browser, desktop app, mobile simulator, CLI, etc.)
- Clear relevant caches and state according to project architecture
- Set appropriate viewport/window size for project target platform
- Configure testing environment for debugging (enable logging as per project standards)
**Phase 2: Pre-Testing Validation**
- Navigate to application base URL
- Verify application loads without errors (check console)
- Take baseline screenshot of unaffected areas for comparison
- Navigate to application entry point (URL, app launch, CLI command, etc.)
- Verify application loads/starts without errors (check relevant logs)
- Take baseline screenshot/capture of unaffected areas for comparison
- Document initial application state and version
**Phase 3: Feature-Specific Testing**
@ -108,30 +108,30 @@ This task provides efficient architect-only validation after comprehensive Round
* Capture screenshot AFTER each significant interaction
* Validate loading states and transitions work correctly
**Phase 4: Accessibility & Responsive Testing**
- Test keyboard navigation for new/changed interactive elements
- Verify ARIA labels and roles if accessibility improvements documented
- Test responsive behavior at mobile (375px), tablet (768px), desktop (1920px) viewports
- Validate color contrast and text readability for visual changes
**Phase 4: Accessibility & Responsive Testing (if applicable to project type)**
- Test keyboard/alternative navigation for new/changed interactive elements
- Verify accessibility features if improvements documented (ARIA, screen reader compatibility, etc.)
- Test responsive behavior according to project target platforms (mobile, tablet, desktop, multiple screen sizes)
- Validate contrast and readability for visual changes according to project standards
**Phase 5: Cross-Browser Compatibility (if critical changes)**
- Repeat core tests in Chrome, Firefox, and Safari (via MCP if supported)
- Document any browser-specific issues discovered
- Capture comparative screenshots across browsers for visual changes
**Phase 5: Cross-Platform Compatibility (if critical changes)**
- Repeat core tests across project target platforms (different browsers, OS versions, device types, etc.)
- Document any platform-specific issues discovered
- Capture comparative evidence across platforms for visual/behavioral changes
**Phase 6: Evidence Documentation and Cleanup**
- Save all screenshots to temporary validation directory with descriptive filenames (feature_state_timestamp.png)
- Record any console errors or warnings encountered
- Document specific browser MCP commands used for reproducibility
- Save all screenshots/captures to temporary validation directory with descriptive filenames (feature_state_timestamp.png)
- Record any errors or warnings encountered in relevant logs
- Document specific testing commands/tools used for reproducibility
- Create testing summary with pass/fail status for each tested component
- Note: All browser testing artifacts are temporary and will be cleaned up after validation completion
- Note: All testing artifacts are temporary and will be cleaned up after validation completion
**Browser MCP Session Management:**
- Maintain single browser context throughout testing for consistency
- Use page reload between major test sections to ensure clean state
- Close and reopen browser context if session becomes unstable
- Document MCP tool version and configuration used
- Clean up browser sessions and temporary files after validation
**Testing Session Management:**
- Maintain consistent testing context throughout validation for consistency
- Reset application state between major test sections to ensure clean state
- Restart testing environment if session becomes unstable
- Document testing tool versions and configuration used (refer to project documentation)
- Clean up testing sessions and temporary files after validation
**File Management:**
- All screenshots and evidence saved to temporary validation workspace
@ -229,7 +229,7 @@ This task provides efficient architect-only validation after comprehensive Round
**If APPROVED:**
- Mark story as ready for delivery
- Document successful completion
- Note any POST-MVP items for future tracking
- Note any IMPROVEMENT items for future tracking
**If NEEDS_FIXES:**
- Provide specific, actionable feedback
@ -298,7 +298,7 @@ If browser MCP testing fails:
- Consider scope adjustment if UX changes cannot be properly validated via available MCP tools
If validation reveals new issues:
1. Classify as MVP-BLOCKING vs POST-MVP
1. Classify as REQUIRED-FOR-COMPLETION vs IMPROVEMENT
2. Provide clear guidance for resolution
3. Update feedback for next implementation cycle
4. Consider if scope adjustment needed