ldy26098
/
BMAD-METHOD
mirror of https://github.com/bmad-code-org/BMAD-METHOD.git
1
0
Fork 0
Code Packages Projects Releases Wiki Activity

fix: add test and version control requirements to DoD checklist 

Aligns DoD checklist with workflow diagram requirements.

**Problem:**
The Core Development Cycle workflow diagram (bmad-core/user-guide.md
line 129) shows "IMPORTANT: COMMIT YOUR CHANGES BEFORE PROCEEDING!"
and "Verify All Regression Tests and Linting are Passing" as explicit
steps before marking a story done. However, the story-dod-checklist.md
was missing these requirements.

**Solution:**
Added to Section 6 (Dependencies, Build & Configuration):
- All tests pass (unit, integration, etc.)
- All code changes for this story committed with descriptive messages
- Story file changes committed

This ensures agents follow the documented workflow by checking tests
pass and code is committed before completing a story.

**References:**
- Workflow diagram: bmad-core/user-guide.md lines 123, 129
- Related: Issue #661 (v6 VCS module - future enhancement)
This commit is contained in:
Mark Pundsack 2025-10-01 12:42:06 -05:00
parent 458704f82b
commit a675765391
1 changed files with 3 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
bmad-core/checklists/story-dod-checklist.md
View File

@ -67,6 +67,9 @@ The goal is quality delivery, not just checking boxes.]]
[[LLM: Build issues block everyone. Ensure everything compiles and runs cleanly]] [[LLM: Build issues block everyone. Ensure everything compiles and runs cleanly]]
- [ ] Project builds successfully without errors. - [ ] Project builds successfully without errors.
- [ ] Project linting passes - [ ] Project linting passes
- [ ] All tests pass (unit, integration, etc.)
- [ ] All code changes for this story committed to respective repositories with descriptive messages referencing story number (e.g., `feat: Story X.Y - brief description`)
- [ ] Story file changes (Dev Agent Record, File List, Status) committed
- [ ] Any new dependencies added were either pre-approved in the story requirements OR explicitly approved by the user during development (approval documented in story file). - [ ] Any new dependencies added were either pre-approved in the story requirements OR explicitly approved by the user during development (approval documented in story file).
- [ ] If new dependencies were added, they are recorded in the appropriate project files (e.g., `package.json`, `requirements.txt`) with justification. - [ ] If new dependencies were added, they are recorded in the appropriate project files (e.g., `package.json`, `requirements.txt`) with justification.
- [ ] No known security vulnerabilities introduced by newly added and approved dependencies. - [ ] No known security vulnerabilities introduced by newly added and approved dependencies.