From a675765391f86b815f3f641db15802c70cb6fae0 Mon Sep 17 00:00:00 2001 From: Mark Pundsack <319891+markpundsack@users.noreply.github.com> Date: Wed, 1 Oct 2025 12:42:06 -0500 Subject: [PATCH] fix: add test and version control requirements to DoD checklist Aligns DoD checklist with workflow diagram requirements. **Problem:** The Core Development Cycle workflow diagram (bmad-core/user-guide.md line 129) shows "IMPORTANT: COMMIT YOUR CHANGES BEFORE PROCEEDING!" and "Verify All Regression Tests and Linting are Passing" as explicit steps before marking a story done. However, the story-dod-checklist.md was missing these requirements. **Solution:** Added to Section 6 (Dependencies, Build & Configuration): - All tests pass (unit, integration, etc.) - All code changes for this story committed with descriptive messages - Story file changes committed This ensures agents follow the documented workflow by checking tests pass and code is committed before completing a story. **References:** - Workflow diagram: bmad-core/user-guide.md lines 123, 129 - Related: Issue #661 (v6 VCS module - future enhancement) --- bmad-core/checklists/story-dod-checklist.md | 3 +++ 1 file changed, 3 insertions(+) diff --git a/bmad-core/checklists/story-dod-checklist.md b/bmad-core/checklists/story-dod-checklist.md index 7ed54760..1e341d84 100644 --- a/bmad-core/checklists/story-dod-checklist.md +++ b/bmad-core/checklists/story-dod-checklist.md @@ -67,6 +67,9 @@ The goal is quality delivery, not just checking boxes.]] [[LLM: Build issues block everyone. Ensure everything compiles and runs cleanly]] - [ ] Project builds successfully without errors. - [ ] Project linting passes + - [ ] All tests pass (unit, integration, etc.) + - [ ] All code changes for this story committed to respective repositories with descriptive messages referencing story number (e.g., `feat: Story X.Y - brief description`) + - [ ] Story file changes (Dev Agent Record, File List, Status) committed - [ ] Any new dependencies added were either pre-approved in the story requirements OR explicitly approved by the user during development (approval documented in story file). - [ ] If new dependencies were added, they are recorded in the appropriate project files (e.g., `package.json`, `requirements.txt`) with justification. - [ ] No known security vulnerabilities introduced by newly added and approved dependencies.