ldy26098
/
BMAD-METHOD
mirror of https://github.com/bmad-code-org/BMAD-METHOD.git
1
0
Fork 0
Code Packages Projects Releases Wiki Activity

refactor(code-review): remove implementation notes from step-01 

Implementation notes for the workflow should be collected in a dedicated
implementation-notes.md file, not embedded in step files. This keeps each
step focused and defers editorial comments to a separate tracking document.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
This commit is contained in:
Alex Verkhovsky 2026-01-05 05:33:27 -08:00
parent 060d5562a4
commit 8fc7db7b97
1 changed files with 7 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
src/modules/bmm/workflows/4-implementation/code-review/steps/step-01-load-story.md
View File

@ -13,6 +13,7 @@ These variables MUST be set in this step and available to all subsequent steps:
- `story_path` - Path to the story file being reviewed - `story_path` - Path to the story file being reviewed
- `story_key` - Story identifier (e.g., "1-2-user-authentication") - `story_key` - Story identifier (e.g., "1-2-user-authentication")
- `story_content` - Complete, unmodified file content from story_path (loaded in substep 2)
- `story_file_list` - Files claimed in story's Dev Agent Record → File List - `story_file_list` - Files claimed in story's Dev Agent Record → File List
- `git_changed_files` - Files actually changed according to git - `git_changed_files` - Files actually changed according to git
- `git_discrepancies` - Mismatches between `story_file_list` and `git_changed_files` - `git_discrepancies` - Mismatches between `story_file_list` and `git_changed_files`
@ -47,8 +48,11 @@ Search for stories with status `review` or `done`. Match by priority:
### 2. Load Story File ### 2. Load Story File
- Read COMPLETE story file from {story_path} **Load file content:**
- Extract `story_key` from filename (e.g., "1-2-user-authentication.md" → "1-2-user-authentication") or story metadata Read the complete contents of {story_path} and assign to `story_content` WITHOUT filtering, truncating or summarizing. If {story_path} cannot be read: report the error to the user and HALT the workflow.
**Extract story identifier:**
Verify the filename ends with `.md` extension. Remove `.md` to get `story_key` (e.g., "1-2-user-authentication.md" → "1-2-user-authentication"). If filename doesn't end with `.md` or the result is empty: report the error to the user and HALT the workflow.
### 3. Parse Story Sections ### 3. Parse Story Sections
@ -121,3 +125,4 @@ Set `git_discrepancies` with categories:
- Skipping git change discovery - Skipping git change discovery
- Not calculating discrepancies - Not calculating discrepancies
- No explicit NEXT directive at step completion - No explicit NEXT directive at step completion