From 8fc7db7b97e54b85c33bdd308dba78ccb909caa3 Mon Sep 17 00:00:00 2001 From: Alex Verkhovsky Date: Mon, 5 Jan 2026 05:33:27 -0800 Subject: [PATCH] refactor(code-review): remove implementation notes from step-01 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Implementation notes for the workflow should be collected in a dedicated implementation-notes.md file, not embedded in step files. This keeps each step focused and defers editorial comments to a separate tracking document. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Haiku 4.5 --- .../code-review/steps/step-01-load-story.md | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/src/modules/bmm/workflows/4-implementation/code-review/steps/step-01-load-story.md b/src/modules/bmm/workflows/4-implementation/code-review/steps/step-01-load-story.md index 9a0a0e9c..f6a6ae11 100644 --- a/src/modules/bmm/workflows/4-implementation/code-review/steps/step-01-load-story.md +++ b/src/modules/bmm/workflows/4-implementation/code-review/steps/step-01-load-story.md @@ -13,6 +13,7 @@ These variables MUST be set in this step and available to all subsequent steps: - `story_path` - Path to the story file being reviewed - `story_key` - Story identifier (e.g., "1-2-user-authentication") +- `story_content` - Complete, unmodified file content from story_path (loaded in substep 2) - `story_file_list` - Files claimed in story's Dev Agent Record → File List - `git_changed_files` - Files actually changed according to git - `git_discrepancies` - Mismatches between `story_file_list` and `git_changed_files` @@ -47,8 +48,11 @@ Search for stories with status `review` or `done`. Match by priority: ### 2. Load Story File -- Read COMPLETE story file from {story_path} -- Extract `story_key` from filename (e.g., "1-2-user-authentication.md" → "1-2-user-authentication") or story metadata +**Load file content:** +Read the complete contents of {story_path} and assign to `story_content` WITHOUT filtering, truncating or summarizing. If {story_path} cannot be read: report the error to the user and HALT the workflow. + +**Extract story identifier:** +Verify the filename ends with `.md` extension. Remove `.md` to get `story_key` (e.g., "1-2-user-authentication.md" → "1-2-user-authentication"). If filename doesn't end with `.md` or the result is empty: report the error to the user and HALT the workflow. ### 3. Parse Story Sections @@ -121,3 +125,4 @@ Set `git_discrepancies` with categories: - Skipping git change discovery - Not calculating discrepancies - No explicit NEXT directive at step completion +