ldy26098
/
BMAD-METHOD
mirror of https://github.com/bmad-code-org/BMAD-METHOD.git
1
0
Fork 0
Code Packages Projects Releases Wiki Activity

fix(bmm): address final review comments on bmad skills 

- step-auto-finalize.md: reflow the bundle-mode `dw_ids` note so the
  inline-code span no longer wraps across a line break (was rendering as
  "dw ids") and restore the dropped list-continuation indent (augment).
- step-03-triage.md: reword the third consecutive "If" to "When" to break
  the repeated sentence opening; logic and {auto_mode} gate unchanged
  (coderabbit nitpick).

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This commit is contained in:
pbean 2026-06-22 06:38:48 -07:00
parent bf30176391
commit 71e9ecd027
2 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/bmm-skills/4-implementation/bmad-code-review/steps/step-03-triage.md
View File

@ -56,7 +56,7 @@
If `{auto_mode}` and a finding would otherwise be `decision_needed`: reclassify as `patch` only when the fix is genuinely unambiguous; otherwise reclassify as `defer` with reason "auto-mode: needs human decision" AND record it in the result escalations — severity `CRITICAL` if it concerns correctness or security of the new code, else `PREFERENCE` (see `../automation-mode.md` rule 5). If `{auto_mode}` and a finding would otherwise be `decision_needed`: reclassify as `patch` only when the fix is genuinely unambiguous; otherwise reclassify as `defer` with reason "auto-mode: needs human decision" AND record it in the result escalations — severity `CRITICAL` if it concerns correctness or security of the new code, else `PREFERENCE` (see `../automation-mode.md` rule 5).
If `{auto_mode}` and a finding's root cause is a defect in the spec itself (the code faithfully implements something the spec got wrong), handle it per `../automation-mode.md` rule 6: if the root cause is inside the spec's `<frozen-after-approval>` block, classify as `defer` and record a `CRITICAL` (`type: spec-defect`) escalation — never patch around frozen, human-owned intent; if the root cause is outside the frozen block, classify as `patch` (correct the code to the evidently right behavior), mark it for the step-04 `## Spec Change Log` append, and record a `PREFERENCE` escalation. When `{auto_mode}` and a finding's root cause is a defect in the spec itself (the code faithfully implements something the spec got wrong), handle it per `../automation-mode.md` rule 6: if the root cause is inside the spec's `<frozen-after-approval>` block, classify as `defer` and record a `CRITICAL` (`type: spec-defect`) escalation — never patch around frozen, human-owned intent; if the root cause is outside the frozen block, classify as `patch` (correct the code to the evidently right behavior), mark it for the step-04 `## Spec Change Log` append, and record a `PREFERENCE` escalation.
5. **Drop** all `dismiss` findings. Record the dismiss count for the summary. (`{auto_mode}`: do NOT drop — set each dismissed finding aside, keeping its title, location, and one-line dismissal reason; step-04 writes them to the Review Ledger so later cycles do not re-litigate them.) 5. **Drop** all `dismiss` findings. Record the dismiss count for the summary. (`{auto_mode}`: do NOT drop — set each dismissed finding aside, keeping its title, location, and one-line dismissal reason; step-04 writes them to the Review Ledger so later cycles do not re-litigate them.)

6
src/bmm-skills/4-implementation/bmad-quick-dev/step-auto-finalize.md
View File

@ -60,9 +60,9 @@ itself.
} }
``` ```
**Bundle mode**: additionally include `"dw_ids": [<the bundle file's dw **Bundle mode**: additionally include
ids, verbatim>]` — the orchestrator rejects the result when the list does `"dw_ids": [<the bundle file's dw ids, verbatim>]` — the orchestrator
not match the bundle. rejects the result when the list does not match the bundle.
6. State in one line what was implemented and end your turn. Do not ask 6. State in one line what was implemented and end your turn. Do not ask
questions, offer next steps, or wait for anything. questions, offer next steps, or wait for anything.