From 71e9ecd0272f836733e5ff57858692886c672a57 Mon Sep 17 00:00:00 2001 From: pbean Date: Mon, 22 Jun 2026 06:38:48 -0700 Subject: [PATCH] fix(bmm): address final review comments on bmad skills - step-auto-finalize.md: reflow the bundle-mode `dw_ids` note so the inline-code span no longer wraps across a line break (was rendering as "dw ids") and restore the dropped list-continuation indent (augment). - step-03-triage.md: reword the third consecutive "If" to "When" to break the repeated sentence opening; logic and {auto_mode} gate unchanged (coderabbit nitpick). Co-Authored-By: Claude Opus 4.8 (1M context) --- .../bmad-code-review/steps/step-03-triage.md | 2 +- .../4-implementation/bmad-quick-dev/step-auto-finalize.md | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/bmm-skills/4-implementation/bmad-code-review/steps/step-03-triage.md b/src/bmm-skills/4-implementation/bmad-code-review/steps/step-03-triage.md index a77b91316..b1151f78b 100644 --- a/src/bmm-skills/4-implementation/bmad-code-review/steps/step-03-triage.md +++ b/src/bmm-skills/4-implementation/bmad-code-review/steps/step-03-triage.md @@ -56,7 +56,7 @@ If `{auto_mode}` and a finding would otherwise be `decision_needed`: reclassify as `patch` only when the fix is genuinely unambiguous; otherwise reclassify as `defer` with reason "auto-mode: needs human decision" AND record it in the result escalations — severity `CRITICAL` if it concerns correctness or security of the new code, else `PREFERENCE` (see `../automation-mode.md` rule 5). - If `{auto_mode}` and a finding's root cause is a defect in the spec itself (the code faithfully implements something the spec got wrong), handle it per `../automation-mode.md` rule 6: if the root cause is inside the spec's `` block, classify as `defer` and record a `CRITICAL` (`type: spec-defect`) escalation — never patch around frozen, human-owned intent; if the root cause is outside the frozen block, classify as `patch` (correct the code to the evidently right behavior), mark it for the step-04 `## Spec Change Log` append, and record a `PREFERENCE` escalation. + When `{auto_mode}` and a finding's root cause is a defect in the spec itself (the code faithfully implements something the spec got wrong), handle it per `../automation-mode.md` rule 6: if the root cause is inside the spec's `` block, classify as `defer` and record a `CRITICAL` (`type: spec-defect`) escalation — never patch around frozen, human-owned intent; if the root cause is outside the frozen block, classify as `patch` (correct the code to the evidently right behavior), mark it for the step-04 `## Spec Change Log` append, and record a `PREFERENCE` escalation. 5. **Drop** all `dismiss` findings. Record the dismiss count for the summary. (`{auto_mode}`: do NOT drop — set each dismissed finding aside, keeping its title, location, and one-line dismissal reason; step-04 writes them to the Review Ledger so later cycles do not re-litigate them.) diff --git a/src/bmm-skills/4-implementation/bmad-quick-dev/step-auto-finalize.md b/src/bmm-skills/4-implementation/bmad-quick-dev/step-auto-finalize.md index 06a71d6fd..12af8298a 100644 --- a/src/bmm-skills/4-implementation/bmad-quick-dev/step-auto-finalize.md +++ b/src/bmm-skills/4-implementation/bmad-quick-dev/step-auto-finalize.md @@ -60,9 +60,9 @@ itself. } ``` - **Bundle mode**: additionally include `"dw_ids": []` — the orchestrator rejects the result when the list does - not match the bundle. + **Bundle mode**: additionally include + `"dw_ids": []` — the orchestrator + rejects the result when the list does not match the bundle. 6. State in one line what was implemented and end your turn. Do not ask questions, offer next steps, or wait for anything.