ldy26098
/
BMAD-METHOD
mirror of https://github.com/bmad-code-org/BMAD-METHOD.git
1
0
Fork 0
Code Packages Projects Releases Wiki Activity

refactor(code-review): remove cargo cult failure modes repetition from step-01 

FAILURE MODES section was just inverted SUCCESS METRICS. Not valuable.
Replaced with single catch-all statement: failure to meet any success metric = failure.

Let actual failure modes emerge from usage patterns, not speculation.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
This commit is contained in:
Alex Verkhovsky 2026-01-05 06:17:37 -08:00
parent 0ae6799cb6
commit 38ab12da85
1 changed files with 3 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
src/modules/bmm/workflows/4-implementation/code-review/steps/step-01-load-story.md
View File

@ -110,17 +110,12 @@ Set `git_discrepancies` with categories:
- `story_path` identified and loaded - `story_path` identified and loaded
- `story_key` extracted - `story_key` extracted
- `story_content` captured completely and unmodified - `story_content` captured completely and unmodified
- `story_file_list` compiled from Dev Agent Record - `story_file_list` compiled from Dev Agent Record (or NO_FILE_LIST if not found)
- `git_changed_files` discovered via git commands - `git_changed_files` discovered via git commands (or NO_GIT if not a git repo)
- `git_discrepancies` calculated - `git_discrepancies` calculated
- Explicit NEXT directive provided - Explicit NEXT directive provided
## FAILURE MODES ## FAILURE MODES
- Proceeding without story file loaded Failure to meet any SUCCESS METRIC constitutes workflow failure.
- Missing `story_key` extraction
- `story_content` incomplete or modified (breaks later steps)
- Skipping git change discovery
- Not calculating discrepancies
- No explicit NEXT directive at step completion