From 38ab12da85d42591a492333bc40f1b2f935d5741 Mon Sep 17 00:00:00 2001 From: Alex Verkhovsky Date: Mon, 5 Jan 2026 06:17:37 -0800 Subject: [PATCH] refactor(code-review): remove cargo cult failure modes repetition from step-01 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit FAILURE MODES section was just inverted SUCCESS METRICS. Not valuable. Replaced with single catch-all statement: failure to meet any success metric = failure. Let actual failure modes emerge from usage patterns, not speculation. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Haiku 4.5 --- .../code-review/steps/step-01-load-story.md | 11 +++-------- 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/src/modules/bmm/workflows/4-implementation/code-review/steps/step-01-load-story.md b/src/modules/bmm/workflows/4-implementation/code-review/steps/step-01-load-story.md index 25a81a2b..bac25ea1 100644 --- a/src/modules/bmm/workflows/4-implementation/code-review/steps/step-01-load-story.md +++ b/src/modules/bmm/workflows/4-implementation/code-review/steps/step-01-load-story.md @@ -110,17 +110,12 @@ Set `git_discrepancies` with categories: - `story_path` identified and loaded - `story_key` extracted - `story_content` captured completely and unmodified -- `story_file_list` compiled from Dev Agent Record -- `git_changed_files` discovered via git commands +- `story_file_list` compiled from Dev Agent Record (or NO_FILE_LIST if not found) +- `git_changed_files` discovered via git commands (or NO_GIT if not a git repo) - `git_discrepancies` calculated - Explicit NEXT directive provided ## FAILURE MODES -- Proceeding without story file loaded -- Missing `story_key` extraction -- `story_content` incomplete or modified (breaks later steps) -- Skipping git change discovery -- Not calculating discrepancies -- No explicit NEXT directive at step completion +Failure to meet any SUCCESS METRIC constitutes workflow failure.