129 lines
3.5 KiB
Plaintext
129 lines
3.5 KiB
Plaintext
=== PR #667: fix - correct status terminology to match story template ===
|
|
|
|
DESCRIPTION:
|
|
Fixes agents setting invalid status values that don't match the story template.
|
|
The story template defines valid status choices as: Draft, Approved, InProgress, Review, Done.
|
|
However agents were incorrectly instructing to set 'Ready for Review' and 'Ready for Done'.
|
|
|
|
ISSUE:
|
|
- bmad-core/agents/dev.md instructed: 'Ready for Review' (invalid)
|
|
- bmad-core/tasks/apply-qa-fixes.md instructed: 'Ready for Done' or 'Ready for Review' (invalid)
|
|
|
|
SOLUTION:
|
|
Changed status terminology to match valid choices:
|
|
- dev.md: 'Ready for Review' → 'Review'
|
|
- apply-qa-fixes.md: 'Ready for Done' → 'Done', 'Ready for Review' → 'Review'
|
|
|
|
BRANCH: feature/status-terminology-667
|
|
|
|
MODIFIED FILES: 2
|
|
- bmad-core/agents/dev.md
|
|
- bmad-core/tasks/apply-qa-fixes.md
|
|
|
|
=== CHANGES SUMMARY ===
|
|
|
|
1. bmad-core/agents/dev.md (1 change)
|
|
- Line 68: set story status: 'Ready for Review' → set story status: 'Review'
|
|
|
|
2. bmad-core/tasks/apply-qa-fixes.md (2 changes)
|
|
- Line 107: set `Status: Ready for Done` → set `Status: Done`
|
|
- Line 108: set `Status: Ready for Review` → set `Status: Review`
|
|
|
|
=== TECHNICAL DETAILS ===
|
|
|
|
Valid Story Status Values (from story-tmpl.yaml):
|
|
- Draft
|
|
- Approved
|
|
- InProgress
|
|
- Review
|
|
- Done
|
|
|
|
Why This Fix Matters:
|
|
- Ensures agents set valid status values per schema
|
|
- Prevents template validation failures
|
|
- Maintains consistency across all agent instructions
|
|
- Improves story workflow management
|
|
|
|
Type of Change: Bug fix (non-breaking)
|
|
|
|
=== VALIDATION RESULTS ===
|
|
|
|
✅ npm run validate: PASS
|
|
- All 10 agents validated successfully
|
|
- All 4 teams validated successfully
|
|
- Configuration: All valid
|
|
|
|
✅ npm run lint: PASS
|
|
- 0 new lint errors from PR #667
|
|
- 3 pre-existing errors (unrelated to this PR)
|
|
- No syntax errors introduced
|
|
|
|
✅ File Modification Test: PASS
|
|
- 2 files modified as specified
|
|
- 3 lines changed exactly as required
|
|
- All changes match PR specification
|
|
|
|
✅ No Regressions: PASS
|
|
- Core system unaffected
|
|
- Backward compatible
|
|
- No breaking changes
|
|
|
|
=== TESTING STATUS ===
|
|
|
|
Total Tests: 4
|
|
Passed: 4 ✅
|
|
Failed: 0 ❌
|
|
|
|
Test 1: File Modification ✅
|
|
Test 2: npm validate ✅
|
|
Test 3: npm lint ✅
|
|
Test 4: No Regressions ✅
|
|
|
|
Overall: READY FOR PRODUCTION ✅
|
|
|
|
=== IMPACT ANALYSIS ===
|
|
|
|
Scope: Minimal
|
|
- Single agent file: dev.md (1 line)
|
|
- Single task file: apply-qa-fixes.md (2 lines)
|
|
- Total: 2 files, 3 lines changed
|
|
|
|
Risk Level: MINIMAL ✅
|
|
- No API changes
|
|
- No dependency changes
|
|
- No behavior changes to core system
|
|
- Backward compatible
|
|
- Improves compliance with template schema
|
|
- Affects only status terminology, not workflow logic
|
|
|
|
Breaking Changes: None
|
|
|
|
=== DOCUMENTATION ===
|
|
|
|
Diffs available in .patch/667/:
|
|
- dev.667.diff (1 line change)
|
|
- apply-qa-fixes.667.diff (2 lines change)
|
|
|
|
Test results: TEST-RESULTS.md
|
|
Implementation plan: IMPLEMENTATION-PLAN.md
|
|
|
|
=== BENEFITS ===
|
|
|
|
1. **Template Compliance**: Agents now use valid status values from schema
|
|
2. **Consistency**: All instructions use same valid status terminology
|
|
3. **Quality**: Prevents template validation errors
|
|
4. **Maintenance**: Easier to understand and update agent instructions
|
|
5. **Workflow**: Ensures proper story status transitions
|
|
|
|
=== NOTES ===
|
|
|
|
- Changes are minimal and highly focused
|
|
- No configuration changes needed
|
|
- Backward compatible
|
|
- Improves system reliability
|
|
- Affects agent instructions only, not core logic
|
|
|
|
GitHub PR: https://github.com/bmad-code-org/BMAD-METHOD/pull/667
|
|
|
|
Status: READY FOR IMMEDIATE MERGE ✅
|