--- deferred_work_file: '{implementation_artifacts}/deferred-work.md' --- # Step One-Shot: Implement, Review, Present ## RULES - YOU MUST ALWAYS SPEAK OUTPUT in your Agent communication style with the config `{communication_language}` - NEVER auto-push. ## INSTRUCTIONS ### Pre-Implementation Check **CRITICAL: Calculate structural blast radius and obtain human approval before ANY code modification. NEVER skip this check.** 1. **Identify targets**: Derive the symbols/files being modified from the clarified user intent. If ambiguous, ask the user for explicit targets. 2. **Verify Memtrace availability**: Check if the Memtrace MCP server is reachable by calling the adapter: `node _bmad/scripts/memtrace/memtrace-adapter.mjs --query list_repos`. If exit 0 — server is reachable (parse STDOUT JSON for repository list). If exit 1 — HALT: "Memtrace MCP server is not available. Structural blast radius verification cannot be performed. Please start the Memtrace server or explicitly override this safety check." 3. **Calculate blast radius**: For each target symbol, call the memtrace-adapter: `node _bmad/scripts/memtrace/memtrace-adapter.mjs --target --query get_impact`. Process targets SEQUENTIALLY — NEVER use `Promise.all`. If adapter exits with code 1 → HALT (timeout or unavailable). Parse the STDOUT JSON extracting `risk_level`, `affected_symbols`, and `affected_files`. 4. **Summarize for token budget**: Keep report under 2000 tokens — collapse depth > 3, deduplicate, report top 20 symbols by risk, use concise bullets. 5. **Present Blast Radius Confidence Report**: ``` ## Blast Radius Confidence Report **Target:** [symbol/file] **Risk Level:** [Low/Medium/High/Critical] **Affected Symbols:** N across M files ### Critical Dependents (Depth 1-2) - `symbol` in `file` — relationship ### Module Impact Summary - module: N symbols --- **Decision Required:** [A] Approve / [R] Reject ``` 5a. **Generate Test Coverage Justification**: Before halting for user approval, map each affected module from the blast radius report to test files covering the impacted symbols: - Discover test files using conventions: `test/`, `__tests__/`, `*.test.*`, `*.spec.*` patterns — search/grep for affected symbol names in test files - Assign a coverage status per module: `Yes` (all covered), `Partial:N` (N of M covered), or `None` (no tests found) - Append the justification using this format after the "---" separator in the Confidence Report: ``` ### Test Coverage Justification | Module | Affected Symbols | Test Files | Coverage | |--------|-----------------|------------|----------| | `path/to/module` | N symbols | `test/module.test.ts` | Yes | | `path/to/other` | M symbols | — | **None** | **Coverage Summary:** - **Covered:** X/Y modules (Z affected symbols) - **Uncovered:** A/Y modules (B affected symbols — needs tests) - **Partial:** C/Y modules (D/N symbols covered) **Justification Notes:** - `module-A`: Covered by existing tests in `test/module-a.test.ts` - `module-B`: No test coverage found — requires new test file - `module-C`: Partial coverage — `test/module-c.test.ts` covers 3 of 5 impacted functions ``` - If the blast radius has zero affected modules, skip the justification and note "No affected modules to map" - Enforce combined token budget (blast radius + justification ≤ 2000 tokens). Prioritize: uncovered modules, then high-risk, then covered - Ask the user for a coverage threshold percentage (0 = never block, 100 = block if any uncovered); default to flag-only mode if declined - Write the full Test Coverage Justification into `{spec_file}`'s completion notes before proceeding 5b. **Execute Mathematical Quality Gate (Phase 2)**: If the blast radius has zero affected modules, skip this step and note "Mathematical Quality Gate: SKIPPED (empty blast radius)." Otherwise: - Serialize the blast radius data and test coverage data to temporary JSON files in the system temp directory - Use the user-provided coverage threshold (default 100 if none given) - Run: `node _bmad/scripts/memtrace/qa-memtrace.mjs --blast-radius --test-coverage --threshold ` - Read the script's STDOUT and capture its exit code - **If exit 0**: log the output to `{spec_file}` completion notes under "Mathematical Quality Gate Output" and continue - **If exit 1**: persist the output to `{spec_file}` completion notes, present the uncovered nodes, then HALT: "Mathematical quality gate failed. N of M required nodes are not covered by tests. Agent must write/update tests before proceeding." - The qa-memtrace.mjs exit code is the FINAL authority. Exit 1 is a HARD BLOCK on implementation. 5c. **Dead Code Pitfall Validation**: If the story involves dead-code removal (find_dead_code usage): - Call the memtrace-adapter: `node _bmad/scripts/memtrace/memtrace-adapter.mjs --target --query find_dead_code [--repo ]`. Process sequentially — NEVER use `Promise.all`. Parse the adapter's STDOUT JSON for the `symbols` array. - Serialize candidates to a temp JSON file. - Run: `node _bmad/scripts/memtrace/validate-dead-code.mjs --candidates ` - If exit 0: log output to `{spec_file}` completion notes as "Dead Code Pitfall Validation Report". Present SUSPECT entries for manual review. Ignore FALSE_POS and GHOST. - If exit 1: log error and proceed (error is logged, not a hard block). - Clean up temp files. - If story does NOT involve dead-code removal, skip this step entirely. 6. **HALT for decision**: Ask user: "[A] Approve — proceed | [R] Reject — halt" - Approve → continue to Implement below - Reject → HALT --- ### Implement Follow `./sync-sprint-status.md` with `{target_status}` = `in-progress`. Implement the clarified intent directly. ### Review Invoke the `bmad-review-adversarial-general` skill in a subagent with the changed files. The subagent gets NO conversation context — to avoid anchoring bias. Launch at the same model capability as the current session. If no sub-agents are available, write the changed files to a review prompt file in `{implementation_artifacts}` and HALT. Ask the human to run the review in a separate session and paste back the findings. ### Classify Deduplicate all review findings. Three categories only: - **patch** — trivially fixable. Auto-fix immediately. - **defer** — pre-existing issue not caused by this change. Append to `{deferred_work_file}`. - **reject** — noise. Drop silently. If a finding is caused by this change but too significant for a trivial patch, HALT and present it to the human for decision before proceeding. ### Generate Spec Trace Set `{title}` = a concise title derived from the clarified intent. Write `{spec_file}` using `./spec-template.md`. Fill only these sections — delete all others: 1. **Frontmatter** — set `title: '{title}'`, `type`, `created`, `status: 'done'`. Add `route: 'one-shot'`. 2. **Title and Intent** — `# {title}` heading and `## Intent` with **Problem** and **Approach** lines. Reuse the summary you already generated for the terminal. 3. **Suggested Review Order** — append after Intent. Build using the same convention as `./step-05-present.md` § "Generate Suggested Review Order" (spec-file-relative links, concern-based ordering, ultra-concise framing). Follow `./sync-sprint-status.md` with `{target_status}` = `review`. ### Commit If version control is available and the tree is dirty, create a local commit with a conventional message derived from the intent. If VCS is unavailable, skip. ### Present 1. Open the spec in the user's editor so they can click through the Suggested Review Order: - Resolve two absolute paths: (1) the repository root (`git rev-parse --show-toplevel` — returns the worktree root when in a worktree, project root otherwise; if this fails, fall back to the current working directory), (2) `{spec_file}`. Run `code -r "{absolute-root}" "{absolute-spec-file}"` — the root first so VS Code opens in the right context, then the spec file. Always double-quote paths to handle spaces and special characters. - If `code` is not available (command fails), skip gracefully and tell the user the spec file path instead. 2. Display a summary in conversation output, including: - The commit hash (if one was created). - List of files changed with one-line descriptions. Any file paths shown in conversation/terminal output must use CWD-relative format (no leading `/`) with `:line` notation (e.g., `src/path/file.ts:42`) for terminal clickability — this differs from spec-file links which use spec-file-relative paths. - Review findings breakdown: patches applied, items deferred, items rejected. If all findings were rejected, say so. - A note that the spec is open in their editor (or the file path if it couldn't be opened). Mention that `{spec_file}` now contains a Suggested Review Order. - **Navigation tip:** "Ctrl+click (Cmd+click on macOS) the links in the Suggested Review Order to jump to each stop." 3. Offer to push and/or create a pull request. HALT and wait for human input. Workflow complete. ## On Complete Run: `python3 {project-root}/_bmad/scripts/resolve_customization.py --skill {skill-root} --key workflow.on_complete` If the resolved `workflow.on_complete` is non-empty, follow it as the final terminal instruction before exiting.