Compare commits

...

5 Commits

Author SHA1 Message Date
gabadi 70240c82cf
Merge b161491ca8 into c9d9316e97 2026-06-06 14:23:29 +07:00
Alex Verkhovsky c9d9316e97
fix: clarify quick dev subagent use (#2450)
* fix: clarify quick dev subagent use

* fix: clarify subagent use in more workflows
2026-06-04 04:49:40 -07:00
Alex Verkhovsky b161491ca8
Merge branch 'main' into fix/quick-dev-review-data-loss-classification 2026-03-30 20:40:56 -07:00
gabadi 98f8786060 fix: reframe data-loss clause to align with 'caused/exposed by change' language 2026-03-27 01:03:34 -03:00
gabadi 229c1c57f9 fix: extend bad_spec classification to cover data-loss findings within story domain 2026-03-27 00:58:09 -03:00
4 changed files with 10 additions and 1 deletions

View File

@ -9,6 +9,9 @@ description: 'Review code changes adversarially using parallel review layers (Bl
**Your Role:** You are an elite code reviewer. You gather context, launch parallel adversarial reviews, triage findings with precision, and present actionable results. No noise, no filler.
Subagents, when the capability is available, are an important part of this workflow. Use them as directed by the workflow steps.
If you need an explicit user instruction to run them, ask once now for the whole workflow run.
## Conventions
- Bare paths (e.g. `checklist.md`) resolve from the skill root.

View File

@ -16,6 +16,9 @@ description: 'Creates a dedicated story file with all the context the agent will
- SAVE QUESTIONS: If you think of questions or clarifications during analysis, save them for the end after the complete story is written
- ZERO USER INTERVENTION: Process should be fully automated except for initial epic/story selection or missing documents
Subagents, when the capability is available, are an important part of this workflow. Use them as directed by the workflow steps.
If you need an explicit user instruction to run them, ask once now for the whole workflow run.
## Conventions
- Bare paths (e.g. `discover-inputs.md`) resolve from the skill root.

View File

@ -9,6 +9,9 @@ description: 'Implements any user intent, requirement, story, bug fix or change
**CRITICAL:** If a step says "read fully and follow step-XX", you read and follow step-XX. No exceptions.
Subagents, when the capability is available, are an important part of this workflow. Use them as directed by the workflow steps.
If you need an explicit user instruction to run them, ask once now for the whole workflow run.
## READY FOR DEVELOPMENT STANDARD
A specification is "Ready for Development" when:

View File

@ -34,7 +34,7 @@ Launch three subagents without conversation context. If no sub-agents are availa
1. Deduplicate all review findings.
2. Classify each finding. The first three categories are **this story's problem** — caused or exposed by the current change. The last two are **not this story's problem**.
- **intent_gap** — caused by the change; cannot be resolved from the spec because the captured intent is incomplete. Do not infer intent unless there is exactly one possible reading.
- **bad_spec** — caused by the change, including direct deviations from spec. The spec should have been clear enough to prevent it. When in doubt between bad_spec and patch, prefer bad_spec — a spec-level fix is more likely to produce coherent code.
- **bad_spec** — caused by the change, including direct deviations from spec. The spec should have been clear enough to prevent it. When in doubt between bad_spec and patch, prefer bad_spec — a spec-level fix is more likely to produce coherent code. Also applies when the story's domain includes data silently dropped or never reaching its destination — the change exposed it.
- **patch** — caused by the change; trivially fixable without human input. Just part of the diff.
- **defer** — pre-existing issue not caused by this story, surfaced incidentally by the review. Collect for later focused attention.
- **reject** — noise. Drop silently. When unsure between defer and reject, prefer reject — only defer findings you are confident are real.