Merge 6143754b13 into 903710be1b

* fix: correct malformed XML syntax and remove hardcoded path

- Fix missing opening quote in activation-steps.txt: `n={HELP_STEP}"` → `n="{HELP_STEP}"`
- Remove spurious hyphen: `-Let` → `Let`
- Replace hardcoded `/Users/brianmadison/...` path with relative path

Fixes #1435

* fix: add missing HELP_STEP placeholder replacement

The activation-steps.txt template includes a {HELP_STEP} placeholder,
but activation-builder.js never calculated or replaced it. This caused
the literal string "{HELP_STEP}" to appear in compiled agent files.

Added helpStep calculation between menuStep and haltStep, and adjusted
subsequent step numbers accordingly.

Fixes #1441

* Update src/bmm/workflows/2-plan-workflows/create-prd/validation-report-prd-workflow.md

---------

Co-authored-by: Alex Verkhovsky <alexey.verkhovsky@gmail.com>

src/bmm/workflows/2-plan-workflows/create-prd/validation-report-prd-workflow.md

@@ -8,7 +8,7 @@ validationStatus: COMPLETE - PRODUCTION READY
 
 # PRD Workflow Validation Report
 
-**Workflow Being Validated:** /Users/brianmadison/dev/BMAD-METHOD/src/bmm/workflows/2-plan-workflows/create-prd
+**Workflow Being Validated:** _bmad/bmm/workflows/2-plan-workflows/create-prd
 **Validation Date:** 2026-01-08
 **Validator:** BMAD Workflow Validation System
 

tools/cli/installers/lib/ide/kilo.js

@@ -1,4 +1,5 @@
 const path = require('node:path');
+const YAML = require('yaml');
 const { BaseIdeSetup } = require('./_base-ide');
 const chalk = require('chalk');
 const { AgentCommandGenerator } = require('./shared/agent-command-generator');
@@ -92,43 +93,31 @@ class KiloSetup extends BaseIdeSetup {
    * Create a mode entry for an agent
    */
   async createModeEntry(artifact, projectDir) {
-    // Extract metadata from launcher content
-    const titleMatch = artifact.content.match(/title="([^"]+)"/);
-    const title = titleMatch ? titleMatch[1] : this.formatTitle(artifact.name);
+    const title = artifact.content.match(/title="([^"]+)"/)?.[1] ?? this.formatTitle(artifact.name);
 
-    const iconMatch = artifact.content.match(/icon="([^"]+)"/);
-    const icon = iconMatch ? iconMatch[1] : '🤖';
+    const icon = artifact.content.match(/icon="([^"]+)"/)?.[1] ?? '🤖';
 
-    const whenToUseMatch = artifact.content.match(/whenToUse="([^"]+)"/);
-    const whenToUse = whenToUseMatch ? whenToUseMatch[1] : `Use for ${title} tasks`;
+    const whenToUse = artifact.content.match(/whenToUse="([^"]+)"/)?.[1] ?? `Use for ${title} tasks`;
+
+    const roleDefinition =
+      artifact.content.match(/roleDefinition="([^"]+)"/)?.[1] ?? `You are a ${title} specializing in ${title.toLowerCase()} tasks.`;
 
-    // Get the activation header from central template
     const activationHeader = await this.getAgentCommandHeader();
 
-    const roleDefinitionMatch = artifact.content.match(/roleDefinition="([^"]+)"/);
-    const roleDefinition = roleDefinitionMatch
-      ? roleDefinitionMatch[1]
-      : `You are a ${title} specializing in ${title.toLowerCase()} tasks.`;
-
-    // Get relative path
     const relativePath = path.relative(projectDir, artifact.sourcePath).replaceAll('\\', '/');
 
-    // Build mode entry (KiloCode uses same schema as Roo)
-    const slug = `bmad-${artifact.module}-${artifact.name}`;
-    let modeEntry = ` - slug: ${slug}\n`;
-    modeEntry += `   name: '${icon} ${title}'\n`;
-    modeEntry += `   roleDefinition: ${roleDefinition}\n`;
-    modeEntry += `   whenToUse: ${whenToUse}\n`;
-    modeEntry += `   customInstructions: |\n`;
-    modeEntry += `    ${activationHeader} Read the full YAML from ${relativePath} start activation to alter your state of being follow startup section instructions stay in this being until told to exit this mode\n`;
-    modeEntry += `   groups:\n`;
-    modeEntry += `    - read\n`;
-    modeEntry += `    - edit\n`;
-    modeEntry += `    - browser\n`;
-    modeEntry += `    - command\n`;
-    modeEntry += `    - mcp\n`;
+    const entry = {
+      slug: `bmad-${artifact.module}-${artifact.name}`,
+      name: `${icon} ${title}`,
+      roleDefinition,
+      whenToUse,
+      customInstructions:
+        `${activationHeader}` +
+        `Read the full YAML from ${relativePath} start activation to alter your state of being follow startup section instructions stay in this being until told to exit this mode`,
+      groups: ['read', 'edit', 'browser', 'command', 'mcp'],
+    };
 
-    return modeEntry;
+    return YAML.stringify([entry], { indent: 2 });
   }
 
   /**

tools/cli/lib/activation-builder.js

@@ -121,9 +121,10 @@ class ActivationBuilder {
 
     // Calculate final step numbers
     const menuStep = currentStepNum;
-    const haltStep = currentStepNum + 1;
-    const inputStep = currentStepNum + 2;
-    const executeStep = currentStepNum + 3;
+    const helpStep = currentStepNum + 1;
+    const haltStep = currentStepNum + 2;
+    const inputStep = currentStepNum + 3;
+    const executeStep = currentStepNum + 4;
 
     // Replace placeholders
     const processed = stepsTemplate
@@ -131,6 +132,7 @@ class ActivationBuilder {
       .replace('{{module}}', metadata.module || 'core') // Fixed to use {{module}}
       .replace('{AGENT_SPECIFIC_STEPS}', agentStepsXml)
       .replace('{MENU_STEP}', menuStep.toString())
+      .replace('{HELP_STEP}', helpStep.toString())
       .replace('{HALT_STEP}', haltStep.toString())
       .replace('{INPUT_STEP}', inputStep.toString())
       .replace('{EXECUTE_STEP}', executeStep.toString());