Merge e9cce0f848 into c748f0f6cc

Fixed inconsistent variable naming in workflow instruction files across
CIS, BMGD, and BMM modules. The standard variable format uses hyphens
({project-root}) not underscores ({project_root}).

Affected files:
- CIS: problem-solving, innovation-strategy, design-thinking, storytelling
- BMGD: brainstorm-game, narrative, create-story checklist
- BMM: excalidraw diagrams, create-story checklist

Co-authored-by: Claude <noreply@anthropic.com>
Co-authored-by: Brian <bmadcode@gmail.com>

docs/modules/bmgd-bmad-game-dev/workflows-guide.md

@@ -161,7 +161,7 @@ Production workflows inherit from BMM and add game-specific overrides.
 **Command:** `sprint-planning`
 **Agent:** Game Scrum Master
 **Input:** GDD with epics
-**Output:** `{output_folder}/sprint-status.yaml`
+**Output:** `{implementation_artifacts}/sprint-status.yaml`
 
 **Description:**
 Generates or updates sprint tracking from epic files. Sets up the sprint backlog and tracking.

src/modules/bmgd/workflows/1-preproduction/brainstorm-game/instructions.md

@@ -1,4 +1,4 @@
-<critical>The workflow execution engine is governed by: {project_root}/_bmad/core/tasks/workflow.xml</critical>
+<critical>The workflow execution engine is governed by: {project-root}/_bmad/core/tasks/workflow.xml</critical>
 <critical>You MUST have already loaded and processed: {installed_path}/workflow.yaml</critical>
 <critical>Communicate all responses in {communication_language}</critical>
 <critical>This is a meta-workflow that orchestrates the CIS brainstorming workflow with game-specific context and additional game design techniques</critical>

src/modules/bmgd/workflows/2-design/narrative/instructions-narrative.md

@@ -2,7 +2,7 @@
 
 <workflow>
 
-<critical>The workflow execution engine is governed by: {project_root}/_bmad/core/tasks/workflow.xml</critical>
+<critical>The workflow execution engine is governed by: {project-root}/_bmad/core/tasks/workflow.xml</critical>
 <critical>You MUST have already completed the GDD workflow</critical>
 <critical>Communicate all responses in {communication_language}</critical>
 <critical>This workflow creates detailed narrative content for story-driven games</critical>

src/modules/bmgd/workflows/4-production/code-review/workflow.yaml

@@ -12,7 +12,7 @@ user_skill_level: "{config_source}:user_skill_level"
 document_output_language: "{config_source}:document_output_language"
 date: system-generated
 implementation_artifacts: "{config_source}:implementation_artifacts"
-sprint_status: "{implementation_artifacts}/sprint-status.yaml || {output_folder}/sprint-status.yaml"
+sprint_status: "{implementation_artifacts}/sprint-status.yaml"
 
 # Workflow components
 installed_path: "{project-root}/_bmad/bmgd/workflows/4-production/code-review"

src/modules/bmgd/workflows/4-production/correct-course/workflow.yaml

@@ -11,7 +11,7 @@ user_skill_level: "{config_source}:user_skill_level"
 document_output_language: "{config_source}:document_output_language"
 date: system-generated
 implementation_artifacts: "{config_source}:implementation_artifacts"
-sprint_status: "{implementation_artifacts}/sprint-status.yaml || {output_folder}/sprint-status.yaml"
+sprint_status: "{implementation_artifacts}/sprint-status.yaml"
 
 # Smart input file references - handles both whole docs and sharded docs
 # Priority: Whole document first, then sharded version

src/modules/bmgd/workflows/4-production/create-story/checklist.md

@@ -33,7 +33,7 @@ This is a COMPETITION to create the **ULTIMATE story context** that makes LLM de
 
 ### **When Running from Create-Story Workflow:**
 
-- The `{project_root}/_bmad/core/tasks/validate-workflow.xml` framework will automatically:
+- The `{project-root}/_bmad/core/tasks/validate-workflow.xml` framework will automatically:
   - Load this checklist file
   - Load the newly created story file (`{story_file_path}`)
   - Load workflow variables from `{installed_path}/workflow.yaml`
@@ -63,7 +63,7 @@ You will systematically re-do the entire story creation process, but with a crit
 
 1. **Load the workflow configuration**: `{installed_path}/workflow.yaml` for variable inclusion
 2. **Load the story file**: `{story_file_path}` (provided by user or discovered)
-3. **Load validation framework**: `{project_root}/_bmad/core/tasks/validate-workflow.xml`
+3. **Load validation framework**: `{project-root}/_bmad/core/tasks/validate-workflow.xml`
 4. **Extract metadata**: epic_num, story_num, story_key, story_title from story file
 5. **Resolve all workflow variables**: story_dir, output_folder, epics_file, architecture_file, etc.
 6. **Understand current status**: What story implementation guidance is currently provided?

src/modules/bmgd/workflows/4-production/create-story/workflow.yaml

@@ -19,7 +19,7 @@ validation: "{installed_path}/checklist.md"
 
 # Variables and inputs
 variables:
-  sprint_status: "{implementation_artifacts}/sprint-status.yaml || {output_folder}/sprint-status.yaml" # Primary source for story tracking
+  sprint_status: "{implementation_artifacts}/sprint-status.yaml || {implementation_artifacts}/sprint-status.yaml" # Primary source for story tracking
   epics_file: "{output_folder}/epics.md" # Preferred source for epic/story breakdown
   prd_file: "{output_folder}/PRD.md" # Fallback for requirements
   architecture_file: "{planning_artifacts}/architecture.md" # Optional architecture context

src/modules/bmgd/workflows/4-production/dev-story/workflow.yaml

@@ -16,7 +16,7 @@ story_file: "" # Explicit story path; auto-discovered if empty
 # Context file uses same story_key as story file (e.g., "1-2-user-authentication.context.xml")
 context_file: "{story_dir}/{{story_key}}.context.xml"
 implementation_artifacts: "{config_source}:implementation_artifacts"
-sprint_status: "{implementation_artifacts}/sprint-status.yaml || {output_folder}/sprint-status.yaml"
+sprint_status: "{implementation_artifacts}/sprint-status.yaml || {implementation_artifacts}/sprint-status.yaml"
 
 # Smart input file references - handles both whole docs and sharded docs
 # Priority: Whole document first, then sharded version

src/modules/bmgd/workflows/4-production/retrospective/workflow.yaml

@@ -54,7 +54,7 @@ input_file_patterns:
     load_strategy: "INDEX_GUIDED"
 
 # Required files
-sprint_status_file: "{implementation_artifacts}/sprint-status.yaml || {output_folder}/sprint-status.yaml"
+sprint_status_file: "{implementation_artifacts}/sprint-status.yaml || {implementation_artifacts}/sprint-status.yaml"
 story_directory: "{implementation_artifacts}"
 retrospectives_folder: "{implementation_artifacts}"
 

src/modules/bmgd/workflows/4-production/sprint-status/workflow.yaml

@@ -18,14 +18,14 @@ instructions: "{installed_path}/instructions.md"
 
 # Inputs
 variables:
-  sprint_status_file: "{implementation_artifacts}/sprint-status.yaml || {output_folder}/sprint-status.yaml"
+  sprint_status_file: "{implementation_artifacts}/sprint-status.yaml || {implementation_artifacts}/sprint-status.yaml"
   tracking_system: "file-system"
 
 # Smart input file references
 input_file_patterns:
   sprint_status:
     description: "Sprint status file generated by sprint-planning"
-    whole: "{implementation_artifacts}/sprint-status.yaml || {output_folder}/sprint-status.yaml"
+    whole: "{implementation_artifacts}/sprint-status.yaml || {implementation_artifacts}/sprint-status.yaml"
     load_strategy: "FULL_LOAD"
 
 # Standalone so IDE commands get generated

src/modules/bmm/workflows/4-implementation/correct-course/workflow.yaml

@@ -13,7 +13,7 @@ implementation_artifacts: "{config_source}:implementation_artifacts"
 planning_artifacts: "{config_source}:planning_artifacts"
 project_knowledge: "{config_source}:project_knowledge"
 output_folder: "{implementation_artifacts}"
-sprint_status: "{implementation_artifacts}/sprint-status.yaml || {output_folder}/sprint-status.yaml"
+sprint_status: "{implementation_artifacts}/sprint-status.yaml"
 
 # Smart input file references - handles both whole docs and sharded docs
 # Priority: Whole document first, then sharded version

src/modules/bmm/workflows/4-implementation/create-story/checklist.md

@@ -33,7 +33,7 @@ This is a COMPETITION to create the **ULTIMATE story context** that makes LLM de
 
 ### **When Running from Create-Story Workflow:**
 
-- The `{project_root}/_bmad/core/tasks/validate-workflow.xml` framework will automatically:
+- The `{project-root}/_bmad/core/tasks/validate-workflow.xml` framework will automatically:
   - Load this checklist file
   - Load the newly created story file (`{story_file_path}`)
   - Load workflow variables from `{installed_path}/workflow.yaml`
@@ -63,7 +63,7 @@ You will systematically re-do the entire story creation process, but with a crit
 
 1. **Load the workflow configuration**: `{installed_path}/workflow.yaml` for variable inclusion
 2. **Load the story file**: `{story_file_path}` (provided by user or discovered)
-3. **Load validation framework**: `{project_root}/_bmad/core/tasks/validate-workflow.xml`
+3. **Load validation framework**: `{project-root}/_bmad/core/tasks/validate-workflow.xml`
 4. **Extract metadata**: epic_num, story_num, story_key, story_title from story file
 5. **Resolve all workflow variables**: story_dir, output_folder, epics_file, architecture_file, etc.
 6. **Understand current status**: What story implementation guidance is currently provided?

src/modules/bmm/workflows/4-implementation/create-story/workflow.yaml

@@ -20,7 +20,7 @@ validation: "{installed_path}/checklist.md"
 
 # Variables and inputs
 variables:
-  sprint_status: "{implementation_artifacts}/sprint-status.yaml || {output_folder}/sprint-status.yaml" # Primary source for story tracking
+  sprint_status: "{implementation_artifacts}/sprint-status.yaml" # Primary source for story tracking
   epics_file: "{planning_artifacts}/epics.md" # Enhanced epics+stories with BDD and source hints
   prd_file: "{planning_artifacts}/prd.md" # Fallback for requirements (if not in epics file)
   architecture_file: "{planning_artifacts}/architecture.md" # Fallback for constraints (if not in epics file)

src/modules/bmm/workflows/4-implementation/sprint-status/workflow.yaml

@@ -19,14 +19,14 @@ instructions: "{installed_path}/instructions.md"
 
 # Inputs
 variables:
-  sprint_status_file: "{implementation_artifacts}/sprint-status.yaml || {output_folder}/sprint-status.yaml"
+  sprint_status_file: "{implementation_artifacts}/sprint-status.yaml"
   tracking_system: "file-system"
 
 # Smart input file references
 input_file_patterns:
   sprint_status:
     description: "Sprint status file generated by sprint-planning"
-    whole: "{implementation_artifacts}/sprint-status.yaml || {output_folder}/sprint-status.yaml"
+    whole: "{implementation_artifacts}/sprint-status.yaml"
     load_strategy: "FULL_LOAD"
 
 # Standalone so IDE commands get generated

src/modules/bmm/workflows/excalidraw-diagrams/create-dataflow/instructions.md

@@ -1,7 +1,7 @@
 # Create Data Flow Diagram - Workflow Instructions
 
 ```xml
-<critical>The workflow execution engine is governed by: {project_root}/_bmad/core/tasks/workflow.xml</critical>
+<critical>The workflow execution engine is governed by: {project-root}/_bmad/core/tasks/workflow.xml</critical>
 <critical>You MUST have already loaded and processed: {installed_path}/workflow.yaml</critical>
 <critical>This workflow creates data flow diagrams (DFD) in Excalidraw format.</critical>
 

src/modules/bmm/workflows/excalidraw-diagrams/create-diagram/instructions.md

@@ -1,7 +1,7 @@
 # Create Diagram - Workflow Instructions
 
 ```xml
-<critical>The workflow execution engine is governed by: {project_root}/_bmad/core/tasks/workflow.xml</critical>
+<critical>The workflow execution engine is governed by: {project-root}/_bmad/core/tasks/workflow.xml</critical>
 <critical>You MUST have already loaded and processed: {installed_path}/workflow.yaml</critical>
 <critical>This workflow creates system architecture diagrams, ERDs, UML diagrams, or general technical diagrams in Excalidraw format.</critical>
 

src/modules/bmm/workflows/excalidraw-diagrams/create-flowchart/instructions.md

@@ -1,7 +1,7 @@
 # Create Flowchart - Workflow Instructions
 
 ```xml
-<critical>The workflow execution engine is governed by: {project_root}/_bmad/core/tasks/workflow.xml</critical>
+<critical>The workflow execution engine is governed by: {project-root}/_bmad/core/tasks/workflow.xml</critical>
 <critical>You MUST have already loaded and processed: {installed_path}/workflow.yaml</critical>
 <critical>This workflow creates a flowchart visualization in Excalidraw format for processes, pipelines, or logic flows.</critical>
 

src/modules/bmm/workflows/excalidraw-diagrams/create-wireframe/instructions.md

@@ -1,7 +1,7 @@
 # Create Wireframe - Workflow Instructions
 
 ```xml
-<critical>The workflow execution engine is governed by: {project_root}/_bmad/core/tasks/workflow.xml</critical>
+<critical>The workflow execution engine is governed by: {project-root}/_bmad/core/tasks/workflow.xml</critical>
 <critical>You MUST have already loaded and processed: {installed_path}/workflow.yaml</critical>
 <critical>This workflow creates website or app wireframes in Excalidraw format.</critical>
 

src/modules/bmm/workflows/testarch/test-design/instructions.md

@@ -25,11 +25,11 @@ The workflow auto-detects which mode to use based on project phase.
 ### Mode Detection
 
 1. **Check for sprint-status.yaml**
-   - If `{output_folder}/bmm-sprint-status.yaml` exists → **Epic-Level Mode** (Phase 4)
+   - If `{implementation_artifacts}/sprint-status.yaml` exists → **Epic-Level Mode** (Phase 4)
    - If NOT exists → Check workflow status
 
 2. **Check workflow-status.yaml**
-   - Read `{output_folder}/bmm-workflow-status.yaml`
+   - Read `{planning_artifacts}/bmm-workflow-status.yaml`
    - If `implementation-readiness: required` or `implementation-readiness: recommended` → **System-Level Mode** (Phase 3)
    - Otherwise → **Epic-Level Mode** (Phase 4 without sprint status yet)
 

src/modules/bmm/workflows/workflow-status/instructions.md

@@ -197,7 +197,7 @@ Your choice:</ask>
 <!-- ============================================= -->
 
 <step n="10" goal="Validate mode - Check if calling workflow should proceed">
-<action>Read {output_folder}/bmm-workflow-status.yaml if exists</action>
+<action>Read {planning_artifacts}/bmm-workflow-status.yaml if exists</action>
 
 <check if="status file not found">
   <template-output>status_exists = false</template-output>
@@ -261,7 +261,7 @@ Your choice:</ask>
 </step>
 
 <step n="20" goal="Data mode - Extract specific information">
-<action>Read {output_folder}/bmm-workflow-status.yaml if exists</action>
+<action>Read {planning_artifacts}/bmm-workflow-status.yaml if exists</action>
 
 <check if="status file not found">
   <template-output>status_exists = false</template-output>
@@ -309,7 +309,7 @@ Your choice:</ask>
 </step>
 
 <step n="30" goal="Init-check mode - Simple existence check">
-<action>Check if {output_folder}/bmm-workflow-status.yaml exists</action>
+<action>Check if {planning_artifacts}/bmm-workflow-status.yaml exists</action>
 
 <check if="exists">
   <template-output>status_exists = true</template-output>
@@ -325,7 +325,7 @@ Your choice:</ask>
 </step>
 
 <step n="40" goal="Update mode - Centralized status file updates">
-<action>Read {output_folder}/bmm-workflow-status.yaml</action>
+<action>Read {planning_artifacts}/bmm-workflow-status.yaml</action>
 
 <check if="status file not found">
   <template-output>success = false</template-output>

src/modules/cis/workflows/design-thinking/instructions.md

@@ -1,7 +1,7 @@
 # Design Thinking Workflow Instructions
 
-<critical>The workflow execution engine is governed by: {project_root}/_bmad/core/tasks/workflow.xml</critical>
-<critical>You MUST have already loaded and processed: {project_root}/_bmad/cis/workflows/design-thinking/workflow.yaml</critical>
+<critical>The workflow execution engine is governed by: {project-root}/_bmad/core/tasks/workflow.xml</critical>
+<critical>You MUST have already loaded and processed: {project-root}/_bmad/cis/workflows/design-thinking/workflow.yaml</critical>
 <critical>Load and understand design methods from: {design_methods}</critical>
 <critical>⚠️ ABSOLUTELY NO TIME ESTIMATES - NEVER mention hours, days, weeks, months, or ANY time-based predictions. AI has fundamentally changed development speed - what once took teams weeks/months can now be done by one person in hours. DO NOT give ANY time estimates whatsoever.</critical>
 <critical>⚠️ CHECKPOINT PROTOCOL: After EVERY <template-output> tag, you MUST follow workflow.xml substep 2c: SAVE content to file immediately → SHOW checkpoint separator (━━━━━━━━━━━━━━━━━━━━━━━) → DISPLAY generated content → PRESENT options [a]Advanced Elicitation/[c]Continue/[p]Party-Mode/[y]YOLO → WAIT for user response. Never batch saves or skip checkpoints.</critical>

src/modules/cis/workflows/innovation-strategy/instructions.md

@@ -1,7 +1,7 @@
 # Innovation Strategy Workflow Instructions
 
-<critical>The workflow execution engine is governed by: {project_root}/_bmad/core/tasks/workflow.xml</critical>
-<critical>You MUST have already loaded and processed: {project_root}/_bmad/cis/workflows/innovation-strategy/workflow.yaml</critical>
+<critical>The workflow execution engine is governed by: {project-root}/_bmad/core/tasks/workflow.xml</critical>
+<critical>You MUST have already loaded and processed: {project-root}/_bmad/cis/workflows/innovation-strategy/workflow.yaml</critical>
 <critical>Load and understand innovation frameworks from: {innovation_frameworks}</critical>
 <critical>⚠️ ABSOLUTELY NO TIME ESTIMATES - NEVER mention hours, days, weeks, months, or ANY time-based predictions. AI has fundamentally changed development speed - what once took teams weeks/months can now be done by one person in hours. DO NOT give ANY time estimates whatsoever.</critical>
 <critical>⚠️ CHECKPOINT PROTOCOL: After EVERY <template-output> tag, you MUST follow workflow.xml substep 2c: SAVE content to file immediately → SHOW checkpoint separator (━━━━━━━━━━━━━━━━━━━━━━━) → DISPLAY generated content → PRESENT options [a]Advanced Elicitation/[c]Continue/[p]Party-Mode/[y]YOLO → WAIT for user response. Never batch saves or skip checkpoints.</critical>

src/modules/cis/workflows/problem-solving/instructions.md

@@ -1,7 +1,7 @@
 # Problem Solving Workflow Instructions
 
-<critical>The workflow execution engine is governed by: {project_root}/_bmad/core/tasks/workflow.xml</critical>
-<critical>You MUST have already loaded and processed: {project_root}/_bmad/cis/workflows/problem-solving/workflow.yaml</critical>
+<critical>The workflow execution engine is governed by: {project-root}/_bmad/core/tasks/workflow.xml</critical>
+<critical>You MUST have already loaded and processed: {project-root}/_bmad/cis/workflows/problem-solving/workflow.yaml</critical>
 <critical>Load and understand solving methods from: {solving_methods}</critical>
 <critical>⚠️ ABSOLUTELY NO TIME ESTIMATES - NEVER mention hours, days, weeks, months, or ANY time-based predictions. AI has fundamentally changed development speed - what once took teams weeks/months can now be done by one person in hours. DO NOT give ANY time estimates whatsoever.</critical>
 <critical>⚠️ CHECKPOINT PROTOCOL: After EVERY <template-output> tag, you MUST follow workflow.xml substep 2c: SAVE content to file immediately → SHOW checkpoint separator (━━━━━━━━━━━━━━━━━━━━━━━) → DISPLAY generated content → PRESENT options [a]Advanced Elicitation/[c]Continue/[p]Party-Mode/[y]YOLO → WAIT for user response. Never batch saves or skip checkpoints.</critical>

src/modules/cis/workflows/storytelling/instructions.md

@@ -3,8 +3,8 @@
 ## Workflow
 
 <workflow>
-<critical>The workflow execution engine is governed by: {project_root}/_bmad/core/tasks/workflow.xml</critical>
-<critical>You MUST have already loaded and processed: {project_root}/_bmad/cis/workflows/storytelling/workflow.yaml</critical>
+<critical>The workflow execution engine is governed by: {project-root}/_bmad/core/tasks/workflow.xml</critical>
+<critical>You MUST have already loaded and processed: {project-root}/_bmad/cis/workflows/storytelling/workflow.yaml</critical>
 <critical>Communicate all responses in {communication_language}</critical>
 <critical>⚠️ ABSOLUTELY NO TIME ESTIMATES - NEVER mention hours, days, weeks, months, or ANY time-based predictions. AI has fundamentally changed development speed - what once took teams weeks/months can now be done by one person in hours. DO NOT give ANY time estimates whatsoever.</critical>
 <critical>⚠️ CHECKPOINT PROTOCOL: After EVERY <template-output> tag, you MUST follow workflow.xml substep 2c: SAVE content to file immediately → SHOW checkpoint separator (━━━━━━━━━━━━━━━━━━━━━━━) → DISPLAY generated content → PRESENT options [a]Advanced Elicitation/[c]Continue/[p]Party-Mode/[y]YOLO → WAIT for user response. Never batch saves or skip checkpoints.</critical>