Compare commits

...

7 Commits

Author SHA1 Message Date
Jérôme Revillard b82becd392
Merge 4a0c59ff8b into 9debc165aa 2026-04-30 16:38:01 -04:00
jheyworth 9debc165aa
fix(installer): remove bmad-help from Copilot Custom Agents picker (#2359)
* fix(installer): remove bmad-help from Copilot Custom Agents picker

Per @BMadCode's feedback after #2324 merged: every persona agent's
activation message already advertises bmad-help, so its picker entry is
redundant AND confusing (looks like a peer agent when it's actually the
meta-help). Removes the ALWAYS_AGENT_IDS allowlist exception that put it
there.

The toml-driven filter (the mechanism BMadCode endorsed in his PR review)
remains the sole signal: a skill is a persona iff its source
customize.toml has an [agent] section. bmad-help has no customize.toml,
so under the cleaned-up filter it's correctly excluded.

Tests: replaces the inclusion assertion in Suite 17 with an exclusion
assertion. Suite still covers persona / non-conventional persona /
workflow / meta-skill-with-`-agent-`-in-name cases.

Refs #2324

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

* test: clarify Suite 17 fixture comment per PR review

The fixture creates no customize.toml at all for bmad-help, so the
exclusion path being exercised is the missing-file branch — not the
file-without-[agent]-section branch. Reword the comment accordingly.

Per @augmentcode review on #2359.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
2026-04-30 08:03:02 -05:00
Jerome Revillard 4a0c59ff8b fix(skills): update config resolution in SKILL.md files migrated from workflow.md
The 5 skills whose workflow.md was absorbed into SKILL.md by PR #2308
still had the old config.yaml loading instruction. Updated them to use
resolve_config.py like all other skills.
2026-04-29 16:02:08 +02:00
Jerome Revillard 7859186032 fix(skills): use resolve_config.py instead of reading config.yaml directly
Skills were reading _bmad/bmm|core/config.yaml directly, bypassing the
TOML merge mechanism. Now they call resolve_config.py first, with a
fallback to read the merge logic and apply it manually.
2026-04-29 16:02:08 +02:00
Jerome Revillard 834b89a841 fix: update argparse descriptions to match actual layer count 2026-04-29 16:02:08 +02:00
Jerome Revillard 294a03db3a fix(config): correct global layer priority — overrides installer defaults
The global user layer was lowest priority, meaning installer-generated
defaults in _bmad/config.user.toml always shadowed it. Reorder so
global user preferences override installer defaults but are still
overridden by hand-authored project customizations.

New order for resolve_config.py:
  base_team → base_user → global_user → custom_team → custom_user

New order for resolve_customization.py:
  defaults → global_user → team → user
2026-04-29 16:02:08 +02:00
Jerome Revillard bfd602de62 feat(config): add per-user global config layer at ~/.bmad/config/
Users working across multiple worktrees or repos no longer need to
re-enter personal settings (user_name, communication_language,
user_skill_level) in every project. A global user layer at
~/.bmad/config/config.user.toml is merged as the lowest-priority
fallback in both resolve_config.py (5-layer) and
resolve_customization.py (4-layer). Project-level overrides always
win. Missing global dir is fully backward-compatible.

Closes #2338
2026-04-29 16:02:08 +02:00
40 changed files with 417 additions and 66 deletions

View File

@ -46,7 +46,7 @@ Treat every entry in `{agent.persistent_facts}` as foundational context you carr
### Step 5: Load Config ### Step 5: Load Config
Load config from `{project-root}/_bmad/bmm/config.yaml` and resolve: Load config by running `python3 {project-root}/_bmad/scripts/resolve_config.py --project-root {project-root}` (requires Python 3.11+). If the command fails, read the merge logic in `{project-root}/_bmad/scripts/resolve_config.py` and apply it yourself to resolve the config variables. Resolve:
- Use `{user_name}` for greeting - Use `{user_name}` for greeting
- Use `{communication_language}` for all communications - Use `{communication_language}` for all communications
- Use `{document_output_language}` for output documents - Use `{document_output_language}` for output documents

View File

@ -46,7 +46,7 @@ Treat every entry in `{agent.persistent_facts}` as foundational context you carr
### Step 5: Load Config ### Step 5: Load Config
Load config from `{project-root}/_bmad/bmm/config.yaml` and resolve: Load config by running `python3 {project-root}/_bmad/scripts/resolve_config.py --project-root {project-root}` (requires Python 3.11+). If the command fails, read the merge logic in `{project-root}/_bmad/scripts/resolve_config.py` and apply it yourself to resolve the config variables. Resolve:
- Use `{user_name}` for greeting - Use `{user_name}` for greeting
- Use `{communication_language}` for all communications - Use `{communication_language}` for all communications
- Use `{document_output_language}` for output documents - Use `{document_output_language}` for output documents

View File

@ -40,7 +40,7 @@ Treat every entry in `{workflow.persistent_facts}` as foundational context you c
### Step 4: Load Config ### Step 4: Load Config
Load config from `{project-root}/_bmad/bmm/config.yaml` and resolve: Load config by running `python3 {project-root}/_bmad/scripts/resolve_config.py --project-root {project-root}` (requires Python 3.11+). If the command fails, read the merge logic in `{project-root}/_bmad/scripts/resolve_config.py` and apply it yourself to resolve the config variables. Resolve:
- Use `{user_name}` for greeting - Use `{user_name}` for greeting
- Use `{communication_language}` for all communications - Use `{communication_language}` for all communications
- Use `{document_output_language}` for output documents - Use `{document_output_language}` for output documents

View File

@ -11,7 +11,7 @@
### Configuration Loading ### Configuration Loading
Load config from `{project-root}/_bmad/bmm/config.yaml` and resolve: Load config by running `python3 {project-root}/_bmad/scripts/resolve_config.py --project-root {project-root}` (requires Python 3.11+). If the command fails, read the merge logic in `{project-root}/_bmad/scripts/resolve_config.py` and apply it yourself to resolve the config variables. Resolve:
- `project_knowledge` - `project_knowledge`
- `user_name` - `user_name`

View File

@ -10,7 +10,7 @@
### Configuration Loading ### Configuration Loading
Load config from `{project-root}/_bmad/bmm/config.yaml` and resolve: Load config by running `python3 {project-root}/_bmad/scripts/resolve_config.py --project-root {project-root}` (requires Python 3.11+). If the command fails, read the merge logic in `{project-root}/_bmad/scripts/resolve_config.py` and apply it yourself to resolve the config variables. Resolve:
- `project_knowledge` - `project_knowledge`
- `user_name` - `user_name`

View File

@ -50,7 +50,7 @@ Treat every entry in `{workflow.persistent_facts}` as foundational context you c
### Step 4: Load Config ### Step 4: Load Config
Load config from `{project-root}/_bmad/bmm/config.yaml` and resolve: Load config by running `python3 {project-root}/_bmad/scripts/resolve_config.py --project-root {project-root}` (requires Python 3.11+). If the command fails, read the merge logic in `{project-root}/_bmad/scripts/resolve_config.py` and apply it yourself to resolve the config variables. Resolve:
- Use `{user_name}` for greeting - Use `{user_name}` for greeting
- Use `{communication_language}` for all communications - Use `{communication_language}` for all communications
- Use `{document_output_language}` for output documents - Use `{document_output_language}` for output documents

View File

@ -59,7 +59,7 @@ Treat every entry in `{workflow.persistent_facts}` as foundational context you c
### Step 4: Load Config ### Step 4: Load Config
Load config from `{project-root}/_bmad/bmm/config.yaml` and resolve: Load config by running `python3 {project-root}/_bmad/scripts/resolve_config.py --project-root {project-root}` (requires Python 3.11+). If the command fails, read the merge logic in `{project-root}/_bmad/scripts/resolve_config.py` and apply it yourself to resolve the config variables. Resolve:
- Use `{user_name}` for greeting - Use `{user_name}` for greeting
- Use `{communication_language}` for all communications - Use `{communication_language}` for all communications
- Use `{document_output_language}` for output documents - Use `{document_output_language}` for output documents

View File

@ -44,7 +44,7 @@ Treat every entry in `{workflow.persistent_facts}` as foundational context you c
### Step 4: Load Config ### Step 4: Load Config
Load config from `{project-root}/_bmad/bmm/config.yaml` and resolve: Load config by running `python3 {project-root}/_bmad/scripts/resolve_config.py --project-root {project-root}` (requires Python 3.11+). If the command fails, read the merge logic in `{project-root}/_bmad/scripts/resolve_config.py` and apply it yourself to resolve the config variables. Resolve:
- Use `{user_name}` for greeting - Use `{user_name}` for greeting
- Use `{communication_language}` for all communications - Use `{communication_language}` for all communications
- Use `{document_output_language}` for output documents - Use `{document_output_language}` for output documents

View File

@ -44,7 +44,7 @@ Treat every entry in `{workflow.persistent_facts}` as foundational context you c
### Step 4: Load Config ### Step 4: Load Config
Load config from `{project-root}/_bmad/bmm/config.yaml` and resolve: Load config by running `python3 {project-root}/_bmad/scripts/resolve_config.py --project-root {project-root}` (requires Python 3.11+). If the command fails, read the merge logic in `{project-root}/_bmad/scripts/resolve_config.py` and apply it yourself to resolve the config variables. Resolve:
- Use `{user_name}` for greeting - Use `{user_name}` for greeting
- Use `{communication_language}` for all communications - Use `{communication_language}` for all communications
- Use `{document_output_language}` for output documents - Use `{document_output_language}` for output documents

View File

@ -44,7 +44,7 @@ Treat every entry in `{workflow.persistent_facts}` as foundational context you c
### Step 4: Load Config ### Step 4: Load Config
Load config from `{project-root}/_bmad/bmm/config.yaml` and resolve: Load config by running `python3 {project-root}/_bmad/scripts/resolve_config.py --project-root {project-root}` (requires Python 3.11+). If the command fails, read the merge logic in `{project-root}/_bmad/scripts/resolve_config.py` and apply it yourself to resolve the config variables. Resolve:
- Use `{user_name}` for greeting - Use `{user_name}` for greeting
- Use `{communication_language}` for all communications - Use `{communication_language}` for all communications
- Use `{document_output_language}` for output documents - Use `{document_output_language}` for output documents

View File

@ -46,7 +46,7 @@ Treat every entry in `{agent.persistent_facts}` as foundational context you carr
### Step 5: Load Config ### Step 5: Load Config
Load config from `{project-root}/_bmad/bmm/config.yaml` and resolve: Load config by running `python3 {project-root}/_bmad/scripts/resolve_config.py --project-root {project-root}` (requires Python 3.11+). If the command fails, read the merge logic in `{project-root}/_bmad/scripts/resolve_config.py` and apply it yourself to resolve the config variables. Resolve:
- Use `{user_name}` for greeting - Use `{user_name}` for greeting
- Use `{communication_language}` for all communications - Use `{communication_language}` for all communications
- Use `{document_output_language}` for output documents - Use `{document_output_language}` for output documents

View File

@ -46,7 +46,7 @@ Treat every entry in `{agent.persistent_facts}` as foundational context you carr
### Step 5: Load Config ### Step 5: Load Config
Load config from `{project-root}/_bmad/bmm/config.yaml` and resolve: Load config by running `python3 {project-root}/_bmad/scripts/resolve_config.py --project-root {project-root}` (requires Python 3.11+). If the command fails, read the merge logic in `{project-root}/_bmad/scripts/resolve_config.py` and apply it yourself to resolve the config variables. Resolve:
- Use `{user_name}` for greeting - Use `{user_name}` for greeting
- Use `{communication_language}` for all communications - Use `{communication_language}` for all communications
- Use `{document_output_language}` for output documents - Use `{document_output_language}` for output documents

View File

@ -73,7 +73,7 @@ Treat every entry in `{workflow.persistent_facts}` as foundational context you c
### Step 4: Load Config ### Step 4: Load Config
Load config from `{project-root}/_bmad/bmm/config.yaml` and resolve: Load config by running `python3 {project-root}/_bmad/scripts/resolve_config.py --project-root {project-root}` (requires Python 3.11+). If the command fails, read the merge logic in `{project-root}/_bmad/scripts/resolve_config.py` and apply it yourself to resolve the config variables. Resolve:
- Use `{user_name}` for greeting - Use `{user_name}` for greeting
- Use `{communication_language}` for all communications - Use `{communication_language}` for all communications
- Use `{document_output_language}` for output documents - Use `{document_output_language}` for output documents

View File

@ -47,7 +47,7 @@ Treat every entry in `{workflow.persistent_facts}` as foundational context you c
### Step 4: Load Config ### Step 4: Load Config
Load config from `{project-root}/_bmad/bmm/config.yaml` and resolve: Load config by running `python3 {project-root}/_bmad/scripts/resolve_config.py --project-root {project-root}` (requires Python 3.11+). If the command fails, read the merge logic in `{project-root}/_bmad/scripts/resolve_config.py` and apply it yourself to resolve the config variables. Resolve:
- Use `{user_name}` for greeting - Use `{user_name}` for greeting
- Use `{communication_language}` for all communications - Use `{communication_language}` for all communications
- Use `{document_output_language}` for output documents - Use `{document_output_language}` for output documents

View File

@ -73,7 +73,7 @@ Treat every entry in `{workflow.persistent_facts}` as foundational context you c
### Step 4: Load Config ### Step 4: Load Config
Load config from `{project-root}/_bmad/bmm/config.yaml` and resolve: Load config by running `python3 {project-root}/_bmad/scripts/resolve_config.py --project-root {project-root}` (requires Python 3.11+). If the command fails, read the merge logic in `{project-root}/_bmad/scripts/resolve_config.py` and apply it yourself to resolve the config variables. Resolve:
- Use `{user_name}` for greeting - Use `{user_name}` for greeting
- Use `{communication_language}` for all communications - Use `{communication_language}` for all communications
- Use `{document_output_language}` for output documents - Use `{document_output_language}` for output documents

View File

@ -73,7 +73,7 @@ Treat every entry in `{workflow.persistent_facts}` as foundational context you c
### Step 4: Load Config ### Step 4: Load Config
Load config from `{project-root}/_bmad/bmm/config.yaml` and resolve: Load config by running `python3 {project-root}/_bmad/scripts/resolve_config.py --project-root {project-root}` (requires Python 3.11+). If the command fails, read the merge logic in `{project-root}/_bmad/scripts/resolve_config.py` and apply it yourself to resolve the config variables. Resolve:
- Use `{user_name}` for greeting - Use `{user_name}` for greeting
- Use `{communication_language}` for all communications - Use `{communication_language}` for all communications
- Use `{document_output_language}` for output documents - Use `{document_output_language}` for output documents

View File

@ -46,7 +46,7 @@ Treat every entry in `{agent.persistent_facts}` as foundational context you carr
### Step 5: Load Config ### Step 5: Load Config
Load config from `{project-root}/_bmad/bmm/config.yaml` and resolve: Load config by running `python3 {project-root}/_bmad/scripts/resolve_config.py --project-root {project-root}` (requires Python 3.11+). If the command fails, read the merge logic in `{project-root}/_bmad/scripts/resolve_config.py` and apply it yourself to resolve the config variables. Resolve:
- Use `{user_name}` for greeting - Use `{user_name}` for greeting
- Use `{communication_language}` for all communications - Use `{communication_language}` for all communications
- Use `{document_output_language}` for output documents - Use `{document_output_language}` for output documents

View File

@ -69,7 +69,7 @@ Treat every entry in `{workflow.persistent_facts}` as foundational context you c
### Step 4: Load Config ### Step 4: Load Config
Load config from `{project-root}/_bmad/bmm/config.yaml` and resolve: Load config by running `python3 {project-root}/_bmad/scripts/resolve_config.py --project-root {project-root}` (requires Python 3.11+). If the command fails, read the merge logic in `{project-root}/_bmad/scripts/resolve_config.py` and apply it yourself to resolve the config variables. Resolve:
- Use `{user_name}` for greeting - Use `{user_name}` for greeting
- Use `{communication_language}` for all communications - Use `{communication_language}` for all communications
- Use `{document_output_language}` for output documents - Use `{document_output_language}` for output documents

View File

@ -50,7 +50,7 @@ Treat every entry in `{workflow.persistent_facts}` as foundational context you c
### Step 4: Load Config ### Step 4: Load Config
Load config from `{project-root}/_bmad/bmm/config.yaml` and resolve: Load config by running `python3 {project-root}/_bmad/scripts/resolve_config.py --project-root {project-root}` (requires Python 3.11+). If the command fails, read the merge logic in `{project-root}/_bmad/scripts/resolve_config.py` and apply it yourself to resolve the config variables. Resolve:
- Use `{user_name}` for greeting - Use `{user_name}` for greeting
- Use `{communication_language}` for all communications - Use `{communication_language}` for all communications
- Use `{document_output_language}` for output documents - Use `{document_output_language}` for output documents

View File

@ -71,7 +71,7 @@ Treat every entry in `{workflow.persistent_facts}` as foundational context you c
### Step 4: Load Config ### Step 4: Load Config
Load config from `{project-root}/_bmad/bmm/config.yaml` and resolve: Load config by running `python3 {project-root}/_bmad/scripts/resolve_config.py --project-root {project-root}` (requires Python 3.11+). If the command fails, read the merge logic in `{project-root}/_bmad/scripts/resolve_config.py` and apply it yourself to resolve the config variables. Resolve:
- Use `{user_name}` for greeting - Use `{user_name}` for greeting
- Use `{communication_language}` for all communications - Use `{communication_language}` for all communications
- Use `{document_output_language}` for output documents - Use `{document_output_language}` for output documents

View File

@ -50,7 +50,7 @@ Treat every entry in `{workflow.persistent_facts}` as foundational context you c
### Step 4: Load Config ### Step 4: Load Config
Load config from `{project-root}/_bmad/bmm/config.yaml` and resolve: Load config by running `python3 {project-root}/_bmad/scripts/resolve_config.py --project-root {project-root}` (requires Python 3.11+). If the command fails, read the merge logic in `{project-root}/_bmad/scripts/resolve_config.py` and apply it yourself to resolve the config variables. Resolve:
- Use `{user_name}` for greeting - Use `{user_name}` for greeting
- Use `{communication_language}` for all communications - Use `{communication_language}` for all communications
- Use `{document_output_language}` for output documents - Use `{document_output_language}` for output documents

View File

@ -46,7 +46,7 @@ Treat every entry in `{agent.persistent_facts}` as foundational context you carr
### Step 5: Load Config ### Step 5: Load Config
Load config from `{project-root}/_bmad/bmm/config.yaml` and resolve: Load config by running `python3 {project-root}/_bmad/scripts/resolve_config.py --project-root {project-root}` (requires Python 3.11+). If the command fails, read the merge logic in `{project-root}/_bmad/scripts/resolve_config.py` and apply it yourself to resolve the config variables. Resolve:
- Use `{user_name}` for greeting - Use `{user_name}` for greeting
- Use `{communication_language}` for all communications - Use `{communication_language}` for all communications
- Use `{document_output_language}` for output documents - Use `{document_output_language}` for output documents

View File

@ -40,7 +40,7 @@ Treat every entry in `{workflow.persistent_facts}` as foundational context you c
### Step 4: Load Config ### Step 4: Load Config
Load config from `{project-root}/_bmad/bmm/config.yaml` and resolve: Load config by running `python3 {project-root}/_bmad/scripts/resolve_config.py --project-root {project-root}` (requires Python 3.11+). If the command fails, read the merge logic in `{project-root}/_bmad/scripts/resolve_config.py` and apply it yourself to resolve the config variables. Resolve:
- `implementation_artifacts` - `implementation_artifacts`
- `planning_artifacts` - `planning_artifacts`
@ -63,6 +63,18 @@ Activation is complete. Begin the workflow below.
- **Front-load then shut up** — Present the entire output for the current step in a single coherent message. Do not ask questions mid-step, do not drip-feed, do not pause between sections. - **Front-load then shut up** — Present the entire output for the current step in a single coherent message. Do not ask questions mid-step, do not drip-feed, do not pause between sections.
- **Language** — Speak in `{communication_language}`. Write any file output in `{document_output_language}`. - **Language** — Speak in `{communication_language}`. Write any file output in `{document_output_language}`.
<<<<<<< HEAD
=======
## INITIALIZATION
Load config by running `python3 {project-root}/_bmad/scripts/resolve_config.py --project-root {project-root}` (requires Python 3.11+). If the command fails, read the merge logic in `{project-root}/_bmad/scripts/resolve_config.py` and apply it yourself to resolve the config variables. Resolve:
- `implementation_artifacts`
- `planning_artifacts`
- `communication_language`
- `document_output_language`
>>>>>>> 3846e184 (fix(skills): use resolve_config.py instead of reading config.yaml directly)
## FIRST STEP ## FIRST STEP
Read fully and follow `./step-01-orientation.md` to begin. Read fully and follow `./step-01-orientation.md` to begin.

View File

@ -40,7 +40,7 @@ Treat every entry in `{workflow.persistent_facts}` as foundational context you c
### Step 4: Load Config ### Step 4: Load Config
Load config from `{project-root}/_bmad/bmm/config.yaml` and resolve: Load config by running `python3 {project-root}/_bmad/scripts/resolve_config.py --project-root {project-root}` (requires Python 3.11+). If the command fails, read the merge logic in `{project-root}/_bmad/scripts/resolve_config.py` and apply it yourself to resolve the config variables. Resolve:
- `project_name`, `planning_artifacts`, `implementation_artifacts`, `user_name` - `project_name`, `planning_artifacts`, `implementation_artifacts`, `user_name`
- `communication_language`, `document_output_language`, `user_skill_level` - `communication_language`, `document_output_language`, `user_skill_level`

View File

@ -40,7 +40,7 @@ Treat every entry in `{workflow.persistent_facts}` as foundational context you c
### Step 4: Load Config ### Step 4: Load Config
Load config from `{project-root}/_bmad/bmm/config.yaml` and resolve: Load config by running `python3 {project-root}/_bmad/scripts/resolve_config.py --project-root {project-root}` (requires Python 3.11+). If the command fails, read the merge logic in `{project-root}/_bmad/scripts/resolve_config.py` and apply it yourself to resolve the config variables. Resolve:
- `project_name`, `user_name` - `project_name`, `user_name`
- `communication_language`, `document_output_language` - `communication_language`, `document_output_language`

View File

@ -47,7 +47,7 @@ Treat every entry in `{workflow.persistent_facts}` as foundational context you c
### Step 4: Load Config ### Step 4: Load Config
Load config from `{project-root}/_bmad/bmm/config.yaml` and resolve: Load config by running `python3 {project-root}/_bmad/scripts/resolve_config.py --project-root {project-root}` (requires Python 3.11+). If the command fails, read the merge logic in `{project-root}/_bmad/scripts/resolve_config.py` and apply it yourself to resolve the config variables. Resolve:
- `project_name`, `user_name` - `project_name`, `user_name`
- `communication_language`, `document_output_language` - `communication_language`, `document_output_language`

View File

@ -47,7 +47,7 @@ Treat every entry in `{workflow.persistent_facts}` as foundational context you c
### Step 4: Load Config ### Step 4: Load Config
Load config from `{project-root}/_bmad/bmm/config.yaml` and resolve: Load config by running `python3 {project-root}/_bmad/scripts/resolve_config.py --project-root {project-root}` (requires Python 3.11+). If the command fails, read the merge logic in `{project-root}/_bmad/scripts/resolve_config.py` and apply it yourself to resolve the config variables. Resolve:
- `project_name`, `user_name` - `project_name`, `user_name`
- `communication_language`, `document_output_language` - `communication_language`, `document_output_language`

View File

@ -40,7 +40,7 @@ Treat every entry in `{workflow.persistent_facts}` as foundational context you c
### Step 4: Load Config ### Step 4: Load Config
Load config from `{project-root}/_bmad/bmm/config.yaml` and resolve: Load config by running `python3 {project-root}/_bmad/scripts/resolve_config.py --project-root {project-root}` (requires Python 3.11+). If the command fails, read the merge logic in `{project-root}/_bmad/scripts/resolve_config.py` and apply it yourself to resolve the config variables. Resolve:
- `project_name`, `user_name` - `project_name`, `user_name`
- `communication_language`, `document_output_language` - `communication_language`, `document_output_language`

View File

@ -59,7 +59,7 @@ Treat every entry in `{workflow.persistent_facts}` as foundational context you c
### Step 4: Load Config ### Step 4: Load Config
Load config from `{project-root}/_bmad/bmm/config.yaml` and resolve: Load config by running `python3 {project-root}/_bmad/scripts/resolve_config.py --project-root {project-root}` (requires Python 3.11+). If the command fails, read the merge logic in `{project-root}/_bmad/scripts/resolve_config.py` and apply it yourself to resolve the config variables. Resolve:
- `project_name`, `planning_artifacts`, `implementation_artifacts`, `user_name` - `project_name`, `planning_artifacts`, `implementation_artifacts`, `user_name`
- `communication_language`, `document_output_language`, `user_skill_level` - `communication_language`, `document_output_language`, `user_skill_level`

View File

@ -56,7 +56,7 @@ Treat every entry in `{workflow.persistent_facts}` as foundational context you c
### Step 4: Load Config ### Step 4: Load Config
Load config from `{project-root}/_bmad/bmm/config.yaml` and resolve: Load config by running `python3 {project-root}/_bmad/scripts/resolve_config.py --project-root {project-root}` (requires Python 3.11+). If the command fails, read the merge logic in `{project-root}/_bmad/scripts/resolve_config.py` and apply it yourself to resolve the config variables. Resolve:
- `project_name`, `user_name` - `project_name`, `user_name`
- `communication_language`, `document_output_language` - `communication_language`, `document_output_language`

View File

@ -40,7 +40,7 @@ Treat every entry in `{workflow.persistent_facts}` as foundational context you c
### Step 4: Load Config ### Step 4: Load Config
Load config from `{project-root}/_bmad/bmm/config.yaml` and resolve: Load config by running `python3 {project-root}/_bmad/scripts/resolve_config.py --project-root {project-root}` (requires Python 3.11+). If the command fails, read the merge logic in `{project-root}/_bmad/scripts/resolve_config.py` and apply it yourself to resolve the config variables. Resolve:
- `project_name`, `user_name` - `project_name`, `user_name`
- `communication_language`, `document_output_language` - `communication_language`, `document_output_language`

View File

@ -40,7 +40,7 @@ Treat every entry in `{workflow.persistent_facts}` as foundational context you c
### Step 4: Load Config ### Step 4: Load Config
Load config from `{project-root}/_bmad/bmm/config.yaml` and resolve: Load config by running `python3 {project-root}/_bmad/scripts/resolve_config.py --project-root {project-root}` (requires Python 3.11+). If the command fails, read the merge logic in `{project-root}/_bmad/scripts/resolve_config.py` and apply it yourself to resolve the config variables. Resolve:
- `project_name`, `user_name` - `project_name`, `user_name`
- `communication_language`, `document_output_language` - `communication_language`, `document_output_language`

View File

@ -32,7 +32,7 @@ This uses **micro-file architecture** for disciplined execution:
### Configuration Loading ### Configuration Loading
Load config from `{project-root}/_bmad/core/config.yaml` and resolve: Load config by running `python3 {project-root}/_bmad/scripts/resolve_config.py --project-root {project-root}` (requires Python 3.11+). If the command fails, read the merge logic in `{project-root}/_bmad/scripts/resolve_config.py` and apply it yourself to resolve the config variables. Resolve:
- `project_name`, `output_folder`, `user_name` - `project_name`, `output_folder`, `user_name`
- `communication_language`, `document_output_language`, `user_skill_level` - `communication_language`, `document_output_language`, `user_skill_level`

View File

@ -23,7 +23,7 @@ When this skill completes, the user should:
## Data Sources ## Data Sources
- **Catalog**: `{project-root}/_bmad/_config/bmad-help.csv` — assembled manifest of all installed module skills - **Catalog**: `{project-root}/_bmad/_config/bmad-help.csv` — assembled manifest of all installed module skills
- **Config**: `config.yaml` and `user-config.yaml` files in `{project-root}/_bmad/` and its subfolders — resolve `output-location` variables, provide `communication_language` and `project_knowledge` - **Config**: Run `python3 {project-root}/_bmad/scripts/resolve_config.py --project-root {project-root}` to get merged config. If that fails, read the merge logic in `{project-root}/_bmad/scripts/resolve_config.py` and apply it yourself — resolve `output-location` variables, provide `communication_language` and `project_knowledge`
- **Artifacts**: Files matching `outputs` patterns at resolved `output-location` paths reveal which steps are possibly completed; their content may also provide grounding context for recommendations - **Artifacts**: Files matching `outputs` patterns at resolved `output-location` paths reveal which steps are possibly completed; their content may also provide grounding context for recommendations
- **Project knowledge**: If `project_knowledge` resolves to an existing path, read it for grounding context. Never fabricate project-specific details. - **Project knowledge**: If `project_knowledge` resolves to an existing path, read it for grounding context. Never fabricate project-specific details.
- **Module docs**: Rows with `_meta` in the `skill` column carry a URL or path in `output-location` pointing to the module's documentation (e.g., llms.txt). Fetch and use these to answer general questions about that module. - **Module docs**: Rows with `_meta` in the `skill` column carry a URL or path in `output-location` pointing to the module's documentation (e.g., llms.txt). Fetch and use these to answer general questions about that module.

View File

@ -22,7 +22,7 @@ Party mode accepts optional arguments when invoked:
1. **Parse arguments** — check for `--model` and `--solo` flags from the user's invocation. 1. **Parse arguments** — check for `--model` and `--solo` flags from the user's invocation.
2. Load config from `{project-root}/_bmad/core/config.yaml` and resolve: 2. Load config by running `python3 {project-root}/_bmad/scripts/resolve_config.py --project-root {project-root}` (requires Python 3.11+). If the command fails, read the merge logic in `{project-root}/_bmad/scripts/resolve_config.py` and apply it yourself to resolve the config variables. Resolve:
- Use `{user_name}` for greeting - Use `{user_name}` for greeting
- Use `{communication_language}` for all communications - Use `{communication_language}` for all communications

View File

@ -1,12 +1,13 @@
#!/usr/bin/env python3 #!/usr/bin/env python3
""" """
Resolve BMad's central config using four-layer TOML merge. Resolve BMad's central config using five-layer TOML merge.
Reads from four layers (highest priority last): Reads from five layers (highest priority last):
1. {project-root}/_bmad/config.toml (installer-owned team) 1. {project-root}/_bmad/config.toml (installer-owned team)
2. {project-root}/_bmad/config.user.toml (installer-owned user) 2. {project-root}/_bmad/config.user.toml (installer-owned user)
3. {project-root}/_bmad/custom/config.toml (human-authored team, committed) 3. ~/.bmad/config/config.user.toml (global user preferences)
4. {project-root}/_bmad/custom/config.user.toml (human-authored user, gitignored) 4. {project-root}/_bmad/custom/config.toml (human-authored team, committed)
5. {project-root}/_bmad/custom/config.user.toml (human-authored user, gitignored)
Outputs merged JSON to stdout. Errors go to stderr. Outputs merged JSON to stdout. Errors go to stderr.
@ -40,6 +41,7 @@ except ImportError:
_MISSING = object() _MISSING = object()
_KEYED_MERGE_FIELDS = ("code", "id") _KEYED_MERGE_FIELDS = ("code", "id")
GLOBAL_DIR = Path.home() / ".bmad" / "config"
def load_toml(file_path: Path, required: bool = False) -> dict: def load_toml(file_path: Path, required: bool = False) -> dict:
@ -136,7 +138,7 @@ def extract_key(data, dotted_key: str):
def main(): def main():
parser = argparse.ArgumentParser( parser = argparse.ArgumentParser(
description="Resolve BMad central config using four-layer TOML merge.", description="Resolve BMad central config using five-layer TOML merge.",
) )
parser.add_argument( parser.add_argument(
"--project-root", "-p", required=True, "--project-root", "-p", required=True,
@ -153,10 +155,12 @@ def main():
base_team = load_toml(bmad_dir / "config.toml", required=True) base_team = load_toml(bmad_dir / "config.toml", required=True)
base_user = load_toml(bmad_dir / "config.user.toml") base_user = load_toml(bmad_dir / "config.user.toml")
global_user = load_toml(GLOBAL_DIR / "config.user.toml")
custom_team = load_toml(bmad_dir / "custom" / "config.toml") custom_team = load_toml(bmad_dir / "custom" / "config.toml")
custom_user = load_toml(bmad_dir / "custom" / "config.user.toml") custom_user = load_toml(bmad_dir / "custom" / "config.user.toml")
merged = deep_merge(base_team, base_user) merged = deep_merge(base_team, base_user)
merged = deep_merge(merged, global_user)
merged = deep_merge(merged, custom_team) merged = deep_merge(merged, custom_team)
merged = deep_merge(merged, custom_user) merged = deep_merge(merged, custom_user)

View File

@ -1,11 +1,12 @@
#!/usr/bin/env python3 #!/usr/bin/env python3
""" """
Resolve customization for a BMad skill using three-layer TOML merge. Resolve customization for a BMad skill using four-layer TOML merge.
Reads customization from three layers (highest priority first): Reads customization from four layers (highest priority first):
1. {project-root}/_bmad/custom/{name}.user.toml (personal, gitignored) 1. {project-root}/_bmad/custom/{name}.user.toml (personal, gitignored)
2. {project-root}/_bmad/custom/{name}.toml (team/org, committed) 2. {project-root}/_bmad/custom/{name}.toml (team/org, committed)
3. {skill-root}/customize.toml (skill defaults) 3. ~/.bmad/config/{name}.user.toml (global user preferences)
4. {skill-root}/customize.toml (skill defaults)
Skill name is derived from the basename of the skill directory. Skill name is derived from the basename of the skill directory.
@ -51,6 +52,7 @@ except ImportError:
_MISSING = object() _MISSING = object()
_KEYED_MERGE_FIELDS = ("code", "id") _KEYED_MERGE_FIELDS = ("code", "id")
GLOBAL_DIR = Path.home() / ".bmad" / "config"
def find_project_root(start: Path): def find_project_root(start: Path):
@ -179,7 +181,7 @@ def extract_key(data, dotted_key: str):
def main(): def main():
parser = argparse.ArgumentParser( parser = argparse.ArgumentParser(
description="Resolve customization for a BMad skill using three-layer TOML merge.", description="Resolve customization for a BMad skill using four-layer TOML merge.",
add_help=True, add_help=True,
) )
parser.add_argument( parser.add_argument(
@ -211,7 +213,10 @@ def main():
team = load_toml(custom_dir / f"{skill_name}.toml") team = load_toml(custom_dir / f"{skill_name}.toml")
user = load_toml(custom_dir / f"{skill_name}.user.toml") user = load_toml(custom_dir / f"{skill_name}.user.toml")
merged = deep_merge(defaults, team) global_user = load_toml(GLOBAL_DIR / f"{skill_name}.user.toml")
merged = deep_merge(defaults, global_user)
merged = deep_merge(merged, team)
merged = deep_merge(merged, user) merged = deep_merge(merged, user)
if args.key: if args.key:

View File

@ -0,0 +1,341 @@
/**
* Config Resolution Tests
*
* Tests the Python config resolution scripts by invoking them as subprocesses
* with temporary TOML fixtures. Validates:
* - Global user layer is loaded and merged with correct priority
* - Project layers override global layers
* - Missing global dir doesn't break anything (backward compat)
* - resolve_customization.py global skill layer
*
* Usage: node test/test-config-resolution.js
*/
const path = require('node:path');
const os = require('node:os');
const fs = require('node:fs/promises');
const { execSync } = require('node:child_process');
const SCRIPTS_DIR = path.resolve(__dirname, '..', 'src', 'scripts');
const colors = {
reset: '',
green: '',
red: '',
dim: '',
};
let passed = 0;
let failed = 0;
function assert(condition, testName, errorMessage = '') {
if (condition) {
console.log(`${colors.green}${colors.reset} ${testName}`);
passed++;
} else {
console.log(`${colors.red}${colors.reset} ${testName}`);
if (errorMessage) {
console.log(` ${colors.dim}${errorMessage}${colors.reset}`);
}
failed++;
}
}
function writeToml(filePath, data) {
const lines = [];
for (const [key, val] of Object.entries(data)) {
if (typeof val === 'string') {
lines.push(`${key} = "${val}"`);
} else if (typeof val === 'number' || typeof val === 'boolean') {
lines.push(`${key} = ${val}`);
}
}
return fs.writeFile(filePath, lines.join('\n') + '\n');
}
async function withTempDir(fn) {
const dir = await fs.mkdtemp(path.join(os.tmpdir(), 'bmad-config-test-'));
try {
return await fn(dir);
} finally {
await fs.rm(dir, { recursive: true, force: true });
}
}
async function testResolveConfig() {
console.log('\n--- resolve_config.py ---\n');
// Test 1: global user overrides installer defaults
await withTempDir(async (tmpDir) => {
const globalDir = path.join(tmpDir, '.bmad', 'config');
await fs.mkdir(globalDir, { recursive: true });
await writeToml(path.join(globalDir, 'config.user.toml'), {
user_name: 'GlobalAlice',
communication_language: 'en',
});
const projectDir = path.join(tmpDir, 'project');
const bmadDir = path.join(projectDir, '_bmad');
await fs.mkdir(path.join(bmadDir, 'custom'), { recursive: true });
await writeToml(path.join(bmadDir, 'config.toml'), {
project_name: 'TestProject',
user_name: 'InstallerDefault',
});
await writeToml(path.join(bmadDir, 'config.user.toml'), {
user_name: 'InstallerUserDefault',
});
const origHome = process.env.HOME;
process.env.HOME = tmpDir;
try {
const result = JSON.parse(execSync(`python3 ${SCRIPTS_DIR}/resolve_config.py --project-root ${projectDir}`, { encoding: 'utf-8' }));
assert(
result.user_name === 'GlobalAlice',
'global user overrides installer defaults',
`Expected "GlobalAlice", got "${result.user_name}"`,
);
assert(
result.communication_language === 'en',
'global communication_language preserved when installer has no override',
`Expected "en", got "${result.communication_language}"`,
);
assert(
result.project_name === 'TestProject',
'installer team config values preserved',
`Expected "TestProject", got "${result.project_name}"`,
);
} finally {
process.env.HOME = origHome;
}
});
// Test 2: missing global dir — backward compat
await withTempDir(async (tmpDir) => {
const projectDir = path.join(tmpDir, 'project');
const bmadDir = path.join(projectDir, '_bmad');
await fs.mkdir(path.join(bmadDir, 'custom'), { recursive: true });
await writeToml(path.join(bmadDir, 'config.toml'), {
project_name: 'NoGlobalProject',
});
const origHome = process.env.HOME;
process.env.HOME = tmpDir;
try {
const result = JSON.parse(execSync(`python3 ${SCRIPTS_DIR}/resolve_config.py --project-root ${projectDir}`, { encoding: 'utf-8' }));
assert(
result.project_name === 'NoGlobalProject',
'works fine without global config dir',
`Expected "NoGlobalProject", got "${result.project_name}"`,
);
} finally {
process.env.HOME = origHome;
}
});
// Test 3: full priority chain — base_team < base_user < global < custom_team < custom_user
await withTempDir(async (tmpDir) => {
const globalDir = path.join(tmpDir, '.bmad', 'config');
await fs.mkdir(globalDir, { recursive: true });
await writeToml(path.join(globalDir, 'config.user.toml'), {
user_name: 'L2-Global',
});
const projectDir = path.join(tmpDir, 'project');
const bmadDir = path.join(projectDir, '_bmad');
await fs.mkdir(path.join(bmadDir, 'custom'), { recursive: true });
await writeToml(path.join(bmadDir, 'config.toml'), { user_name: 'L0-BaseTeam' });
await writeToml(path.join(bmadDir, 'config.user.toml'), { user_name: 'L1-BaseUser' });
await writeToml(path.join(bmadDir, 'custom', 'config.toml'), { user_name: 'L3-CustomTeam' });
await writeToml(path.join(bmadDir, 'custom', 'config.user.toml'), { user_name: 'L4-CustomUser' });
const origHome = process.env.HOME;
process.env.HOME = tmpDir;
try {
const result = JSON.parse(execSync(`python3 ${SCRIPTS_DIR}/resolve_config.py --project-root ${projectDir}`, { encoding: 'utf-8' }));
assert(
result.user_name === 'L4-CustomUser',
'highest priority layer (custom user) wins',
`Expected "L4-CustomUser", got "${result.user_name}"`,
);
} finally {
process.env.HOME = origHome;
}
});
// Test 4: --key flag works with global layer
await withTempDir(async (tmpDir) => {
const globalDir = path.join(tmpDir, '.bmad', 'config');
await fs.mkdir(globalDir, { recursive: true });
await writeToml(path.join(globalDir, 'config.user.toml'), {
user_name: 'KeyTestGlobal',
communication_language: 'fr',
});
const projectDir = path.join(tmpDir, 'project');
const bmadDir = path.join(projectDir, '_bmad');
await fs.mkdir(path.join(bmadDir, 'custom'), { recursive: true });
await writeToml(path.join(bmadDir, 'config.toml'), {
project_name: 'KeyTestProject',
});
const origHome = process.env.HOME;
process.env.HOME = tmpDir;
try {
const result = JSON.parse(
execSync(`python3 ${SCRIPTS_DIR}/resolve_config.py --project-root ${projectDir} --key user_name --key communication_language`, {
encoding: 'utf-8',
}),
);
assert(
Object.keys(result).length === 2,
'--key returns only requested keys',
`Expected 2 keys, got ${Object.keys(result).length}: ${JSON.stringify(Object.keys(result))}`,
);
assert(
result.user_name === 'KeyTestGlobal',
'--key user_name returns global value',
`Expected "KeyTestGlobal", got "${result.user_name}"`,
);
assert(
result.communication_language === 'fr',
'--key communication_language returns global value',
`Expected "fr", got "${result.communication_language}"`,
);
} finally {
process.env.HOME = origHome;
}
});
}
async function testResolveCustomization() {
console.log('\n--- resolve_customization.py ---\n');
// Test 1: global skill user overrides skill defaults
await withTempDir(async (tmpDir) => {
const globalDir = path.join(tmpDir, '.bmad', 'config');
await fs.mkdir(globalDir, { recursive: true });
await writeToml(path.join(globalDir, 'test-skill.user.toml'), {
agent: 'global-agent-prompt',
});
const skillDir = path.join(tmpDir, 'skill', 'test-skill');
await fs.mkdir(skillDir, { recursive: true });
await writeToml(path.join(skillDir, 'customize.toml'), {
agent: 'default-agent-prompt',
version: '1.0.0',
});
const origHome = process.env.HOME;
process.env.HOME = tmpDir;
try {
const result = JSON.parse(execSync(`python3 ${SCRIPTS_DIR}/resolve_customization.py --skill ${skillDir}`, { encoding: 'utf-8' }));
assert(
result.agent === 'global-agent-prompt',
'global user overrides skill defaults',
`Expected "global-agent-prompt", got "${result.agent}"`,
);
assert(result.version === '1.0.0', 'skill default values preserved', `Expected "1.0.0", got "${result.version}"`);
} finally {
process.env.HOME = origHome;
}
});
// Test 2: global skill layer provides value not in defaults
await withTempDir(async (tmpDir) => {
const globalDir = path.join(tmpDir, '.bmad', 'config');
await fs.mkdir(globalDir, { recursive: true });
await writeToml(path.join(globalDir, 'test-skill.user.toml'), {
extra_global_key: 'from-global',
});
const skillDir = path.join(tmpDir, 'skill', 'test-skill');
await fs.mkdir(skillDir, { recursive: true });
await writeToml(path.join(skillDir, 'customize.toml'), {
version: '2.0.0',
});
const origHome = process.env.HOME;
process.env.HOME = tmpDir;
try {
const result = JSON.parse(execSync(`python3 ${SCRIPTS_DIR}/resolve_customization.py --skill ${skillDir}`, { encoding: 'utf-8' }));
assert(
result.extra_global_key === 'from-global',
'global key not in defaults is preserved',
`Expected "from-global", got "${result.extra_global_key}"`,
);
assert(result.version === '2.0.0', 'skill defaults still present', `Expected "2.0.0", got "${result.version}"`);
} finally {
process.env.HOME = origHome;
}
});
// Test 3: missing global dir — backward compat
await withTempDir(async (tmpDir) => {
const skillDir = path.join(tmpDir, 'skill', 'test-skill');
await fs.mkdir(skillDir, { recursive: true });
await writeToml(path.join(skillDir, 'customize.toml'), {
version: '3.0.0',
});
const origHome = process.env.HOME;
process.env.HOME = tmpDir;
try {
const result = JSON.parse(execSync(`python3 ${SCRIPTS_DIR}/resolve_customization.py --skill ${skillDir}`, { encoding: 'utf-8' }));
assert(result.version === '3.0.0', 'works without global config dir', `Expected "3.0.0", got "${result.version}"`);
} finally {
process.env.HOME = origHome;
}
});
// Test 4: full priority chain — defaults < global < team < user
await withTempDir(async (tmpDir) => {
const globalDir = path.join(tmpDir, '.bmad', 'config');
await fs.mkdir(globalDir, { recursive: true });
await writeToml(path.join(globalDir, 'test-skill.user.toml'), {
agent: 'L1-Global',
});
const skillDir = path.join(tmpDir, 'project', '_bmad', 'skills', 'test-skill');
await fs.mkdir(skillDir, { recursive: true });
await writeToml(path.join(skillDir, 'customize.toml'), { agent: 'L0-Defaults' });
const customDir = path.join(tmpDir, 'project', '_bmad', 'custom');
await fs.mkdir(customDir, { recursive: true });
await writeToml(path.join(customDir, 'test-skill.toml'), { agent: 'L2-Team' });
await writeToml(path.join(customDir, 'test-skill.user.toml'), { agent: 'L3-User' });
const origHome = process.env.HOME;
process.env.HOME = tmpDir;
try {
const result = JSON.parse(execSync(`python3 ${SCRIPTS_DIR}/resolve_customization.py --skill ${skillDir}`, { encoding: 'utf-8' }));
assert(result.agent === 'L3-User', 'highest priority layer (project user) wins', `Expected "L3-User", got "${result.agent}"`);
} finally {
process.env.HOME = origHome;
}
});
}
async function main() {
console.log('Config Resolution Tests\n');
try {
await testResolveConfig();
await testResolveCustomization();
} catch (error) {
console.error(`${colors.red}Fatal error: ${error.message}${colors.reset}`);
process.exit(1);
}
console.log(`\n${colors.green}${passed} passed${colors.reset}, ${colors.red}${failed} failed${colors.reset}`);
process.exit(failed > 0 ? 1 : 0);
}
main();

View File

@ -585,9 +585,9 @@ async function runTests() {
// persona — has customize.toml with [workflow] → EXCLUDED // persona — has customize.toml with [workflow] → EXCLUDED
// (mirrors `bmad-agent-builder` in the real manifest) // (mirrors `bmad-agent-builder` in the real manifest)
// 4. Workflow skill — no customize.toml at all → EXCLUDED // 4. Workflow skill — no customize.toml at all → EXCLUDED
// 5. `bmad-help` — structural exception via ALWAYS_AGENT_IDS; // 5. `bmad-help` — meta-help skill with no customize.toml;
// has no customize.toml of its own but surfaces in the // every persona agent's activation already advertises it,
// agents picker because it's the meta-help skill → INCLUDED // so it's correctly excluded from the picker as redundant → EXCLUDED
const fixtureCsvPath17 = path.join(installedBmadDir17, '_config', 'skill-manifest.csv'); const fixtureCsvPath17 = path.join(installedBmadDir17, '_config', 'skill-manifest.csv');
await fs.writeFile( await fs.writeFile(
fixtureCsvPath17, fixtureCsvPath17,
@ -597,7 +597,7 @@ async function runTests() {
'"bmad-agent-fixture","bmad-agent-fixture","Persona agent — customize.toml has [agent], SHOULD appear","core","_bmad/core/bmad-agent-fixture/SKILL.md"', '"bmad-agent-fixture","bmad-agent-fixture","Persona agent — customize.toml has [agent], SHOULD appear","core","_bmad/core/bmad-agent-fixture/SKILL.md"',
'"bmad-tea","bmad-tea","Non-conventional id but [agent] in customize.toml — SHOULD appear","core","_bmad/core/bmad-tea/SKILL.md"', '"bmad-tea","bmad-tea","Non-conventional id but [agent] in customize.toml — SHOULD appear","core","_bmad/core/bmad-tea/SKILL.md"',
'"bmad-agent-builder","bmad-agent-builder","Skill-builder workflow — id contains -agent- but customize.toml has [workflow] — should NOT appear","core","_bmad/core/bmad-agent-builder/SKILL.md"', '"bmad-agent-builder","bmad-agent-builder","Skill-builder workflow — id contains -agent- but customize.toml has [workflow] — should NOT appear","core","_bmad/core/bmad-agent-builder/SKILL.md"',
'"bmad-help","bmad-help","Meta-help skill — no customize.toml but ALWAYS_AGENT_IDS exception; SHOULD appear in agents picker","core","_bmad/core/bmad-help/SKILL.md"', '"bmad-help","bmad-help","Meta-help skill — no customize.toml; SHOULD NOT appear in agents picker (toml-driven filter)","core","_bmad/core/bmad-help/SKILL.md"',
'', '',
].join('\n'), ].join('\n'),
); );
@ -615,9 +615,9 @@ async function runTests() {
['---', `name: ${id}`, `description: fixture for ${id}`, '---', '', `Body of ${id}.`].join('\n'), ['---', `name: ${id}`, `description: fixture for ${id}`, '---', '', `Body of ${id}.`].join('\n'),
); );
} }
// Note: bmad-help intentionally has NO customize.toml — it's the // Note: bmad-help intentionally has NO customize.toml — it exercises
// structural exception for which the ALWAYS_AGENT_IDS allowlist // the toml-driven filter's exclusion path (a skill with no
// exists. // customize.toml is correctly kept out of the Copilot agents picker).
// [agent] customize.toml for the two persona fixtures. // [agent] customize.toml for the two persona fixtures.
await fs.writeFile( await fs.writeFile(
path.join(installedBmadDir17, 'core', 'bmad-agent-fixture', 'customize.toml'), path.join(installedBmadDir17, 'core', 'bmad-agent-fixture', 'customize.toml'),
@ -688,8 +688,8 @@ async function runTests() {
assert(await fs.pathExists(agentFileForTea17), 'Non-conventional id with [agent] in customize.toml is included (no allowlist needed)'); assert(await fs.pathExists(agentFileForTea17), 'Non-conventional id with [agent] in customize.toml is included (no allowlist needed)');
assert(!(await fs.pathExists(agentFileForWorkflow17)), 'Workflow skill (no customize.toml) is FILTERED OUT of .github/agents/'); assert(!(await fs.pathExists(agentFileForWorkflow17)), 'Workflow skill (no customize.toml) is FILTERED OUT of .github/agents/');
assert( assert(
await fs.pathExists(agentFileForBmadHelp17), !(await fs.pathExists(agentFileForBmadHelp17)),
'bmad-help is INCLUDED in agents picker via ALWAYS_AGENT_IDS exception (structural meta-skill, no customize.toml)', 'bmad-help is excluded from Copilot agents picker (no customize.toml; allowlist removed per maintainer feedback)',
); );
assert( assert(
!(await fs.pathExists(agentFileForMetaSkill17)), !(await fs.pathExists(agentFileForMetaSkill17)),

View File

@ -57,15 +57,6 @@ function isSafeCanonicalId(value) {
// OpenCode's native `@skills/<id>` skill-reference syntax. // OpenCode's native `@skills/<id>` skill-reference syntax.
const DEFAULT_COMMANDS_BODY_TEMPLATE = '@skills/{canonicalId}'; const DEFAULT_COMMANDS_BODY_TEMPLATE = '@skills/{canonicalId}';
// `bmad-help` is the structural meta-skill across BMAD: the orientation
// helper that points users at every other skill. It is invoked
// persona-style ("ask the helper") even though it has no [agent]
// customize.toml of its own (it isn't a configurable persona). Surfacing
// it in agents-picker contexts mirrors how users actually reach for it,
// and the inclusion is unique and stable — there is no second meta-help
// skill to encourage growth of this exception.
const ALWAYS_AGENT_IDS = new Set(['bmad-help']);
// Is this skill a persona agent (vs. a workflow/tool/standalone skill)? // Is this skill a persona agent (vs. a workflow/tool/standalone skill)?
// Used by platforms that surface only persona agents (e.g. Copilot's Custom // Used by platforms that surface only persona agents (e.g. Copilot's Custom
// Agents picker). Signal: the skill's source `customize.toml` has an // Agents picker). Signal: the skill's source `customize.toml` has an
@ -77,15 +68,13 @@ const ALWAYS_AGENT_IDS = new Set(['bmad-help']);
// GDS, WDS, TEA, and correctly excludes meta-skills like // GDS, WDS, TEA, and correctly excludes meta-skills like
// `bmad-agent-builder` (a skill-builder workflow whose canonical id // `bmad-agent-builder` (a skill-builder workflow whose canonical id
// contains `-agent-` but which has no [agent] section because it isn't a // contains `-agent-` but which has no [agent] section because it isn't a
// persona itself). Plus the explicit `ALWAYS_AGENT_IDS` set for the one // persona itself).
// structural exception (`bmad-help`).
// //
// Reading the source toml — at install time the source skill directory // Reading the source toml — at install time the source skill directory
// (resolved from manifest record.path) still exists; cleanup runs later // (resolved from manifest record.path) still exists; cleanup runs later
// in the install flow. // in the install flow.
async function isAgentSkill(record, bmadDir) { async function isAgentSkill(record, bmadDir) {
if (!record?.path || !bmadDir) return false; if (!record?.path || !bmadDir) return false;
if (record.canonicalId && ALWAYS_AGENT_IDS.has(record.canonicalId)) return true;
const bmadFolderName = path.basename(bmadDir); const bmadFolderName = path.basename(bmadDir);
const bmadPrefix = bmadFolderName + '/'; const bmadPrefix = bmadFolderName + '/';
const relativePath = record.path.startsWith(bmadPrefix) ? record.path.slice(bmadPrefix.length) : record.path; const relativePath = record.path.startsWith(bmadPrefix) ? record.path.slice(bmadPrefix.length) : record.path;