Compare commits
5 Commits
3966711d2f
...
0e3e745f0c
| Author | SHA1 | Date |
|---|---|---|
|
|
0e3e745f0c | |
|
|
397b2a5c87 | |
|
|
b161491ca8 | |
|
|
98f8786060 | |
|
|
229c1c57f9 |
|
|
@ -34,7 +34,7 @@ Launch three subagents without conversation context. If no sub-agents are availa
|
|||
1. Deduplicate all review findings.
|
||||
2. Classify each finding. The first three categories are **this story's problem** — caused or exposed by the current change. The last two are **not this story's problem**.
|
||||
- **intent_gap** — caused by the change; cannot be resolved from the spec because the captured intent is incomplete. Do not infer intent unless there is exactly one possible reading.
|
||||
- **bad_spec** — caused by the change, including direct deviations from spec. The spec should have been clear enough to prevent it. When in doubt between bad_spec and patch, prefer bad_spec — a spec-level fix is more likely to produce coherent code.
|
||||
- **bad_spec** — caused by the change, including direct deviations from spec. The spec should have been clear enough to prevent it. When in doubt between bad_spec and patch, prefer bad_spec — a spec-level fix is more likely to produce coherent code. Also applies when the story's domain includes data silently dropped or never reaching its destination — the change exposed it.
|
||||
- **patch** — caused by the change; trivially fixable without human input. Just part of the diff.
|
||||
- **defer** — pre-existing issue not caused by this story, surfaced incidentally by the review. Collect for later focused attention.
|
||||
- **reject** — noise. Drop silently. When unsure between defer and reject, prefer reject — only defer findings you are confident are real.
|
||||
|
|
|
|||
|
|
@ -446,6 +446,41 @@ async function runTests() {
|
|||
|
||||
// Test 12: Removed — ancestor conflict check no longer applies (no IDE inherits skills from parent dirs)
|
||||
|
||||
// ============================================================
|
||||
// Test 12b: CodeWhale Native Skills Install
|
||||
// ============================================================
|
||||
console.log(`${colors.yellow}Test Suite 12b: CodeWhale Native Skills${colors.reset}\n`);
|
||||
|
||||
try {
|
||||
clearCache();
|
||||
const platformCodes12b = await loadPlatformCodes();
|
||||
const codewhaleInstaller = platformCodes12b.platforms.codewhale?.installer;
|
||||
|
||||
assert(codewhaleInstaller?.target_dir === '.codewhale/skills', 'CodeWhale target_dir uses native skills path');
|
||||
|
||||
const tempProjectDir12b = await fs.mkdtemp(path.join(os.tmpdir(), 'bmad-codewhale-test-'));
|
||||
const installedBmadDir12b = await createTestBmadFixture();
|
||||
|
||||
const ideManager12b = new IdeManager();
|
||||
await ideManager12b.ensureInitialized();
|
||||
const result12b = await ideManager12b.setup('codewhale', tempProjectDir12b, installedBmadDir12b, {
|
||||
silent: true,
|
||||
selectedModules: ['bmm'],
|
||||
});
|
||||
|
||||
assert(result12b.success === true, 'CodeWhale setup succeeds against temp project');
|
||||
|
||||
const skillFile12b = path.join(tempProjectDir12b, '.codewhale', 'skills', 'bmad-master', 'SKILL.md');
|
||||
assert(await fs.pathExists(skillFile12b), 'CodeWhale install writes SKILL.md directory output');
|
||||
|
||||
await fs.remove(tempProjectDir12b);
|
||||
await fs.remove(path.dirname(installedBmadDir12b));
|
||||
} catch (error) {
|
||||
assert(false, 'CodeWhale native skills migration test succeeds', error.message);
|
||||
}
|
||||
|
||||
console.log('');
|
||||
|
||||
// ============================================================
|
||||
// Test 13: Cursor Native Skills Install
|
||||
// ============================================================
|
||||
|
|
|
|||
|
|
@ -70,6 +70,13 @@ platforms:
|
|||
target_dir: .agents/skills
|
||||
global_target_dir: ~/.codex/skills
|
||||
|
||||
codewhale:
|
||||
name: "CodeWhale"
|
||||
preferred: false
|
||||
installer:
|
||||
target_dir: .codewhale/skills
|
||||
global_target_dir: ~/.codewhale/skills
|
||||
|
||||
codebuddy:
|
||||
name: "CodeBuddy"
|
||||
preferred: false
|
||||
|
|
|
|||
Loading…
Reference in New Issue