Commit Graph

10 Commits

Author SHA1 Message Date
pbean 9b7db3cc9e fix(bmm): address third augment review batch on bmad skills
- step-03-triage: renumber the malformed `2b.` list item to a proper
  sequential step 3 (+ fix hanging indent) so the auto-mode
  "Verify against the code" step renders/parses as a list item.
- step-04-present (code-review): section 6 now says to update the spec's
  YAML frontmatter `status:` field (not an ambiguous "Status section"),
  matching automation-mode rule 8, quick-dev step-auto-finalize, the
  spec template, and the orchestrator's frontmatter status check.
- On Complete vs result.json-is-last-action: skip `## On Complete` /
  workflow.on_complete in auto mode. Removed the contradictory block
  from the auto-only step-auto-finalize; guarded the dual-mode
  code-review step-04-present block; added authoritative clauses to
  both automation-mode rulebooks (quick-dev rule 6, code-review rule 7).

Item on the 1600/4000 token threshold needed no change — step-02-plan
already inlines the {auto_mode} 4000 override and auto-splits.

validate:refs, validate:skills, lint:md all pass.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-21 23:19:50 -07:00
pbean f3d72676de fix(bmm): address second augment review batch on bmad-code-review
- step-02: guard the subagent-unavailable HALT behind {auto_mode} —
  in auto mode run reviewer roles inline instead of stalling (rule 1).
- deferred-work-format: drop "identical copy" wording; the sibling
  bmad-quick-dev copy shares the entry format but not the prose.
- step-01/03/04: use explicit ../automation-mode.md relative paths
  from steps/ for consistency with the PATH-05 deferred-work refs.

validate:refs, validate:skills, lint:md all pass.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-21 22:13:39 -07:00
pbean 3a5b471473 fix(bmm): give bmad-code-review its own deferred-work-format copy (PATH-05)
The prior commit pointed bmad-code-review at bmad-quick-dev's
deferred-work-format.md via a relative path (`../bmad-quick-dev/...`), which
reaches across a skill boundary and violates the PATH-05 encapsulation rule
(tools/skill-validator.md) — fragile when the skills are installed
independently. Ship a local copy inside bmad-code-review and reference it
locally instead:

- add bmad-code-review/deferred-work-format.md (identical to bmad-quick-dev's,
  plus a one-line "keep the two in sync" note).
- automation-mode.md rule 7: reference `./deferred-work-format.md`.
- steps/step-04-present.md: reference `../deferred-work-format.md`.

bmad-quick-dev is unchanged. validate:skills / validate:refs / lint:md /
format:check all pass.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
2026-06-21 21:18:18 -07:00
pbean ad4c6a7c6e fix(bmm): address automation-mode review comments on quick-dev/code-review
Resolves the augmentcode review findings on PR #2494, tightening the
BMAD_AUTO_MODE contract so unattended runs behave consistently:

- code-review automation-mode.md: harmonize the result.json `clean`
  definition with rule 8 (zero actionable findings AND spec status
  set to `done`), and correct the `dismissed` count description
  (recorded to the Review Ledger, not dropped).
- code-review step-04 §1: the clean shortcut now keys off actionable
  findings only and, in auto mode, still writes the Review Ledger when
  findings were dismissed before jumping to §6 — otherwise set-aside
  dismissals never reach the ledger and the next cycle re-litigates them.
- code-review: give explicit relative paths to bmad-quick-dev's
  deferred-work-format.md (rule 7 and step-04) so unattended agents can
  locate it.
- code-review step-01: ground the auto-mode note in rule 1 (no HALT
  anywhere in the step) instead of enumerating a partial skip list.
- quick-dev deferred-work-format.md: drop the dead
  `bmad-auto-sweep/migration-mode.md` reference (that file ships with the
  orchestrator, not BMAD-METHOD); describe the sweep migration as an
  external orchestrator-side process.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
2026-06-21 20:57:57 -07:00
pbean 4fbd384f11 feat(bmm): add automation mode to bmad-quick-dev and bmad-code-review skills
Add an opt-in automation mode (gated on BMAD_AUTO_MODE=1) so both skills can
run unattended under the bmad-auto orchestrator: checkpoints resolve via
decision tables instead of halting for human input, deferred work and review
findings are written in machine-readable formats, and the code-review skill
gains a static prefilter, prior-cycle ledger, and code-verification triage pass.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-21 20:13:12 -07:00
Jérôme Revillard e7a213ed07
feat: uniform customize.toml support across all BMM workflows (#2308)
* feat: extend customize.toml to all 6 developer-execution workflows (#2303)

Add uniform customization support to dev-story, code-review,
sprint-planning, sprint-status, quick-dev, and checkpoint-preview,
matching the same 4 extension points (activation_steps_prepend,
activation_steps_append, persistent_facts, on_complete) already
available on 17 BMM workflows from PR #2287.

- Create customize.toml for each workflow
- Add 6-step activation block to SKILL.md (merge workflow.md
  content in, delete workflow.md per PR #2287 pattern)
- Wire on_complete at terminal steps (inline <action> for XML
  workflows, ## On Complete section for step-file workflows)
- Fix pre-existing step number reference in dev-story (Step 6 → 9)

* fix: correct goto step="6" → step="9" in dev-story

The XML goto at line 203 still pointed to step 6 ("Author
comprehensive tests") instead of step 9 ("Story completion and mark
for review"), which is the actual completion gate. This was the
same class of pre-existing bug fixed in the text (M-1) but
missed in the XML action.

---------

Co-authored-by: Brian <bmadcode@gmail.com>
2026-04-24 17:45:25 -05:00
Alex Verkhovsky 202c842826
fix(code-review): remove dead Batch-apply option from patch menu (#2225)
The Batch-apply option (added in 9c3e2804) was instructed to "skip
any finding that requires judgment" — but step-03-triage already
guarantees patch findings are unambiguous (the decision-needed
bucket exists precisely to absorb ambiguous ones). The option had
no distinct work to do that option 1 did not already cover, and
its label suggested a meaningful difference that did not exist.

- Delete option 0 and the >3 findings conditional
- Rename "Fix them automatically" -> "Apply every patch", with
  explicit scope (patches only; defer/decision-needed untouched)
- Rename "Walk through each" -> "Walk through each patch" for the
  same scope clarity
- Unify <Z> placeholder with the existing <P> patch count
- Strip stale (or "0" for batch) notes from HALT lines
2026-04-09 21:02:07 -07:00
Alex Verkhovsky 182550407c
fix(code-review): update sprint-status to done after review completes (#2074)
* fix(code-review): update sprint-status to done after review completes

The code-review workflow ended without updating sprint-status.yaml from
"review" to "done", leaving stories stuck in review status. The dev-story
workflow implies code-review handles this transition but it was dropped
during the v6.2.0 step-file architecture refactor.

- Add sprint_status path to workflow initialization
- Track story_key in step-01 when discovered from sprint status
- Add step-04 section 6 to update sprint-status.yaml and story file
- Add step-04 section 7 with next-step options

Closes #2043

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* fix(code-review): address PR review findings — split gating, story_key guard, HALT

- Split section 6 guard: story file status gated on spec_file only,
  sprint-status sync sub-gated on story_key separately
- Add conditional branch for manual choice in multi-story path so
  story_key is cleared when user declines a story selection
- Add HALT directive after Next steps menu to prevent LLM runaway

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2026-03-20 10:56:08 -06:00
Alex Verkhovsky 9088d4958b
fix(code-review): restore actionable review output with interactive choices (#2055)
* fix(code-review): restore actionable review output with interactive choices

The March 15 rewrite (PR #2007) removed the ability to auto-fix patches,
create action items in story files, and handle deferred/spec findings.
This restores interactive post-review actions:

- Deferred findings: auto-written to deferred-work.md and checked off in story
- Intent gap/bad spec: conversation with downgrade-to-patch, patch-spec,
  reset-to-ready-for-dev, or dismiss options
- Patch findings: fix automatically, create action items, or show details

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* refactor(code-review): simplify triage to decision-needed/patch/defer/dismiss

Replace 5-bucket classification (intent_gap, bad_spec, patch, defer, reject)
with 4 pragmatic buckets. Findings always written to story file first.
Decision-needed findings gate patch handling — resolve ambiguity before fixing.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* fix(code-review): address PR review findings in step-04-present

Replace undefined curly-brace placeholders with angle-bracket syntax,
add HALT guard before patch menu, guard spec_file references for
no-spec mode, and backtick category names for consistency.

* feat(code-review): add HALT guards, batch option, defer reason, final summary

Add strong HALT guards after decision-needed and patch menus to prevent
auto-progression. Add batch-apply option 0 for >3 patch findings. Prompt
for defer reason and append to story file and deferred-work.md. Show
boxed final summary with counts. Polish clean-review shortcut in triage.

---------

Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2026-03-20 01:07:04 -06:00
Brian 0380656de6
refactor: consolidate agents into phase-based skill directories (#2050)
* refactor: consolidate agents into phase-based skill directories

Remove separate agent/workflow/skill directories (src/bmm/agents,
src/bmm/workflows, src/core/skills, src/utility/agent-components) and
reorganize all content into phase-based structures under src/bmm-skills
(1-analysis, 2-plan-workflows, 3-solutioning, 4-implementation) and
src/core-skills. Eliminates the agent/skill distinction by treating
agents as skills within their workflow phase.

* fix: update broken file references to use new bmm-skills paths

* docs: update all references for unified bmad-quick-dev workflow

Remove all references to the old separate bmad-quick-spec and
bmad-quick-dev-new-preview workflows. The new bmad-quick-dev is a
unified workflow that handles intent clarification, planning,
implementation, review, and presentation in a single run.

Updated files across English docs, Chinese translations, source
skill manifests, website diagram, and build tooling.
2026-03-18 01:01:33 -05:00