Commit Graph

2 Commits

Author SHA1 Message Date
Jonah Schulte f94474159b refactor: consolidate to src/bmm, delete src/modules/bmm (Option A)
Migrates all valuable content from src/modules/bmm → src/bmm and removes the
duplicate directory structure. This resolves the two-directory confusion that
caused the accidental 3-solutioning deletion.

**Content Migrated:**
-  Improved pattern files (agent-completion, security-checklist, tdd, verification, README)
  - More comprehensive content (225, 340, 184, 198 lines vs 187, 122, 93, 143)
  - Last updated Jan 27 (newer than src/bmm versions)
-  Better multi-agent-review agent counts (2/4/6 instead of 1/2/3)
  - micro: 2 agents (security + code_quality)
  - standard: 4 agents (+ architecture + testing)
  - complex: 6 agents (+ performance + domain_expert)

**Deletions:**
-  src/modules/bmm/ (66 files) - All workflows were outdated or renamed
  - batch-super-dev → batch-stories (renamed Jan 28)
  - story-pipeline → story-dev-only (renamed Jan 28)
  - super-dev-pipeline → story-full-pipeline (renamed Jan 28)

**Path Updates:**
- tools/cli/installers/lib/core/dependency-resolver.js (code + tests)
- tools/cli/lib/yaml-xml-builder.js (comment)
- tools/build-docs.js (doc URLs)
- test/unit/core/dependency-resolver*.test.js (test fixtures)
- resources/skills/bmad-guide.md (workflow references)

**Result:**
- Single canonical location: src/bmm (183 files)
- No more sync confusion
- Best content from both directories preserved
- 350/352 tests passing (2 advanced edge cases to fix later)
2026-01-28 10:55:03 -05:00
Jonah Schulte 5e841f9cac test: add comprehensive test coverage for file operations, dependency resolution, and transformations
Implement Vitest testing framework with 287 new tests achieving 80%+ overall coverage for previously untested critical components.

Coverage achievements:
- file-ops.js: 100% (exceeded 95% target)
- xml-utils.js: 100%
- config.js: 89% (exceeded 85% target)
- yaml-xml-builder.js: 86% (close to 90% target)
- dependency-resolver.js: 81%, 100% functions

New test coverage:
- 126 tests for file operations (254+ file system interactions)
- 74 tests for dependency resolution (multi-pass, circular detection)
- 69 tests for YAML/XML transformations (persona merging, XML generation)
- 37 tests for configuration processing (placeholder replacement, validation)
- 18 tests for XML utilities (special character escaping)

Infrastructure improvements:
- Add Vitest 4.0.16 with V8 coverage provider
- Create test helpers for temp directories and fixtures
- Configure ESLint for ES module test files
- Update npm scripts for test execution and coverage
- Maintain 100% backward compatibility with existing tests

Critical scenarios tested:
- Data loss prevention in syncDirectory() with hash/timestamp comparison
- Circular dependency handling in multi-pass resolution
- XML special character escaping to prevent injection
- Unicode filename and content handling
- Large file streaming (10MB+) for hash calculation

All 352 tests (65 existing + 287 new) passing with zero flaky tests.
2026-01-08 11:46:12 -05:00