Commit Graph

3 Commits

Author SHA1 Message Date
pbean bf30176391 fix(bmm): address coderabbit review on bmad-code-review/quick-dev skills
Actionable:
- step-03-triage / step-04-present (code-review): wire automation-mode
  rule 6 (spec defects) into the steps it governs — step-03 classifies a
  spec-defect finding (frozen → defer + CRITICAL type:spec-defect; non-frozen
  → patch + PREFERENCE) and step-04 appends the `## Spec Change Log` entry.
  Mirrors the existing rule-5 hook and quick-dev's bad_spec pattern.
- step-04-present (code-review): make result.json field population explicit
  (workflow/clean/patched/deferred/dismissed/escalations) instead of only
  "write per the schema", so unattended runs populate every field.

Nitpicks (quick-dev):
- step-02-plan: escalate `CRITICAL (type: intent-gap)` to match the schema;
  add a CHECKPOINT-1 spec-file preflight (escalate type:spec-write-failure
  if missing/empty before locking), matching the interactive path.
- step-01-clarify-and-route: clarify "always the plan→code→review path
  (never one-shot)" so it doesn't read as conflicting with resume routing.
- step-03-implement: name the finalize target (`./step-auto-finalize.md`).
- deferred-work-format (both copies, kept in sync): note multi-line field
  wrapping and that seen-again/resolution/decision are separate lines.

validate:refs, validate:skills, lint:md all pass.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-22 00:26:20 -07:00
pbean f3d72676de fix(bmm): address second augment review batch on bmad-code-review
- step-02: guard the subagent-unavailable HALT behind {auto_mode} —
  in auto mode run reviewer roles inline instead of stalling (rule 1).
- deferred-work-format: drop "identical copy" wording; the sibling
  bmad-quick-dev copy shares the entry format but not the prose.
- step-01/03/04: use explicit ../automation-mode.md relative paths
  from steps/ for consistency with the PATH-05 deferred-work refs.

validate:refs, validate:skills, lint:md all pass.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-21 22:13:39 -07:00
pbean 3a5b471473 fix(bmm): give bmad-code-review its own deferred-work-format copy (PATH-05)
The prior commit pointed bmad-code-review at bmad-quick-dev's
deferred-work-format.md via a relative path (`../bmad-quick-dev/...`), which
reaches across a skill boundary and violates the PATH-05 encapsulation rule
(tools/skill-validator.md) — fragile when the skills are installed
independently. Ship a local copy inside bmad-code-review and reference it
locally instead:

- add bmad-code-review/deferred-work-format.md (identical to bmad-quick-dev's,
  plus a one-line "keep the two in sync" note).
- automation-mode.md rule 7: reference `./deferred-work-format.md`.
- steps/step-04-present.md: reference `../deferred-work-format.md`.

bmad-quick-dev is unchanged. validate:skills / validate:refs / lint:md /
format:check all pass.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
2026-06-21 21:18:18 -07:00