Commit Graph

1406 Commits

Author SHA1 Message Date
Dicky Moore 3c1df006fe Merge remote-tracking branch 'upstream/main' into phase1-md-workflows-clean 2026-02-08 23:28:58 +00:00
Dicky Moore 95b437023d fix: clarify create-story context extraction and state age handling 2026-02-08 23:25:01 +00:00
Dicky Moore 5e8289fe26 test: expand workflow reference guard to scan installer JS 2026-02-08 22:52:18 +00:00
Dicky Moore 3aaa37125b fix: route IDE workflow templates through workflow runner 2026-02-08 22:37:04 +00:00
Dicky Moore 0a3f48f13f fix: address coderabbit workflow migration follow-ups 2026-02-08 22:16:06 +00:00
Davor Racic 90ea3cbed7
Minor installer fixes (#1590)
* fix: remove redundant "None" skip option from module selection

The "None - Skip module installation" option was unnecessary since
core is always locked/selected, satisfying the required constraint.
Users can simply press Enter with only core selected to skip modules.
Also removes dead code: selectModules(), getExternalModuleChoices(),
and selectExternalModules() methods that were never called.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

* fix: support ESM and .cjs module installers in ModuleManager

Module installer loading now handles three cases:
- .cjs files loaded via require() (always CommonJS regardless of package type)
- .js files loaded via dynamic import() (works for both CJS and ESM)
- CJS default export unwrapped automatically for consistent API

This fixes errors when external modules set "type":"module" in their
package.json. Those modules must still rename installer.js to
installer.cjs if it uses require() internally.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

* fix: address code review findings from PR #1590

- Filter 'core' from CLI --modules in update path for consistency
- Update selectAllModules() JSDoc to reflect core exclusion
- Fix ESM default-export unwrap to handle function/class exports

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

* fix: clarify module post-install script errors as non-fatal warnings

Change error display from log.error to log.warn and explain that the
module was installed successfully — only the optional post-install
script could not run. Prevents users from thinking the module
installation itself failed.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

* fix: suppress non-fatal module post-install script errors

Post-install scripts fail due to CJS/ESM incompatibility but module
files are already copied successfully. Silently catch the error instead
of showing a warning that alarms users into thinking installation failed.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

* fix: remove redundant modules and tools lines from install summary

The checkmark list already shows each installed module and IDE tool.
Keep only the install path and file-warning lines in the summary footer.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
Co-authored-by: Brian <bmadcode@gmail.com>
2026-02-08 15:41:51 -06:00
Dicky Moore dde139a560 fix: restore installer edge-case handling and path normalization 2026-02-08 20:04:58 +00:00
Dicky Moore c108ae4314 fix: remove stale xml docs reference and tighten workflow wording 2026-02-08 19:54:37 +00:00
Dicky Moore ee7f5a8969 fix: harden document workflow choices and config path handling 2026-02-08 19:43:46 +00:00
Dicky Moore 197c0f185b
Merge branch 'main' into phase1-md-workflows-clean 2026-02-08 19:23:31 +00:00
Dicky Moore a94df6dcd8 fix: address latest coderabbit workflow guidance issues 2026-02-08 18:02:21 +00:00
Alex Verkhovsky a1101534b2
fix(docs): comprehensive documentation site review fixes (#1578)
* fix(docs): comprehensive documentation site review fixes

Rehype plugins:
- Rewrite rehype-markdown-links for correct relative .md resolution
- Handle raw HTML base paths and bare .md links in rehype-base-paths
- Guard protocol-relative URLs (//...) in all link processors
- Use file.path instead of file.history[0] for vfile compatibility
- Fail build when content directory cannot be detected
- Export helpers for testability; add 107 unit tests

Build & CI:
- Revert cancel-in-progress to false to avoid mid-deploy cancellation
- Remove redundant link-validation CI step (build validates internally)
- Remove unnecessary fetch-depth:0 from docs deploy workflow
- Refuse docs build on Windows (platform guard)
- Remove dead build scripts and stale references

Tooling:
- Add DOCS_ROOT boundary check in validate-doc-links.js
- Handle directory paths and prefix stripping in link validator
- Remove dead regex and add // guard in fix-doc-links.js

Accessibility & CSS:
- Darken caution/danger aside title colors for WCAG AA 4.5:1 contrast
- Fix 100vw scrollbar overflow (banner width:100%, html overflow-x:clip)
- Add :focus-visible ring to banner link for keyboard navigation
- Remove dead CSS declaration and add missing code block lang

Documentation content:
- Convert /docs/ absolute links to relative paths and fix llms.txt URLs
- Correct command file paths and naming in commands reference
- Update stale shard-doc command to current /bmad-shard-doc format
- Fix incomplete sentence in install-bmad.md
- Add Quick Flow next steps and fix 404 link path
- Expand thin content pages with substantive detail
- Add sidebar ordering frontmatter to all content pages
- Remove BMGD docs (moved to dedicated repo)
- Remove unused assets and misleading diagram caption
- Add non-iframe fallback link to workflow map diagram
- Remove dead noscript block from workflow-map
- Standardize BMAD to BMad, fix spelling/grammar, normalize headings

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

* fix(docs): add non-interactive installation to sidebar, rewrite and reorder how-to guides

- Move non-interactive-installation.md into how-to/ directory so it appears
  in the sidebar navigation (was orphaned at docs root)
- Rewrite the page based on editorial review: consolidate redundant sections,
  add missing how-to structure (prerequisites, "What You Get"), condense
  installation modes from 5 subsections to a table, cut speculative examples
- Reorder how-to sidebar: Install (1), Non-Interactive (2), Upgrade to v6 (3),
  then the rest following user journey order
- Fix README link to point to docs site instead of repo-internal markdown path

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

* fix(docs): address documentation review findings

Fix broken directory tree, grammar errors, inconsistent naming,
missing admonition/headings, enable lastUpdated timestamps in CI,
and remove footer CSS that misapplied to the content footer.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

* fix(docs): move bleeding-edge install command out of Verify Installation

The alternative npx command for installing from main was misplaced
inside the "Verify Installation" section. Move it to a tip admonition
under Step 1 where users look for install options.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
2026-02-08 11:58:22 -06:00
Dicky Moore c916b78dea chore: acknowledge migration scope and request focused review
This PR is intentionally large due to coupled workflow.md migration and step-flow parity updates across runtime, installer, and tests.\n\nFollow-up work can be split by domain if maintainers prefer smaller review surfaces.
2026-02-08 17:50:56 +00:00
Dicky Moore c1484c3dcc fix: restore workflow input contracts after md migration 2026-02-08 16:33:34 +00:00
Dicky Moore d87d654af7 fix(document-project): gate resume completion on subworkflow success 2026-02-08 16:14:37 +00:00
Dicky Moore e0cfff50da fix: tighten workflow routing and validation consistency 2026-02-08 15:52:47 +00:00
Dicky Moore 80328a6d2a fix: restore help grounding and align installer defaults 2026-02-08 15:44:56 +00:00
Dicky Moore 3a7d8933b5 fix(kiro): migrate yaml workflow template runner to workflow.md 2026-02-08 15:35:54 +00:00
Dicky Moore bff2808986
Merge branch 'main' into phase1-md-workflows-clean 2026-02-08 15:32:11 +00:00
Michael Pursifull 24cf444366
feat: extend Layer 1 file-ref validator to scan CSV workflow-file references (#1573)
* feat: extend validate-file-refs.js to scan CSV workflow-file references

Add CSV file reference extraction to the Layer 1 validation pipeline,
preventing broken _bmad/ workflow-file paths in module-help.csv files.
Closes the gap identified after PR #1529 where CSV references were
unvalidated despite being a source of repeat community issues.

Refs: #1519

* fix: include test:refs in aggregate test script

Add CSV file-ref extraction tests to the aggregate `npm test` pipeline,
matching the existing pattern for test:schemas and test:install.

Thanks to CodeRabbit for catching the omission.

* fix: address review feedback on CSV validator extension

- Surface CSV parse errors visibly instead of silently swallowing
  (no Layer 2c schema validator exists yet to catch these)
- Add explanatory comments for the !VERBOSE logging pattern
  (non-verbose prints file headers only when issues found)
- Add verbose-mode diagnostics for extensionless path handling
  ([SKIP] when nothing exists, [OK-DIR] for valid directories)

* refactor: collect-then-print to eliminate confusing !VERBOSE pattern

Replace the split header-printing logic (print early in verbose mode,
print late in non-verbose mode with a !VERBOSE guard) with a simpler
collect-then-print approach. Refs are now classified into ok[] and
broken[] arrays first, then printed in a single location with one
straightforward if/else if decision.

Addresses alexeyv's review feedback about the counterintuitive
"if not verbose, log" pattern.

* feat: promote extensionless unresolved paths from silent skip to [UNRESOLVED]

Paths without file extensions that don't exist as files or directories
are now flagged as [UNRESOLVED] — a distinct tag from [BROKEN] (which
means a file with a known extension wasn't found). Both count toward
the broken reference total and appear in CI annotations.

This catches real bugs like wrong directory names in installed_path
metadata and dead invoke-workflow references to removed workflows.
Extensionless paths that DO exist as directories are still [OK-DIR].

---------

Co-authored-by: Alex Verkhovsky <alexey.verkhovsky@gmail.com>
Co-authored-by: Brian <bmadcode@gmail.com>
2026-02-08 09:19:53 -06:00
Alex Verkhovsky fc5ef57a5a
feat: add Kiro IDE support via config-driven installer (#1589)
Replace broken kiro-cli.js custom installer with config-driven approach
using platform-codes.yaml. Creates Kiro-specific templates with
inclusion: manual frontmatter and #[[file:...]] reference syntax.
2026-02-08 09:18:28 -06:00
Dicky Moore 45a9f3bf4e test: remove redundant validate-workflow exclusion in guard scan 2026-02-08 15:07:46 +00:00
Dicky Moore a1c054006a refine workflow contracts for review findings, halt protocol, and sprint tracking 2026-02-08 15:01:58 +00:00
Dicky Moore e7d7bbc3ea docs(correct-course): clarify installed vs source workflow paths 2026-02-08 14:46:45 +00:00
Dicky Moore 25354fc131 Merge remote-tracking branch 'origin/phase1-md-workflows-clean' into phase1-md-workflows-clean 2026-02-08 14:25:57 +00:00
Dicky Moore f74f6047f2 fix: hide internal workflow task from codex exports 2026-02-08 14:23:22 +00:00
Dicky Moore 5caf92cfdb fix: restore help routing and external module install tolerance 2026-02-08 14:23:22 +00:00
Dicky Moore 9604f6d00c fix: align workflow path guidance with installed runtime 2026-02-08 14:23:22 +00:00
Dicky Moore 98831695d0 fix: define installed workflow paths in qa and create-story 2026-02-08 14:23:21 +00:00
Dicky Moore e86fa2ee9e fix: restore runtime workflow paths and standalone parsing 2026-02-08 14:23:21 +00:00
Dicky Moore 3feb0d378f fix: resolve workflow guardrails and installer regressions 2026-02-08 14:23:21 +00:00
Dicky Moore 2a9b447e04 fix: add workflow loader fallback guidance and guards 2026-02-08 14:23:21 +00:00
Dicky Moore cfdb2db0f5 fix: correct workflow command defaults and bmm document config paths 2026-02-08 14:23:21 +00:00
Dicky Moore 454ae910f9 fix: harden install XML guard and remove no-op placeholder replacement 2026-02-08 14:23:06 +00:00
Dicky Moore 87c4292021 Finish step-flow migration for dev workflows and fix installer regressions 2026-02-08 14:23:06 +00:00
Dicky Moore 7fc8318e08 Migrate remaining workflows to workflow.md and fix CLI/test regressions 2026-02-08 14:22:30 +00:00
Dicky Moore c636042dba Migrate QA automate workflow to workflow.md 2026-02-08 14:22:30 +00:00
Dicky Moore 3aba7f089d Update validate-workflow references 2026-02-08 14:22:30 +00:00
Dicky Moore 21efe68512 Remove reintroduced TEA/excalidraw artifacts 2026-02-08 14:22:30 +00:00
Dicky Moore 052cc839fe Fix remaining workflow.yaml/xml references 2026-02-08 14:22:30 +00:00
Dicky Moore 0c34f528da Drop YAML workflow support from CLI tooling 2026-02-08 14:22:30 +00:00
Dicky Moore 2212d92260 Remove workflow.xml runner and update CLI wording 2026-02-08 14:21:37 +00:00
Dicky Moore 9054719d93 Migrate workflow runner references to workflow.md 2026-02-08 14:21:37 +00:00
Dicky Moore a1bc1a37f4 Convert Phase 2/3 workflows to MD 2026-02-08 14:11:58 +00:00
Dicky Moore 730ba6bdb0 Add advanced-elicitation MD workflow and guard 2026-02-08 14:11:58 +00:00
Dicky Moore ba91d9c03f Convert remaining Phase 1 workflows to MD 2026-02-08 14:11:58 +00:00
Dicky Moore 5042a895de Make workflow references platform-agnostic 2026-02-08 14:11:58 +00:00
Dicky Moore 129f2d4ac9 fix: hide internal workflow task from codex exports 2026-02-08 14:06:43 +00:00
Dicky Moore 40787c5035 fix: restore help routing and external module install tolerance 2026-02-08 14:06:43 +00:00
Dicky Moore 00a2334969 fix: align workflow path guidance with installed runtime 2026-02-08 13:07:55 +00:00