fix: address PR review findings in skill validator

- Guard against YAML comment lines in parseFrontmatterMultiline
- Broaden PATH-02 to detect any installed_path mention, not just variable refs

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This commit is contained in:
Alex Verkhovsky 2026-03-18 14:32:55 -06:00
parent 84bade9a95
commit fd1e24c5c2
1 changed files with 6 additions and 4 deletions

View File

@ -135,6 +135,8 @@ function parseFrontmatterMultiline(content) {
currentKey = line.slice(0, colonIndex).trim();
currentValue = line.slice(colonIndex + 1);
} else if (currentKey !== null) {
// Skip YAML comment lines
if (line.trimStart().startsWith('#')) continue;
// Continuation of multiline value
currentValue += '\n' + line;
}
@ -448,19 +450,19 @@ function validateSkill(skillDir) {
});
}
// Check content for {installed_path}
// Check content for any mention of installed_path (variable ref, prose, bare text)
const stripped = stripCodeBlocks(content);
const lines = stripped.split('\n');
for (const [i, line] of lines.entries()) {
if (line.includes('{installed_path}')) {
if (/installed_path/i.test(line)) {
findings.push({
rule: 'PATH-02',
title: 'No installed_path Variable',
severity: 'HIGH',
file: relFile,
line: i + 1,
detail: '`{installed_path}` reference found in content.',
fix: 'Replace `{installed_path}/path` with a relative path (`./path` or `../path`).',
detail: '`installed_path` reference found in content.',
fix: 'Remove all installed_path usage. Use relative paths (`./path` or `../path`) instead.',
});
}
}