From f740cd2d173ef41d5de5a278546bc6b01f24b84c Mon Sep 17 00:00:00 2001 From: Alex Verkhovsky Date: Mon, 2 Mar 2026 16:48:34 -0700 Subject: [PATCH] fix(quick-flow): address PR review findings for quick-dev2 - step-04-review: fix copy-paste fallback text to say "perform all three reviews inline sequentially" instead of "implement directly" - workflow.md: add missing planning_artifacts to initialization list, matching quick-spec and quick-dev siblings - quick-flow-solo-dev.agent.yaml: change QD and QQ menu entries from workflow: to exec: for .md files, matching the exec-for-md convention --- src/bmm/agents/quick-flow-solo-dev.agent.yaml | 4 ++-- .../bmad-quick-flow/quick-dev2/steps/step-04-review.md | 2 +- src/bmm/workflows/bmad-quick-flow/quick-dev2/workflow.md | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/bmm/agents/quick-flow-solo-dev.agent.yaml b/src/bmm/agents/quick-flow-solo-dev.agent.yaml index 6673ac152..6bab6a3d7 100644 --- a/src/bmm/agents/quick-flow-solo-dev.agent.yaml +++ b/src/bmm/agents/quick-flow-solo-dev.agent.yaml @@ -24,11 +24,11 @@ agent: description: "[QS] Quick Spec: Architect a quick but complete technical spec with implementation-ready stories/specs" - trigger: QD or fuzzy match on quick-dev - workflow: "{project-root}/_bmad/bmm/workflows/bmad-quick-flow/quick-dev/workflow.md" + exec: "{project-root}/_bmad/bmm/workflows/bmad-quick-flow/quick-dev/workflow.md" description: "[QD] Quick-flow Develop: Implement a story tech spec end-to-end (Core of Quick Flow)" - trigger: QQ or fuzzy match on quick-dev2 - workflow: "{project-root}/_bmad/bmm/workflows/bmad-quick-flow/quick-dev2/workflow.md" + exec: "{project-root}/_bmad/bmm/workflows/bmad-quick-flow/quick-dev2/workflow.md" description: "[QQ] Quick Dev 2: Unified quick flow — clarify intent, plan, implement, review, present (experimental)" - trigger: CR or fuzzy match on code-review diff --git a/src/bmm/workflows/bmad-quick-flow/quick-dev2/steps/step-04-review.md b/src/bmm/workflows/bmad-quick-flow/quick-dev2/steps/step-04-review.md index 3c1246078..e7b6d9315 100644 --- a/src/bmm/workflows/bmad-quick-flow/quick-dev2/steps/step-04-review.md +++ b/src/bmm/workflows/bmad-quick-flow/quick-dev2/steps/step-04-review.md @@ -29,7 +29,7 @@ Do NOT `git add` anything — this is read-only inspection. **One-shot:** Skip diff construction. Still invoke `{adversarial_review_task}` in a subagent with the changed files — inline review invites anchoring bias. -**Plan-code-review:** Launch three subagents without conversation context. If no sub-agents are available, implement directly. +**Plan-code-review:** Launch three subagents without conversation context. If no sub-agents are available, perform all three reviews inline sequentially. - **Blind hunter** — receives `{diff_output}` only. No spec, no context docs, no project access. Invoke via `{adversarial_review_task}`. - **Edge case hunter** — receives `{diff_output}` and read access to the project. Invoke via `{edge_case_hunter_task}`. diff --git a/src/bmm/workflows/bmad-quick-flow/quick-dev2/workflow.md b/src/bmm/workflows/bmad-quick-flow/quick-dev2/workflow.md index 2aed217ce..0eb677301 100644 --- a/src/bmm/workflows/bmad-quick-flow/quick-dev2/workflow.md +++ b/src/bmm/workflows/bmad-quick-flow/quick-dev2/workflow.md @@ -71,7 +71,7 @@ This uses **step-file architecture** for disciplined execution: Load and read full config from `{main_config}` and resolve: -- `project_name`, `implementation_artifacts`, `user_name` +- `project_name`, `planning_artifacts`, `implementation_artifacts`, `user_name` - `communication_language`, `document_output_language`, `user_skill_level` - `date` as system-generated current datetime - `project_context` = `**/project-context.md` (load if exists)