From e479b4164cdd9c1fb60d663eb9543f8a35c73464 Mon Sep 17 00:00:00 2001 From: Alex Verkhovsky Date: Mon, 5 Jan 2026 06:02:17 -0800 Subject: [PATCH] refactor(code-review): add checkpoint for empty git changes and exclude ignored files MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Step-01 substeps 5: - If no git changes detected: halt and ask user "Continue anyway?" Allows AC audit on story File List even if no code changes in git - Exclude git-ignored files from discrepancy comparison Prevents false positives if story modified only ignored files 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Haiku 4.5 --- .../code-review/steps/step-01-load-story.md | 13 +++++++++++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/src/modules/bmm/workflows/4-implementation/code-review/steps/step-01-load-story.md b/src/modules/bmm/workflows/4-implementation/code-review/steps/step-01-load-story.md index 63223380..efac14d5 100644 --- a/src/modules/bmm/workflows/4-implementation/code-review/steps/step-01-load-story.md +++ b/src/modules/bmm/workflows/4-implementation/code-review/steps/step-01-load-story.md @@ -78,12 +78,21 @@ Compile `git_changed_files` = union of modified, staged, new, deleted, and renam ### 5. Cross-Reference Story vs Git -Compare {story_file_list} with {git_changed_files}: +**If {git_changed_files} is empty:** + +Ask user: "No git changes detected. Continue anyway?" + +- If **no**: HALT the workflow +- If **yes**: Continue to comparison + +**Compare {story_file_list} with {git_changed_files}:** + +Exclude git-ignored files from the comparison (run `git check-ignore` if needed). Set `git_discrepancies` with categories: - **files_in_git_not_story**: Files changed in git but not in story File List -- **files_in_story_not_git**: Files in story File List but no git changes +- **files_in_story_not_git**: Files in story File List but no git changes (excluding git-ignored) - **uncommitted_undocumented**: Uncommitted changes not tracked in story ### 6. Load Project Context