From e1c6a05259aa50f4a9a862473da5f76e78ecc9f7 Mon Sep 17 00:00:00 2001 From: Jonah Schulte Date: Mon, 26 Jan 2026 22:16:43 -0500 Subject: [PATCH] fix: make story verification executable with REQUIRED bash commands in orchestrator **Critical Changes:** 1. Workflow.md now explicitly tells orchestrator to USE BASH TOOL 2. Bash commands must be run, not just read 3. If verification fails, orchestrator must use Edit/Bash tools to fix NOW 4. Verification is MANDATORY before story marked complete **Both workflows now enforce this:** - super-dev-pipeline: Reconciler agent + Final Verification - batch-super-dev: Orchestrator runs bash verification after each agent **Version:** 6.0.0-Beta.5 --- .../batch-super-dev/instructions.md | 33 +++++++++---------- .../super-dev-pipeline/workflow.md | 9 ++++- 2 files changed, 23 insertions(+), 19 deletions(-) diff --git a/src/modules/bmm/workflows/4-implementation/batch-super-dev/instructions.md b/src/modules/bmm/workflows/4-implementation/batch-super-dev/instructions.md index c4ea8f4d..bcd4652c 100644 --- a/src/modules/bmm/workflows/4-implementation/batch-super-dev/instructions.md +++ b/src/modules/bmm/workflows/4-implementation/batch-super-dev/instructions.md @@ -1308,37 +1308,34 @@ Spawning Task agent... ✅ Implementation complete: {{story_key}} - Execute Step 4.5: Smart Story Reconciliation - Load reconciliation instructions: {installed_path}/step-4.5-reconcile-story-status.md - Execute reconciliation with story_key={{story_key}} + 🚨 STORY RECONCILIATION - ORCHESTRATOR DOES THIS NOW (NOT AGENTS) - 🚨 MANDATORY STORY FILE VERIFICATION - YOU MUST RUN THESE BASH COMMANDS + +━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ +🔧 RECONCILING STORY FILE: {{story_key}} +━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ +Main orchestrator performing reconciliation (not delegating) + - STEP 1: Run bash verification commands (REQUIRED): + YOU (orchestrator) must use Bash tool NOW with this command: - -# Get story file path from story_key + STORY_FILE="docs/sprint-artifacts/{{story_key}}.md" -echo "━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━" -echo "🔍 VERIFYING STORY FILE: {{story_key}}" -echo "━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━" +echo "Verifying story file: $STORY_FILE" -# Check 1: Count checked tasks CHECKED_COUNT=$(grep -c "^- \[x\]" "$STORY_FILE" 2>/dev/null || echo "0") TOTAL_COUNT=$(grep -c "^- \[.\]" "$STORY_FILE" 2>/dev/null || echo "0") echo "Checked tasks: $CHECKED_COUNT/$TOTAL_COUNT" -# Check 2: Verify Dev Agent Record filled RECORD_FILLED=$(grep -A 20 "^### Dev Agent Record" "$STORY_FILE" 2>/dev/null | grep -c "Claude Sonnet" || echo "0") -echo "Dev Agent Record filled: $RECORD_FILLED" +echo "Dev Agent Record: $RECORD_FILLED" -# Store results for conditional logic -echo "$CHECKED_COUNT" > /tmp/checked_count.txt -echo "$RECORD_FILLED" > /tmp/record_filled.txt - +echo "checked_count=$CHECKED_COUNT" +echo "record_filled=$RECORD_FILLED" + - STEP 2: Read bash results and decide: + After running Bash tool, read the output and extract checked_count and record_filled values diff --git a/src/modules/bmm/workflows/4-implementation/super-dev-pipeline/workflow.md b/src/modules/bmm/workflows/4-implementation/super-dev-pipeline/workflow.md index 18cd2670..d2603244 100644 --- a/src/modules/bmm/workflows/4-implementation/super-dev-pipeline/workflow.md +++ b/src/modules/bmm/workflows/4-implementation/super-dev-pipeline/workflow.md @@ -243,7 +243,14 @@ Task({ 🚨 **CRITICAL: This verification is MANDATORY. DO NOT skip.** 🚨 -**After all agents complete, the MAIN ORCHESTRATOR must run this verification:** +**After all agents complete (including Reconciler), YOU (the main orchestrator) must:** + +1. **Use the Bash tool** to run these commands +2. **Read the output** to see if verification passed +3. **If verification fails**, use Edit and Bash tools to fix it NOW +4. **Do not proceed** until verification passes + +**COMMAND TO RUN WITH BASH TOOL:** ```bash echo "━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━"