refactor(code-review): use installed_path variable in step files
This commit is contained in:
parent
25f93a3b64
commit
dadca29b09
|
|
@ -2,9 +2,8 @@
|
|||
name: 'step-01-load-story'
|
||||
description: 'Load story file, discover git changes, establish review context'
|
||||
|
||||
workflow_path: '{project-root}/_bmad/bmm/workflows/4-implementation/code-review'
|
||||
thisStepFile: '{workflow_path}/steps/step-01-load-story.md'
|
||||
nextStepFile: '{workflow_path}/steps/step-02-build-attack-plan.md'
|
||||
thisStepFile: '{installed_path}/steps/step-01-load-story.md'
|
||||
nextStepFile: '{installed_path}/steps/step-02-build-attack-plan.md'
|
||||
---
|
||||
|
||||
# Step 1: Load Story and Discover Changes
|
||||
|
|
|
|||
|
|
@ -2,9 +2,8 @@
|
|||
name: 'step-02-build-attack-plan'
|
||||
description: 'Extract ACs and tasks, create comprehensive review plan for both phases'
|
||||
|
||||
workflow_path: '{project-root}/_bmad/bmm/workflows/4-implementation/code-review'
|
||||
thisStepFile: '{workflow_path}/steps/step-02-build-attack-plan.md'
|
||||
nextStepFile: '{workflow_path}/steps/step-03-context-aware-review.md'
|
||||
thisStepFile: '{installed_path}/steps/step-02-build-attack-plan.md'
|
||||
nextStepFile: '{installed_path}/steps/step-03-context-aware-review.md'
|
||||
---
|
||||
|
||||
# Step 2: Build Review Attack Plan
|
||||
|
|
|
|||
|
|
@ -2,9 +2,8 @@
|
|||
name: 'step-03-context-aware-review'
|
||||
description: 'Story-aware validation: verify ACs, audit task completion, check git discrepancies'
|
||||
|
||||
workflow_path: '{project-root}/_bmad/bmm/workflows/4-implementation/code-review'
|
||||
thisStepFile: '{workflow_path}/steps/step-03-context-aware-review.md'
|
||||
nextStepFile: '{workflow_path}/steps/step-04-adversarial-review.md'
|
||||
thisStepFile: '{installed_path}/steps/step-03-context-aware-review.md'
|
||||
nextStepFile: '{installed_path}/steps/step-04-adversarial-review.md'
|
||||
---
|
||||
|
||||
# Step 3: Context-Aware Review
|
||||
|
|
|
|||
|
|
@ -2,9 +2,8 @@
|
|||
name: 'step-04-adversarial-review'
|
||||
description: 'Context-independent adversarial diff review via subagent - no story knowledge'
|
||||
|
||||
workflow_path: '{project-root}/_bmad/bmm/workflows/4-implementation/code-review'
|
||||
thisStepFile: '{workflow_path}/steps/step-04-adversarial-review.md'
|
||||
nextStepFile: '{workflow_path}/steps/step-05-consolidate-findings.md'
|
||||
thisStepFile: '{installed_path}/steps/step-04-adversarial-review.md'
|
||||
nextStepFile: '{installed_path}/steps/step-05-consolidate-findings.md'
|
||||
---
|
||||
|
||||
# Step 4: Adversarial Review (Information Asymmetric)
|
||||
|
|
@ -78,7 +77,7 @@ If no baseline available, review current state of files in `{file_list}`:
|
|||
With `{diff_output}` constructed, invoke the review task. If possible, use information asymmetry: run this step, and only it, in a separate subagent or process with read access to the project, but no context except the `{diff_output}`.
|
||||
|
||||
```xml
|
||||
<invoke-task>Review {diff_output} using {project-root}/_bmad/core/tasks/review-adversarial-general.xml</invoke-task>
|
||||
<invoke-task>Review {diff_output} using {adversarial_review_task}</invoke-task>
|
||||
```
|
||||
|
||||
**Platform fallback:** If task invocation not available, load the task file and execute its instructions inline, passing `{diff_output}` as the content.
|
||||
|
|
|
|||
|
|
@ -2,9 +2,8 @@
|
|||
name: 'step-05-consolidate-findings'
|
||||
description: 'Merge and deduplicate findings from both review phases'
|
||||
|
||||
workflow_path: '{project-root}/_bmad/bmm/workflows/4-implementation/code-review'
|
||||
thisStepFile: '{workflow_path}/steps/step-05-consolidate-findings.md'
|
||||
nextStepFile: '{workflow_path}/steps/step-06-resolve-and-update.md'
|
||||
thisStepFile: '{installed_path}/steps/step-05-consolidate-findings.md'
|
||||
nextStepFile: '{installed_path}/steps/step-06-resolve-and-update.md'
|
||||
---
|
||||
|
||||
# Step 5: Consolidate Findings
|
||||
|
|
|
|||
|
|
@ -2,8 +2,7 @@
|
|||
name: 'step-06-resolve-and-update'
|
||||
description: 'Present findings, fix or create action items, update story and sprint status'
|
||||
|
||||
workflow_path: '{project-root}/_bmad/bmm/workflows/4-implementation/code-review'
|
||||
thisStepFile: '{workflow_path}/steps/step-06-resolve-and-update.md'
|
||||
thisStepFile: '{installed_path}/steps/step-06-resolve-and-update.md'
|
||||
---
|
||||
|
||||
# Step 6: Resolve Findings and Update Status
|
||||
|
|
|
|||
Loading…
Reference in New Issue