fix: address review findings from code review

- Fix merge_menu KeyError crash when menu items missing 'code' key
- Fix _is_menu_array to check ALL elements, not just first
- Remove unused import os from resolve-customization.py
- Remove inject.after from agent activation (agents have no completion
  point; inject.after only makes sense for workflows)

src/bmm-skills/1-analysis/bmad-agent-analyst/SKILL.md

@@ -24,8 +24,6 @@ Use the JSON output as resolved values.
    incorporate its content as high-priority context.
 3. **Load resources** -- If `additional_resources` is not empty, read
    each listed file and incorporate as reference context.
-4. **Inject after** -- If `inject.after` is not empty, read and
-   incorporate its content as supplementary context.
 
 You must fully embody this persona so the user gets the best experience and help they need. Do not break character until the user dismisses this persona. When the user calls a skill, this persona must carry through and remain active.
 

src/bmm-skills/1-analysis/bmad-agent-analyst/customize.toml

@@ -77,8 +77,6 @@ Ensure all stakeholder voices heard."""
 # ──────────────────────────────────────────────────────────────────
 # Injected prompts - content added to the agent's context on activation.
 # 'before' loads before the agent's core instructions.
-# 'after' loads after the agent's core instructions.
 # ──────────────────────────────────────────────────────────────────
 [inject]
 before = ""
-after = ""

src/bmm-skills/1-analysis/bmad-agent-analyst/scripts/resolve-customization.py

@@ -21,7 +21,6 @@ from __future__ import annotations
 
 import argparse
 import json
-import os
 import sys
 import tomllib
 from pathlib import Path
@@ -57,19 +56,21 @@ def load_toml(path: Path) -> dict[str, Any]:
 # ---------------------------------------------------------------------------
 
 def _is_menu_array(value: Any) -> bool:
-    """True when *value* looks like a ``[[menu]]`` array of tables with ``code`` keys."""
+    """True when *value* is a non-empty list where ALL items are dicts with a ``code`` key."""
     return (
         isinstance(value, list)
         and len(value) > 0
-        and isinstance(value[0], dict)
+        and all(isinstance(item, dict) and "code" in item for item in value)
-        and "code" in value[0]
     )
 
 
 def merge_menu(base: list[dict], override: list[dict]) -> list[dict]:
     """Merge-by-code: matching codes replace; new codes append."""
-    result_by_code: dict[str, dict] = {item["code"]: dict(item) for item in base}
+    result_by_code: dict[str, dict] = {item["code"]: dict(item) for item in base if "code" in item}
     for item in override:
+        if "code" not in item:
+            print(f"warning: menu item missing 'code' key, skipping: {item}", file=sys.stderr)
+            continue
         result_by_code[item["code"]] = dict(item)
     return list(result_by_code.values())
 

src/bmm-skills/1-analysis/bmad-agent-tech-writer/SKILL.md

@@ -24,8 +24,6 @@ Use the JSON output as resolved values.
    incorporate its content as high-priority context.
 3. **Load resources** -- If `additional_resources` is not empty, read
    each listed file and incorporate as reference context.
-4. **Inject after** -- If `inject.after` is not empty, read and
-   incorporate its content as supplementary context.
 
 You must fully embody this persona so the user gets the best experience and help they need. Do not break character until the user dismisses this persona. When the user calls a skill, this persona must carry through and remain active.
 

src/bmm-skills/1-analysis/bmad-agent-tech-writer/customize.toml

@@ -76,8 +76,6 @@ to be detailed."""
 # ──────────────────────────────────────────────────────────────────
 # Injected prompts - content added to the agent's context on activation.
 # 'before' loads before the agent's core instructions.
-# 'after' loads after the agent's core instructions.
 # ──────────────────────────────────────────────────────────────────
 [inject]
 before = ""
-after = ""

src/bmm-skills/1-analysis/bmad-agent-tech-writer/scripts/resolve-customization.py

@@ -21,7 +21,6 @@ from __future__ import annotations
 
 import argparse
 import json
-import os
 import sys
 import tomllib
 from pathlib import Path
@@ -57,19 +56,21 @@ def load_toml(path: Path) -> dict[str, Any]:
 # ---------------------------------------------------------------------------
 
 def _is_menu_array(value: Any) -> bool:
-    """True when *value* looks like a ``[[menu]]`` array of tables with ``code`` keys."""
+    """True when *value* is a non-empty list where ALL items are dicts with a ``code`` key."""
     return (
         isinstance(value, list)
         and len(value) > 0
-        and isinstance(value[0], dict)
+        and all(isinstance(item, dict) and "code" in item for item in value)
-        and "code" in value[0]
     )
 
 
 def merge_menu(base: list[dict], override: list[dict]) -> list[dict]:
     """Merge-by-code: matching codes replace; new codes append."""
-    result_by_code: dict[str, dict] = {item["code"]: dict(item) for item in base}
+    result_by_code: dict[str, dict] = {item["code"]: dict(item) for item in base if "code" in item}
     for item in override:
+        if "code" not in item:
+            print(f"warning: menu item missing 'code' key, skipping: {item}", file=sys.stderr)
+            continue
         result_by_code[item["code"]] = dict(item)
     return list(result_by_code.values())
 

src/bmm-skills/1-analysis/bmad-document-project/scripts/resolve-customization.py

@@ -21,7 +21,6 @@ from __future__ import annotations
 
 import argparse
 import json
-import os
 import sys
 import tomllib
 from pathlib import Path
@@ -57,19 +56,21 @@ def load_toml(path: Path) -> dict[str, Any]:
 # ---------------------------------------------------------------------------
 
 def _is_menu_array(value: Any) -> bool:
-    """True when *value* looks like a ``[[menu]]`` array of tables with ``code`` keys."""
+    """True when *value* is a non-empty list where ALL items are dicts with a ``code`` key."""
     return (
         isinstance(value, list)
         and len(value) > 0
-        and isinstance(value[0], dict)
+        and all(isinstance(item, dict) and "code" in item for item in value)
-        and "code" in value[0]
     )
 
 
 def merge_menu(base: list[dict], override: list[dict]) -> list[dict]:
     """Merge-by-code: matching codes replace; new codes append."""
-    result_by_code: dict[str, dict] = {item["code"]: dict(item) for item in base}
+    result_by_code: dict[str, dict] = {item["code"]: dict(item) for item in base if "code" in item}
     for item in override:
+        if "code" not in item:
+            print(f"warning: menu item missing 'code' key, skipping: {item}", file=sys.stderr)
+            continue
         result_by_code[item["code"]] = dict(item)
     return list(result_by_code.values())
 

src/bmm-skills/1-analysis/bmad-prfaq/scripts/resolve-customization.py

@@ -21,7 +21,6 @@ from __future__ import annotations
 
 import argparse
 import json
-import os
 import sys
 import tomllib
 from pathlib import Path
@@ -57,19 +56,21 @@ def load_toml(path: Path) -> dict[str, Any]:
 # ---------------------------------------------------------------------------
 
 def _is_menu_array(value: Any) -> bool:
-    """True when *value* looks like a ``[[menu]]`` array of tables with ``code`` keys."""
+    """True when *value* is a non-empty list where ALL items are dicts with a ``code`` key."""
     return (
         isinstance(value, list)
         and len(value) > 0
-        and isinstance(value[0], dict)
+        and all(isinstance(item, dict) and "code" in item for item in value)
-        and "code" in value[0]
     )
 
 
 def merge_menu(base: list[dict], override: list[dict]) -> list[dict]:
     """Merge-by-code: matching codes replace; new codes append."""
-    result_by_code: dict[str, dict] = {item["code"]: dict(item) for item in base}
+    result_by_code: dict[str, dict] = {item["code"]: dict(item) for item in base if "code" in item}
     for item in override:
+        if "code" not in item:
+            print(f"warning: menu item missing 'code' key, skipping: {item}", file=sys.stderr)
+            continue
         result_by_code[item["code"]] = dict(item)
     return list(result_by_code.values())
 

src/bmm-skills/1-analysis/bmad-product-brief/scripts/resolve-customization.py

@@ -21,7 +21,6 @@ from __future__ import annotations
 
 import argparse
 import json
-import os
 import sys
 import tomllib
 from pathlib import Path
@@ -57,19 +56,21 @@ def load_toml(path: Path) -> dict[str, Any]:
 # ---------------------------------------------------------------------------
 
 def _is_menu_array(value: Any) -> bool:
-    """True when *value* looks like a ``[[menu]]`` array of tables with ``code`` keys."""
+    """True when *value* is a non-empty list where ALL items are dicts with a ``code`` key."""
     return (
         isinstance(value, list)
         and len(value) > 0
-        and isinstance(value[0], dict)
+        and all(isinstance(item, dict) and "code" in item for item in value)
-        and "code" in value[0]
     )
 
 
 def merge_menu(base: list[dict], override: list[dict]) -> list[dict]:
     """Merge-by-code: matching codes replace; new codes append."""
-    result_by_code: dict[str, dict] = {item["code"]: dict(item) for item in base}
+    result_by_code: dict[str, dict] = {item["code"]: dict(item) for item in base if "code" in item}
     for item in override:
+        if "code" not in item:
+            print(f"warning: menu item missing 'code' key, skipping: {item}", file=sys.stderr)
+            continue
         result_by_code[item["code"]] = dict(item)
     return list(result_by_code.values())
 

src/bmm-skills/1-analysis/research/bmad-domain-research/scripts/resolve-customization.py

@@ -21,7 +21,6 @@ from __future__ import annotations
 
 import argparse
 import json
-import os
 import sys
 import tomllib
 from pathlib import Path
@@ -57,19 +56,21 @@ def load_toml(path: Path) -> dict[str, Any]:
 # ---------------------------------------------------------------------------
 
 def _is_menu_array(value: Any) -> bool:
-    """True when *value* looks like a ``[[menu]]`` array of tables with ``code`` keys."""
+    """True when *value* is a non-empty list where ALL items are dicts with a ``code`` key."""
     return (
         isinstance(value, list)
         and len(value) > 0
-        and isinstance(value[0], dict)
+        and all(isinstance(item, dict) and "code" in item for item in value)
-        and "code" in value[0]
     )
 
 
 def merge_menu(base: list[dict], override: list[dict]) -> list[dict]:
     """Merge-by-code: matching codes replace; new codes append."""
-    result_by_code: dict[str, dict] = {item["code"]: dict(item) for item in base}
+    result_by_code: dict[str, dict] = {item["code"]: dict(item) for item in base if "code" in item}
     for item in override:
+        if "code" not in item:
+            print(f"warning: menu item missing 'code' key, skipping: {item}", file=sys.stderr)
+            continue
         result_by_code[item["code"]] = dict(item)
     return list(result_by_code.values())
 

src/bmm-skills/1-analysis/research/bmad-market-research/scripts/resolve-customization.py

@@ -21,7 +21,6 @@ from __future__ import annotations
 
 import argparse
 import json
-import os
 import sys
 import tomllib
 from pathlib import Path
@@ -57,19 +56,21 @@ def load_toml(path: Path) -> dict[str, Any]:
 # ---------------------------------------------------------------------------
 
 def _is_menu_array(value: Any) -> bool:
-    """True when *value* looks like a ``[[menu]]`` array of tables with ``code`` keys."""
+    """True when *value* is a non-empty list where ALL items are dicts with a ``code`` key."""
     return (
         isinstance(value, list)
         and len(value) > 0
-        and isinstance(value[0], dict)
+        and all(isinstance(item, dict) and "code" in item for item in value)
-        and "code" in value[0]
     )
 
 
 def merge_menu(base: list[dict], override: list[dict]) -> list[dict]:
     """Merge-by-code: matching codes replace; new codes append."""
-    result_by_code: dict[str, dict] = {item["code"]: dict(item) for item in base}
+    result_by_code: dict[str, dict] = {item["code"]: dict(item) for item in base if "code" in item}
     for item in override:
+        if "code" not in item:
+            print(f"warning: menu item missing 'code' key, skipping: {item}", file=sys.stderr)
+            continue
         result_by_code[item["code"]] = dict(item)
     return list(result_by_code.values())
 

src/bmm-skills/1-analysis/research/bmad-technical-research/scripts/resolve-customization.py

@@ -21,7 +21,6 @@ from __future__ import annotations
 
 import argparse
 import json
-import os
 import sys
 import tomllib
 from pathlib import Path
@@ -57,19 +56,21 @@ def load_toml(path: Path) -> dict[str, Any]:
 # ---------------------------------------------------------------------------
 
 def _is_menu_array(value: Any) -> bool:
-    """True when *value* looks like a ``[[menu]]`` array of tables with ``code`` keys."""
+    """True when *value* is a non-empty list where ALL items are dicts with a ``code`` key."""
     return (
         isinstance(value, list)
         and len(value) > 0
-        and isinstance(value[0], dict)
+        and all(isinstance(item, dict) and "code" in item for item in value)
-        and "code" in value[0]
     )
 
 
 def merge_menu(base: list[dict], override: list[dict]) -> list[dict]:
     """Merge-by-code: matching codes replace; new codes append."""
-    result_by_code: dict[str, dict] = {item["code"]: dict(item) for item in base}
+    result_by_code: dict[str, dict] = {item["code"]: dict(item) for item in base if "code" in item}
     for item in override:
+        if "code" not in item:
+            print(f"warning: menu item missing 'code' key, skipping: {item}", file=sys.stderr)
+            continue
         result_by_code[item["code"]] = dict(item)
     return list(result_by_code.values())
 

src/bmm-skills/2-plan-workflows/bmad-agent-pm/SKILL.md

@@ -24,8 +24,6 @@ Use the JSON output as resolved values.
    incorporate its content as high-priority context.
 3. **Load resources** -- If `additional_resources` is not empty, read
    each listed file and incorporate as reference context.
-4. **Inject after** -- If `inject.after` is not empty, read and
-   incorporate its content as supplementary context.
 
 You must fully embody this persona so the user gets the best experience and help they need. Do not break character until the user dismisses this persona. When the user calls a skill, this persona must carry through and remain active.
 

src/bmm-skills/2-plan-workflows/bmad-agent-pm/customize.toml

@@ -77,8 +77,6 @@ over perfection. Technical feasibility is a constraint, not the driver \
 # ──────────────────────────────────────────────────────────────────
 # Injected prompts - content added to the agent's context on activation.
 # 'before' loads before the agent's core instructions.
-# 'after' loads after the agent's core instructions.
 # ──────────────────────────────────────────────────────────────────
 [inject]
 before = ""
-after = ""

src/bmm-skills/2-plan-workflows/bmad-agent-pm/scripts/resolve-customization.py

@@ -21,7 +21,6 @@ from __future__ import annotations
 
 import argparse
 import json
-import os
 import sys
 import tomllib
 from pathlib import Path
@@ -57,19 +56,21 @@ def load_toml(path: Path) -> dict[str, Any]:
 # ---------------------------------------------------------------------------
 
 def _is_menu_array(value: Any) -> bool:
-    """True when *value* looks like a ``[[menu]]`` array of tables with ``code`` keys."""
+    """True when *value* is a non-empty list where ALL items are dicts with a ``code`` key."""
     return (
         isinstance(value, list)
         and len(value) > 0
-        and isinstance(value[0], dict)
+        and all(isinstance(item, dict) and "code" in item for item in value)
-        and "code" in value[0]
     )
 
 
 def merge_menu(base: list[dict], override: list[dict]) -> list[dict]:
     """Merge-by-code: matching codes replace; new codes append."""
-    result_by_code: dict[str, dict] = {item["code"]: dict(item) for item in base}
+    result_by_code: dict[str, dict] = {item["code"]: dict(item) for item in base if "code" in item}
     for item in override:
+        if "code" not in item:
+            print(f"warning: menu item missing 'code' key, skipping: {item}", file=sys.stderr)
+            continue
         result_by_code[item["code"]] = dict(item)
     return list(result_by_code.values())
 

src/bmm-skills/2-plan-workflows/bmad-agent-ux-designer/SKILL.md

@@ -24,8 +24,6 @@ Use the JSON output as resolved values.
    incorporate its content as high-priority context.
 3. **Load resources** -- If `additional_resources` is not empty, read
    each listed file and incorporate as reference context.
-4. **Inject after** -- If `inject.after` is not empty, read and
-   incorporate its content as supplementary context.
 
 You must fully embody this persona so the user gets the best experience and help they need. Do not break character until the user dismisses this persona. When the user calls a skill, this persona must carry through and remain active.
 

src/bmm-skills/2-plan-workflows/bmad-agent-ux-designer/customize.toml

@@ -73,8 +73,6 @@ accelerate human-centered design. Data-informed but always creative."""
 # ──────────────────────────────────────────────────────────────────
 # Injected prompts - content added to the agent's context on activation.
 # 'before' loads before the agent's core instructions.
-# 'after' loads after the agent's core instructions.
 # ──────────────────────────────────────────────────────────────────
 [inject]
 before = ""
-after = ""

src/bmm-skills/2-plan-workflows/bmad-agent-ux-designer/scripts/resolve-customization.py

@@ -21,7 +21,6 @@ from __future__ import annotations
 
 import argparse
 import json
-import os
 import sys
 import tomllib
 from pathlib import Path
@@ -57,19 +56,21 @@ def load_toml(path: Path) -> dict[str, Any]:
 # ---------------------------------------------------------------------------
 
 def _is_menu_array(value: Any) -> bool:
-    """True when *value* looks like a ``[[menu]]`` array of tables with ``code`` keys."""
+    """True when *value* is a non-empty list where ALL items are dicts with a ``code`` key."""
     return (
         isinstance(value, list)
         and len(value) > 0
-        and isinstance(value[0], dict)
+        and all(isinstance(item, dict) and "code" in item for item in value)
-        and "code" in value[0]
     )
 
 
 def merge_menu(base: list[dict], override: list[dict]) -> list[dict]:
     """Merge-by-code: matching codes replace; new codes append."""
-    result_by_code: dict[str, dict] = {item["code"]: dict(item) for item in base}
+    result_by_code: dict[str, dict] = {item["code"]: dict(item) for item in base if "code" in item}
     for item in override:
+        if "code" not in item:
+            print(f"warning: menu item missing 'code' key, skipping: {item}", file=sys.stderr)
+            continue
         result_by_code[item["code"]] = dict(item)
     return list(result_by_code.values())
 

src/bmm-skills/2-plan-workflows/bmad-create-prd/scripts/resolve-customization.py

@@ -21,7 +21,6 @@ from __future__ import annotations
 
 import argparse
 import json
-import os
 import sys
 import tomllib
 from pathlib import Path
@@ -57,19 +56,21 @@ def load_toml(path: Path) -> dict[str, Any]:
 # ---------------------------------------------------------------------------
 
 def _is_menu_array(value: Any) -> bool:
-    """True when *value* looks like a ``[[menu]]`` array of tables with ``code`` keys."""
+    """True when *value* is a non-empty list where ALL items are dicts with a ``code`` key."""
     return (
         isinstance(value, list)
         and len(value) > 0
-        and isinstance(value[0], dict)
+        and all(isinstance(item, dict) and "code" in item for item in value)
-        and "code" in value[0]
     )
 
 
 def merge_menu(base: list[dict], override: list[dict]) -> list[dict]:
     """Merge-by-code: matching codes replace; new codes append."""
-    result_by_code: dict[str, dict] = {item["code"]: dict(item) for item in base}
+    result_by_code: dict[str, dict] = {item["code"]: dict(item) for item in base if "code" in item}
     for item in override:
+        if "code" not in item:
+            print(f"warning: menu item missing 'code' key, skipping: {item}", file=sys.stderr)
+            continue
         result_by_code[item["code"]] = dict(item)
     return list(result_by_code.values())
 

src/bmm-skills/2-plan-workflows/bmad-create-ux-design/scripts/resolve-customization.py

@@ -21,7 +21,6 @@ from __future__ import annotations
 
 import argparse
 import json
-import os
 import sys
 import tomllib
 from pathlib import Path
@@ -57,19 +56,21 @@ def load_toml(path: Path) -> dict[str, Any]:
 # ---------------------------------------------------------------------------
 
 def _is_menu_array(value: Any) -> bool:
-    """True when *value* looks like a ``[[menu]]`` array of tables with ``code`` keys."""
+    """True when *value* is a non-empty list where ALL items are dicts with a ``code`` key."""
     return (
         isinstance(value, list)
         and len(value) > 0
-        and isinstance(value[0], dict)
+        and all(isinstance(item, dict) and "code" in item for item in value)
-        and "code" in value[0]
     )
 
 
 def merge_menu(base: list[dict], override: list[dict]) -> list[dict]:
     """Merge-by-code: matching codes replace; new codes append."""
-    result_by_code: dict[str, dict] = {item["code"]: dict(item) for item in base}
+    result_by_code: dict[str, dict] = {item["code"]: dict(item) for item in base if "code" in item}
     for item in override:
+        if "code" not in item:
+            print(f"warning: menu item missing 'code' key, skipping: {item}", file=sys.stderr)
+            continue
         result_by_code[item["code"]] = dict(item)
     return list(result_by_code.values())
 

src/bmm-skills/2-plan-workflows/bmad-edit-prd/scripts/resolve-customization.py

@@ -21,7 +21,6 @@ from __future__ import annotations
 
 import argparse
 import json
-import os
 import sys
 import tomllib
 from pathlib import Path
@@ -57,19 +56,21 @@ def load_toml(path: Path) -> dict[str, Any]:
 # ---------------------------------------------------------------------------
 
 def _is_menu_array(value: Any) -> bool:
-    """True when *value* looks like a ``[[menu]]`` array of tables with ``code`` keys."""
+    """True when *value* is a non-empty list where ALL items are dicts with a ``code`` key."""
     return (
         isinstance(value, list)
         and len(value) > 0
-        and isinstance(value[0], dict)
+        and all(isinstance(item, dict) and "code" in item for item in value)
-        and "code" in value[0]
     )
 
 
 def merge_menu(base: list[dict], override: list[dict]) -> list[dict]:
     """Merge-by-code: matching codes replace; new codes append."""
-    result_by_code: dict[str, dict] = {item["code"]: dict(item) for item in base}
+    result_by_code: dict[str, dict] = {item["code"]: dict(item) for item in base if "code" in item}
     for item in override:
+        if "code" not in item:
+            print(f"warning: menu item missing 'code' key, skipping: {item}", file=sys.stderr)
+            continue
         result_by_code[item["code"]] = dict(item)
     return list(result_by_code.values())
 

src/bmm-skills/2-plan-workflows/bmad-validate-prd/scripts/resolve-customization.py

@@ -21,7 +21,6 @@ from __future__ import annotations
 
 import argparse
 import json
-import os
 import sys
 import tomllib
 from pathlib import Path
@@ -57,19 +56,21 @@ def load_toml(path: Path) -> dict[str, Any]:
 # ---------------------------------------------------------------------------
 
 def _is_menu_array(value: Any) -> bool:
-    """True when *value* looks like a ``[[menu]]`` array of tables with ``code`` keys."""
+    """True when *value* is a non-empty list where ALL items are dicts with a ``code`` key."""
     return (
         isinstance(value, list)
         and len(value) > 0
-        and isinstance(value[0], dict)
+        and all(isinstance(item, dict) and "code" in item for item in value)
-        and "code" in value[0]
     )
 
 
 def merge_menu(base: list[dict], override: list[dict]) -> list[dict]:
     """Merge-by-code: matching codes replace; new codes append."""
-    result_by_code: dict[str, dict] = {item["code"]: dict(item) for item in base}
+    result_by_code: dict[str, dict] = {item["code"]: dict(item) for item in base if "code" in item}
     for item in override:
+        if "code" not in item:
+            print(f"warning: menu item missing 'code' key, skipping: {item}", file=sys.stderr)
+            continue
         result_by_code[item["code"]] = dict(item)
     return list(result_by_code.values())
 

src/bmm-skills/3-solutioning/bmad-agent-architect/SKILL.md

@@ -24,8 +24,6 @@ Use the JSON output as resolved values.
    incorporate its content as high-priority context.
 3. **Load resources** -- If `additional_resources` is not empty, read
    each listed file and incorporate as reference context.
-4. **Inject after** -- If `inject.after` is not empty, read and
-   incorporate its content as supplementary context.
 
 You must fully embody this persona so the user gets the best experience and help they need. Do not break character until the user dismisses this persona. When the user calls a skill, this persona must carry through and remain active.
 

src/bmm-skills/3-solutioning/bmad-agent-architect/customize.toml

@@ -77,8 +77,6 @@ impact."""
 # ──────────────────────────────────────────────────────────────────
 # Injected prompts - content added to the agent's context on activation.
 # 'before' loads before the agent's core instructions.
-# 'after' loads after the agent's core instructions.
 # ──────────────────────────────────────────────────────────────────
 [inject]
 before = ""
-after = ""

src/bmm-skills/3-solutioning/bmad-agent-architect/scripts/resolve-customization.py

@@ -21,7 +21,6 @@ from __future__ import annotations
 
 import argparse
 import json
-import os
 import sys
 import tomllib
 from pathlib import Path
@@ -57,19 +56,21 @@ def load_toml(path: Path) -> dict[str, Any]:
 # ---------------------------------------------------------------------------
 
 def _is_menu_array(value: Any) -> bool:
-    """True when *value* looks like a ``[[menu]]`` array of tables with ``code`` keys."""
+    """True when *value* is a non-empty list where ALL items are dicts with a ``code`` key."""
     return (
         isinstance(value, list)
         and len(value) > 0
-        and isinstance(value[0], dict)
+        and all(isinstance(item, dict) and "code" in item for item in value)
-        and "code" in value[0]
     )
 
 
 def merge_menu(base: list[dict], override: list[dict]) -> list[dict]:
     """Merge-by-code: matching codes replace; new codes append."""
-    result_by_code: dict[str, dict] = {item["code"]: dict(item) for item in base}
+    result_by_code: dict[str, dict] = {item["code"]: dict(item) for item in base if "code" in item}
     for item in override:
+        if "code" not in item:
+            print(f"warning: menu item missing 'code' key, skipping: {item}", file=sys.stderr)
+            continue
         result_by_code[item["code"]] = dict(item)
     return list(result_by_code.values())
 

src/bmm-skills/3-solutioning/bmad-check-implementation-readiness/scripts/resolve-customization.py

@@ -21,7 +21,6 @@ from __future__ import annotations
 
 import argparse
 import json
-import os
 import sys
 import tomllib
 from pathlib import Path
@@ -57,19 +56,21 @@ def load_toml(path: Path) -> dict[str, Any]:
 # ---------------------------------------------------------------------------
 
 def _is_menu_array(value: Any) -> bool:
-    """True when *value* looks like a ``[[menu]]`` array of tables with ``code`` keys."""
+    """True when *value* is a non-empty list where ALL items are dicts with a ``code`` key."""
     return (
         isinstance(value, list)
         and len(value) > 0
-        and isinstance(value[0], dict)
+        and all(isinstance(item, dict) and "code" in item for item in value)
-        and "code" in value[0]
     )
 
 
 def merge_menu(base: list[dict], override: list[dict]) -> list[dict]:
     """Merge-by-code: matching codes replace; new codes append."""
-    result_by_code: dict[str, dict] = {item["code"]: dict(item) for item in base}
+    result_by_code: dict[str, dict] = {item["code"]: dict(item) for item in base if "code" in item}
     for item in override:
+        if "code" not in item:
+            print(f"warning: menu item missing 'code' key, skipping: {item}", file=sys.stderr)
+            continue
         result_by_code[item["code"]] = dict(item)
     return list(result_by_code.values())
 

src/bmm-skills/3-solutioning/bmad-create-architecture/scripts/resolve-customization.py

@@ -21,7 +21,6 @@ from __future__ import annotations
 
 import argparse
 import json
-import os
 import sys
 import tomllib
 from pathlib import Path
@@ -57,19 +56,21 @@ def load_toml(path: Path) -> dict[str, Any]:
 # ---------------------------------------------------------------------------
 
 def _is_menu_array(value: Any) -> bool:
-    """True when *value* looks like a ``[[menu]]`` array of tables with ``code`` keys."""
+    """True when *value* is a non-empty list where ALL items are dicts with a ``code`` key."""
     return (
         isinstance(value, list)
         and len(value) > 0
-        and isinstance(value[0], dict)
+        and all(isinstance(item, dict) and "code" in item for item in value)
-        and "code" in value[0]
     )
 
 
 def merge_menu(base: list[dict], override: list[dict]) -> list[dict]:
     """Merge-by-code: matching codes replace; new codes append."""
-    result_by_code: dict[str, dict] = {item["code"]: dict(item) for item in base}
+    result_by_code: dict[str, dict] = {item["code"]: dict(item) for item in base if "code" in item}
     for item in override:
+        if "code" not in item:
+            print(f"warning: menu item missing 'code' key, skipping: {item}", file=sys.stderr)
+            continue
         result_by_code[item["code"]] = dict(item)
     return list(result_by_code.values())
 

src/bmm-skills/3-solutioning/bmad-create-epics-and-stories/scripts/resolve-customization.py

@@ -21,7 +21,6 @@ from __future__ import annotations
 
 import argparse
 import json
-import os
 import sys
 import tomllib
 from pathlib import Path
@@ -57,19 +56,21 @@ def load_toml(path: Path) -> dict[str, Any]:
 # ---------------------------------------------------------------------------
 
 def _is_menu_array(value: Any) -> bool:
-    """True when *value* looks like a ``[[menu]]`` array of tables with ``code`` keys."""
+    """True when *value* is a non-empty list where ALL items are dicts with a ``code`` key."""
     return (
         isinstance(value, list)
         and len(value) > 0
-        and isinstance(value[0], dict)
+        and all(isinstance(item, dict) and "code" in item for item in value)
-        and "code" in value[0]
     )
 
 
 def merge_menu(base: list[dict], override: list[dict]) -> list[dict]:
     """Merge-by-code: matching codes replace; new codes append."""
-    result_by_code: dict[str, dict] = {item["code"]: dict(item) for item in base}
+    result_by_code: dict[str, dict] = {item["code"]: dict(item) for item in base if "code" in item}
     for item in override:
+        if "code" not in item:
+            print(f"warning: menu item missing 'code' key, skipping: {item}", file=sys.stderr)
+            continue
         result_by_code[item["code"]] = dict(item)
     return list(result_by_code.values())
 

src/bmm-skills/3-solutioning/bmad-generate-project-context/scripts/resolve-customization.py

@@ -21,7 +21,6 @@ from __future__ import annotations
 
 import argparse
 import json
-import os
 import sys
 import tomllib
 from pathlib import Path
@@ -57,19 +56,21 @@ def load_toml(path: Path) -> dict[str, Any]:
 # ---------------------------------------------------------------------------
 
 def _is_menu_array(value: Any) -> bool:
-    """True when *value* looks like a ``[[menu]]`` array of tables with ``code`` keys."""
+    """True when *value* is a non-empty list where ALL items are dicts with a ``code`` key."""
     return (
         isinstance(value, list)
         and len(value) > 0
-        and isinstance(value[0], dict)
+        and all(isinstance(item, dict) and "code" in item for item in value)
-        and "code" in value[0]
     )
 
 
 def merge_menu(base: list[dict], override: list[dict]) -> list[dict]:
     """Merge-by-code: matching codes replace; new codes append."""
-    result_by_code: dict[str, dict] = {item["code"]: dict(item) for item in base}
+    result_by_code: dict[str, dict] = {item["code"]: dict(item) for item in base if "code" in item}
     for item in override:
+        if "code" not in item:
+            print(f"warning: menu item missing 'code' key, skipping: {item}", file=sys.stderr)
+            continue
         result_by_code[item["code"]] = dict(item)
     return list(result_by_code.values())
 

src/bmm-skills/4-implementation/bmad-agent-dev/SKILL.md

@@ -24,8 +24,6 @@ Use the JSON output as resolved values.
    incorporate its content as high-priority context.
 3. **Load resources** -- If `additional_resources` is not empty, read
    each listed file and incorporate as reference context.
-4. **Inject after** -- If `inject.after` is not empty, read and
-   incorporate its content as supplementary context.
 
 You must fully embody this persona so the user gets the best experience and help they need. Do not break character until the user dismisses this persona. When the user calls a skill, this persona must carry through and remain active.
 

src/bmm-skills/4-implementation/bmad-agent-dev/customize.toml

@@ -72,8 +72,6 @@ unit tests before marking an item complete."""
 # ──────────────────────────────────────────────────────────────────
 # Injected prompts - content added to the agent's context on activation.
 # 'before' loads before the agent's core instructions.
-# 'after' loads after the agent's core instructions.
 # ──────────────────────────────────────────────────────────────────
 [inject]
 before = ""
-after = ""

src/bmm-skills/4-implementation/bmad-agent-dev/scripts/resolve-customization.py

@@ -21,7 +21,6 @@ from __future__ import annotations
 
 import argparse
 import json
-import os
 import sys
 import tomllib
 from pathlib import Path
@@ -57,19 +56,21 @@ def load_toml(path: Path) -> dict[str, Any]:
 # ---------------------------------------------------------------------------
 
 def _is_menu_array(value: Any) -> bool:
-    """True when *value* looks like a ``[[menu]]`` array of tables with ``code`` keys."""
+    """True when *value* is a non-empty list where ALL items are dicts with a ``code`` key."""
     return (
         isinstance(value, list)
         and len(value) > 0
-        and isinstance(value[0], dict)
+        and all(isinstance(item, dict) and "code" in item for item in value)
-        and "code" in value[0]
     )
 
 
 def merge_menu(base: list[dict], override: list[dict]) -> list[dict]:
     """Merge-by-code: matching codes replace; new codes append."""
-    result_by_code: dict[str, dict] = {item["code"]: dict(item) for item in base}
+    result_by_code: dict[str, dict] = {item["code"]: dict(item) for item in base if "code" in item}
     for item in override:
+        if "code" not in item:
+            print(f"warning: menu item missing 'code' key, skipping: {item}", file=sys.stderr)
+            continue
         result_by_code[item["code"]] = dict(item)
     return list(result_by_code.values())
 

src/bmm-skills/4-implementation/bmad-checkpoint-preview/scripts/resolve-customization.py

@@ -21,7 +21,6 @@ from __future__ import annotations
 
 import argparse
 import json
-import os
 import sys
 import tomllib
 from pathlib import Path
@@ -57,19 +56,21 @@ def load_toml(path: Path) -> dict[str, Any]:
 # ---------------------------------------------------------------------------
 
 def _is_menu_array(value: Any) -> bool:
-    """True when *value* looks like a ``[[menu]]`` array of tables with ``code`` keys."""
+    """True when *value* is a non-empty list where ALL items are dicts with a ``code`` key."""
     return (
         isinstance(value, list)
         and len(value) > 0
-        and isinstance(value[0], dict)
+        and all(isinstance(item, dict) and "code" in item for item in value)
-        and "code" in value[0]
     )
 
 
 def merge_menu(base: list[dict], override: list[dict]) -> list[dict]:
     """Merge-by-code: matching codes replace; new codes append."""
-    result_by_code: dict[str, dict] = {item["code"]: dict(item) for item in base}
+    result_by_code: dict[str, dict] = {item["code"]: dict(item) for item in base if "code" in item}
     for item in override:
+        if "code" not in item:
+            print(f"warning: menu item missing 'code' key, skipping: {item}", file=sys.stderr)
+            continue
         result_by_code[item["code"]] = dict(item)
     return list(result_by_code.values())
 

src/bmm-skills/4-implementation/bmad-code-review/scripts/resolve-customization.py

@@ -21,7 +21,6 @@ from __future__ import annotations
 
 import argparse
 import json
-import os
 import sys
 import tomllib
 from pathlib import Path
@@ -57,19 +56,21 @@ def load_toml(path: Path) -> dict[str, Any]:
 # ---------------------------------------------------------------------------
 
 def _is_menu_array(value: Any) -> bool:
-    """True when *value* looks like a ``[[menu]]`` array of tables with ``code`` keys."""
+    """True when *value* is a non-empty list where ALL items are dicts with a ``code`` key."""
     return (
         isinstance(value, list)
         and len(value) > 0
-        and isinstance(value[0], dict)
+        and all(isinstance(item, dict) and "code" in item for item in value)
-        and "code" in value[0]
     )
 
 
 def merge_menu(base: list[dict], override: list[dict]) -> list[dict]:
     """Merge-by-code: matching codes replace; new codes append."""
-    result_by_code: dict[str, dict] = {item["code"]: dict(item) for item in base}
+    result_by_code: dict[str, dict] = {item["code"]: dict(item) for item in base if "code" in item}
     for item in override:
+        if "code" not in item:
+            print(f"warning: menu item missing 'code' key, skipping: {item}", file=sys.stderr)
+            continue
         result_by_code[item["code"]] = dict(item)
     return list(result_by_code.values())
 

src/bmm-skills/4-implementation/bmad-correct-course/scripts/resolve-customization.py

@@ -21,7 +21,6 @@ from __future__ import annotations
 
 import argparse
 import json
-import os
 import sys
 import tomllib
 from pathlib import Path
@@ -57,19 +56,21 @@ def load_toml(path: Path) -> dict[str, Any]:
 # ---------------------------------------------------------------------------
 
 def _is_menu_array(value: Any) -> bool:
-    """True when *value* looks like a ``[[menu]]`` array of tables with ``code`` keys."""
+    """True when *value* is a non-empty list where ALL items are dicts with a ``code`` key."""
     return (
         isinstance(value, list)
         and len(value) > 0
-        and isinstance(value[0], dict)
+        and all(isinstance(item, dict) and "code" in item for item in value)
-        and "code" in value[0]
     )
 
 
 def merge_menu(base: list[dict], override: list[dict]) -> list[dict]:
     """Merge-by-code: matching codes replace; new codes append."""
-    result_by_code: dict[str, dict] = {item["code"]: dict(item) for item in base}
+    result_by_code: dict[str, dict] = {item["code"]: dict(item) for item in base if "code" in item}
     for item in override:
+        if "code" not in item:
+            print(f"warning: menu item missing 'code' key, skipping: {item}", file=sys.stderr)
+            continue
         result_by_code[item["code"]] = dict(item)
     return list(result_by_code.values())
 

src/bmm-skills/4-implementation/bmad-create-story/scripts/resolve-customization.py

@@ -21,7 +21,6 @@ from __future__ import annotations
 
 import argparse
 import json
-import os
 import sys
 import tomllib
 from pathlib import Path
@@ -57,19 +56,21 @@ def load_toml(path: Path) -> dict[str, Any]:
 # ---------------------------------------------------------------------------
 
 def _is_menu_array(value: Any) -> bool:
-    """True when *value* looks like a ``[[menu]]`` array of tables with ``code`` keys."""
+    """True when *value* is a non-empty list where ALL items are dicts with a ``code`` key."""
     return (
         isinstance(value, list)
         and len(value) > 0
-        and isinstance(value[0], dict)
+        and all(isinstance(item, dict) and "code" in item for item in value)
-        and "code" in value[0]
     )
 
 
 def merge_menu(base: list[dict], override: list[dict]) -> list[dict]:
     """Merge-by-code: matching codes replace; new codes append."""
-    result_by_code: dict[str, dict] = {item["code"]: dict(item) for item in base}
+    result_by_code: dict[str, dict] = {item["code"]: dict(item) for item in base if "code" in item}
     for item in override:
+        if "code" not in item:
+            print(f"warning: menu item missing 'code' key, skipping: {item}", file=sys.stderr)
+            continue
         result_by_code[item["code"]] = dict(item)
     return list(result_by_code.values())
 

src/bmm-skills/4-implementation/bmad-dev-story/scripts/resolve-customization.py

@@ -21,7 +21,6 @@ from __future__ import annotations
 
 import argparse
 import json
-import os
 import sys
 import tomllib
 from pathlib import Path
@@ -57,19 +56,21 @@ def load_toml(path: Path) -> dict[str, Any]:
 # ---------------------------------------------------------------------------
 
 def _is_menu_array(value: Any) -> bool:
-    """True when *value* looks like a ``[[menu]]`` array of tables with ``code`` keys."""
+    """True when *value* is a non-empty list where ALL items are dicts with a ``code`` key."""
     return (
         isinstance(value, list)
         and len(value) > 0
-        and isinstance(value[0], dict)
+        and all(isinstance(item, dict) and "code" in item for item in value)
-        and "code" in value[0]
     )
 
 
 def merge_menu(base: list[dict], override: list[dict]) -> list[dict]:
     """Merge-by-code: matching codes replace; new codes append."""
-    result_by_code: dict[str, dict] = {item["code"]: dict(item) for item in base}
+    result_by_code: dict[str, dict] = {item["code"]: dict(item) for item in base if "code" in item}
     for item in override:
+        if "code" not in item:
+            print(f"warning: menu item missing 'code' key, skipping: {item}", file=sys.stderr)
+            continue
         result_by_code[item["code"]] = dict(item)
     return list(result_by_code.values())
 

src/bmm-skills/4-implementation/bmad-qa-generate-e2e-tests/scripts/resolve-customization.py

@@ -21,7 +21,6 @@ from __future__ import annotations
 
 import argparse
 import json
-import os
 import sys
 import tomllib
 from pathlib import Path
@@ -57,19 +56,21 @@ def load_toml(path: Path) -> dict[str, Any]:
 # ---------------------------------------------------------------------------
 
 def _is_menu_array(value: Any) -> bool:
-    """True when *value* looks like a ``[[menu]]`` array of tables with ``code`` keys."""
+    """True when *value* is a non-empty list where ALL items are dicts with a ``code`` key."""
     return (
         isinstance(value, list)
         and len(value) > 0
-        and isinstance(value[0], dict)
+        and all(isinstance(item, dict) and "code" in item for item in value)
-        and "code" in value[0]
     )
 
 
 def merge_menu(base: list[dict], override: list[dict]) -> list[dict]:
     """Merge-by-code: matching codes replace; new codes append."""
-    result_by_code: dict[str, dict] = {item["code"]: dict(item) for item in base}
+    result_by_code: dict[str, dict] = {item["code"]: dict(item) for item in base if "code" in item}
     for item in override:
+        if "code" not in item:
+            print(f"warning: menu item missing 'code' key, skipping: {item}", file=sys.stderr)
+            continue
         result_by_code[item["code"]] = dict(item)
     return list(result_by_code.values())
 

src/bmm-skills/4-implementation/bmad-quick-dev/scripts/resolve-customization.py

@@ -21,7 +21,6 @@ from __future__ import annotations
 
 import argparse
 import json
-import os
 import sys
 import tomllib
 from pathlib import Path
@@ -57,19 +56,21 @@ def load_toml(path: Path) -> dict[str, Any]:
 # ---------------------------------------------------------------------------
 
 def _is_menu_array(value: Any) -> bool:
-    """True when *value* looks like a ``[[menu]]`` array of tables with ``code`` keys."""
+    """True when *value* is a non-empty list where ALL items are dicts with a ``code`` key."""
     return (
         isinstance(value, list)
         and len(value) > 0
-        and isinstance(value[0], dict)
+        and all(isinstance(item, dict) and "code" in item for item in value)
-        and "code" in value[0]
     )
 
 
 def merge_menu(base: list[dict], override: list[dict]) -> list[dict]:
     """Merge-by-code: matching codes replace; new codes append."""
-    result_by_code: dict[str, dict] = {item["code"]: dict(item) for item in base}
+    result_by_code: dict[str, dict] = {item["code"]: dict(item) for item in base if "code" in item}
     for item in override:
+        if "code" not in item:
+            print(f"warning: menu item missing 'code' key, skipping: {item}", file=sys.stderr)
+            continue
         result_by_code[item["code"]] = dict(item)
     return list(result_by_code.values())
 

src/bmm-skills/4-implementation/bmad-retrospective/scripts/resolve-customization.py

@@ -21,7 +21,6 @@ from __future__ import annotations
 
 import argparse
 import json
-import os
 import sys
 import tomllib
 from pathlib import Path
@@ -57,19 +56,21 @@ def load_toml(path: Path) -> dict[str, Any]:
 # ---------------------------------------------------------------------------
 
 def _is_menu_array(value: Any) -> bool:
-    """True when *value* looks like a ``[[menu]]`` array of tables with ``code`` keys."""
+    """True when *value* is a non-empty list where ALL items are dicts with a ``code`` key."""
     return (
         isinstance(value, list)
         and len(value) > 0
-        and isinstance(value[0], dict)
+        and all(isinstance(item, dict) and "code" in item for item in value)
-        and "code" in value[0]
     )
 
 
 def merge_menu(base: list[dict], override: list[dict]) -> list[dict]:
     """Merge-by-code: matching codes replace; new codes append."""
-    result_by_code: dict[str, dict] = {item["code"]: dict(item) for item in base}
+    result_by_code: dict[str, dict] = {item["code"]: dict(item) for item in base if "code" in item}
     for item in override:
+        if "code" not in item:
+            print(f"warning: menu item missing 'code' key, skipping: {item}", file=sys.stderr)
+            continue
         result_by_code[item["code"]] = dict(item)
     return list(result_by_code.values())
 

src/bmm-skills/4-implementation/bmad-sprint-planning/scripts/resolve-customization.py

@@ -21,7 +21,6 @@ from __future__ import annotations
 
 import argparse
 import json
-import os
 import sys
 import tomllib
 from pathlib import Path
@@ -57,19 +56,21 @@ def load_toml(path: Path) -> dict[str, Any]:
 # ---------------------------------------------------------------------------
 
 def _is_menu_array(value: Any) -> bool:
-    """True when *value* looks like a ``[[menu]]`` array of tables with ``code`` keys."""
+    """True when *value* is a non-empty list where ALL items are dicts with a ``code`` key."""
     return (
         isinstance(value, list)
         and len(value) > 0
-        and isinstance(value[0], dict)
+        and all(isinstance(item, dict) and "code" in item for item in value)
-        and "code" in value[0]
     )
 
 
 def merge_menu(base: list[dict], override: list[dict]) -> list[dict]:
     """Merge-by-code: matching codes replace; new codes append."""
-    result_by_code: dict[str, dict] = {item["code"]: dict(item) for item in base}
+    result_by_code: dict[str, dict] = {item["code"]: dict(item) for item in base if "code" in item}
     for item in override:
+        if "code" not in item:
+            print(f"warning: menu item missing 'code' key, skipping: {item}", file=sys.stderr)
+            continue
         result_by_code[item["code"]] = dict(item)
     return list(result_by_code.values())
 

src/bmm-skills/4-implementation/bmad-sprint-status/scripts/resolve-customization.py

@@ -21,7 +21,6 @@ from __future__ import annotations
 
 import argparse
 import json
-import os
 import sys
 import tomllib
 from pathlib import Path
@@ -57,19 +56,21 @@ def load_toml(path: Path) -> dict[str, Any]:
 # ---------------------------------------------------------------------------
 
 def _is_menu_array(value: Any) -> bool:
-    """True when *value* looks like a ``[[menu]]`` array of tables with ``code`` keys."""
+    """True when *value* is a non-empty list where ALL items are dicts with a ``code`` key."""
     return (
         isinstance(value, list)
         and len(value) > 0
-        and isinstance(value[0], dict)
+        and all(isinstance(item, dict) and "code" in item for item in value)
-        and "code" in value[0]
     )
 
 
 def merge_menu(base: list[dict], override: list[dict]) -> list[dict]:
     """Merge-by-code: matching codes replace; new codes append."""
-    result_by_code: dict[str, dict] = {item["code"]: dict(item) for item in base}
+    result_by_code: dict[str, dict] = {item["code"]: dict(item) for item in base if "code" in item}
     for item in override:
+        if "code" not in item:
+            print(f"warning: menu item missing 'code' key, skipping: {item}", file=sys.stderr)
+            continue
         result_by_code[item["code"]] = dict(item)
     return list(result_by_code.values())
 

src/bmm-skills/_shared/scripts/resolve-customization.py

@@ -21,7 +21,6 @@ from __future__ import annotations
 
 import argparse
 import json
-import os
 import sys
 import tomllib
 from pathlib import Path
@@ -57,19 +56,21 @@ def load_toml(path: Path) -> dict[str, Any]:
 # ---------------------------------------------------------------------------
 
 def _is_menu_array(value: Any) -> bool:
-    """True when *value* looks like a ``[[menu]]`` array of tables with ``code`` keys."""
+    """True when *value* is a non-empty list where ALL items are dicts with a ``code`` key."""
     return (
         isinstance(value, list)
         and len(value) > 0
-        and isinstance(value[0], dict)
+        and all(isinstance(item, dict) and "code" in item for item in value)
-        and "code" in value[0]
     )
 
 
 def merge_menu(base: list[dict], override: list[dict]) -> list[dict]:
     """Merge-by-code: matching codes replace; new codes append."""
-    result_by_code: dict[str, dict] = {item["code"]: dict(item) for item in base}
+    result_by_code: dict[str, dict] = {item["code"]: dict(item) for item in base if "code" in item}
     for item in override:
+        if "code" not in item:
+            print(f"warning: menu item missing 'code' key, skipping: {item}", file=sys.stderr)
+            continue
         result_by_code[item["code"]] = dict(item)
     return list(result_by_code.values())
 

src/core-skills/bmad-advanced-elicitation/scripts/resolve-customization.py

@@ -21,7 +21,6 @@ from __future__ import annotations
 
 import argparse
 import json
-import os
 import sys
 import tomllib
 from pathlib import Path
@@ -57,19 +56,21 @@ def load_toml(path: Path) -> dict[str, Any]:
 # ---------------------------------------------------------------------------
 
 def _is_menu_array(value: Any) -> bool:
-    """True when *value* looks like a ``[[menu]]`` array of tables with ``code`` keys."""
+    """True when *value* is a non-empty list where ALL items are dicts with a ``code`` key."""
     return (
         isinstance(value, list)
         and len(value) > 0
-        and isinstance(value[0], dict)
+        and all(isinstance(item, dict) and "code" in item for item in value)
-        and "code" in value[0]
     )
 
 
 def merge_menu(base: list[dict], override: list[dict]) -> list[dict]:
     """Merge-by-code: matching codes replace; new codes append."""
-    result_by_code: dict[str, dict] = {item["code"]: dict(item) for item in base}
+    result_by_code: dict[str, dict] = {item["code"]: dict(item) for item in base if "code" in item}
     for item in override:
+        if "code" not in item:
+            print(f"warning: menu item missing 'code' key, skipping: {item}", file=sys.stderr)
+            continue
         result_by_code[item["code"]] = dict(item)
     return list(result_by_code.values())
 

src/core-skills/bmad-brainstorming/scripts/resolve-customization.py

@@ -21,7 +21,6 @@ from __future__ import annotations
 
 import argparse
 import json
-import os
 import sys
 import tomllib
 from pathlib import Path
@@ -57,19 +56,21 @@ def load_toml(path: Path) -> dict[str, Any]:
 # ---------------------------------------------------------------------------
 
 def _is_menu_array(value: Any) -> bool:
-    """True when *value* looks like a ``[[menu]]`` array of tables with ``code`` keys."""
+    """True when *value* is a non-empty list where ALL items are dicts with a ``code`` key."""
     return (
         isinstance(value, list)
         and len(value) > 0
-        and isinstance(value[0], dict)
+        and all(isinstance(item, dict) and "code" in item for item in value)
-        and "code" in value[0]
     )
 
 
 def merge_menu(base: list[dict], override: list[dict]) -> list[dict]:
     """Merge-by-code: matching codes replace; new codes append."""
-    result_by_code: dict[str, dict] = {item["code"]: dict(item) for item in base}
+    result_by_code: dict[str, dict] = {item["code"]: dict(item) for item in base if "code" in item}
     for item in override:
+        if "code" not in item:
+            print(f"warning: menu item missing 'code' key, skipping: {item}", file=sys.stderr)
+            continue
         result_by_code[item["code"]] = dict(item)
     return list(result_by_code.values())
 

src/core-skills/bmad-distillator/scripts/resolve-customization.py

@@ -21,7 +21,6 @@ from __future__ import annotations
 
 import argparse
 import json
-import os
 import sys
 import tomllib
 from pathlib import Path
@@ -57,19 +56,21 @@ def load_toml(path: Path) -> dict[str, Any]:
 # ---------------------------------------------------------------------------
 
 def _is_menu_array(value: Any) -> bool:
-    """True when *value* looks like a ``[[menu]]`` array of tables with ``code`` keys."""
+    """True when *value* is a non-empty list where ALL items are dicts with a ``code`` key."""
     return (
         isinstance(value, list)
         and len(value) > 0
-        and isinstance(value[0], dict)
+        and all(isinstance(item, dict) and "code" in item for item in value)
-        and "code" in value[0]
     )
 
 
 def merge_menu(base: list[dict], override: list[dict]) -> list[dict]:
     """Merge-by-code: matching codes replace; new codes append."""
-    result_by_code: dict[str, dict] = {item["code"]: dict(item) for item in base}
+    result_by_code: dict[str, dict] = {item["code"]: dict(item) for item in base if "code" in item}
     for item in override:
+        if "code" not in item:
+            print(f"warning: menu item missing 'code' key, skipping: {item}", file=sys.stderr)
+            continue
         result_by_code[item["code"]] = dict(item)
     return list(result_by_code.values())
 

src/core-skills/bmad-editorial-review-prose/scripts/resolve-customization.py

@@ -21,7 +21,6 @@ from __future__ import annotations
 
 import argparse
 import json
-import os
 import sys
 import tomllib
 from pathlib import Path
@@ -57,19 +56,21 @@ def load_toml(path: Path) -> dict[str, Any]:
 # ---------------------------------------------------------------------------
 
 def _is_menu_array(value: Any) -> bool:
-    """True when *value* looks like a ``[[menu]]`` array of tables with ``code`` keys."""
+    """True when *value* is a non-empty list where ALL items are dicts with a ``code`` key."""
     return (
         isinstance(value, list)
         and len(value) > 0
-        and isinstance(value[0], dict)
+        and all(isinstance(item, dict) and "code" in item for item in value)
-        and "code" in value[0]
     )
 
 
 def merge_menu(base: list[dict], override: list[dict]) -> list[dict]:
     """Merge-by-code: matching codes replace; new codes append."""
-    result_by_code: dict[str, dict] = {item["code"]: dict(item) for item in base}
+    result_by_code: dict[str, dict] = {item["code"]: dict(item) for item in base if "code" in item}
     for item in override:
+        if "code" not in item:
+            print(f"warning: menu item missing 'code' key, skipping: {item}", file=sys.stderr)
+            continue
         result_by_code[item["code"]] = dict(item)
     return list(result_by_code.values())
 

src/core-skills/bmad-editorial-review-structure/scripts/resolve-customization.py

@@ -21,7 +21,6 @@ from __future__ import annotations
 
 import argparse
 import json
-import os
 import sys
 import tomllib
 from pathlib import Path
@@ -57,19 +56,21 @@ def load_toml(path: Path) -> dict[str, Any]:
 # ---------------------------------------------------------------------------
 
 def _is_menu_array(value: Any) -> bool:
-    """True when *value* looks like a ``[[menu]]`` array of tables with ``code`` keys."""
+    """True when *value* is a non-empty list where ALL items are dicts with a ``code`` key."""
     return (
         isinstance(value, list)
         and len(value) > 0
-        and isinstance(value[0], dict)
+        and all(isinstance(item, dict) and "code" in item for item in value)
-        and "code" in value[0]
     )
 
 
 def merge_menu(base: list[dict], override: list[dict]) -> list[dict]:
     """Merge-by-code: matching codes replace; new codes append."""
-    result_by_code: dict[str, dict] = {item["code"]: dict(item) for item in base}
+    result_by_code: dict[str, dict] = {item["code"]: dict(item) for item in base if "code" in item}
     for item in override:
+        if "code" not in item:
+            print(f"warning: menu item missing 'code' key, skipping: {item}", file=sys.stderr)
+            continue
         result_by_code[item["code"]] = dict(item)
     return list(result_by_code.values())
 

src/core-skills/bmad-help/scripts/resolve-customization.py

@@ -21,7 +21,6 @@ from __future__ import annotations
 
 import argparse
 import json
-import os
 import sys
 import tomllib
 from pathlib import Path
@@ -57,19 +56,21 @@ def load_toml(path: Path) -> dict[str, Any]:
 # ---------------------------------------------------------------------------
 
 def _is_menu_array(value: Any) -> bool:
-    """True when *value* looks like a ``[[menu]]`` array of tables with ``code`` keys."""
+    """True when *value* is a non-empty list where ALL items are dicts with a ``code`` key."""
     return (
         isinstance(value, list)
         and len(value) > 0
-        and isinstance(value[0], dict)
+        and all(isinstance(item, dict) and "code" in item for item in value)
-        and "code" in value[0]
     )
 
 
 def merge_menu(base: list[dict], override: list[dict]) -> list[dict]:
     """Merge-by-code: matching codes replace; new codes append."""
-    result_by_code: dict[str, dict] = {item["code"]: dict(item) for item in base}
+    result_by_code: dict[str, dict] = {item["code"]: dict(item) for item in base if "code" in item}
     for item in override:
+        if "code" not in item:
+            print(f"warning: menu item missing 'code' key, skipping: {item}", file=sys.stderr)
+            continue
         result_by_code[item["code"]] = dict(item)
     return list(result_by_code.values())
 

src/core-skills/bmad-index-docs/scripts/resolve-customization.py

@@ -21,7 +21,6 @@ from __future__ import annotations
 
 import argparse
 import json
-import os
 import sys
 import tomllib
 from pathlib import Path
@@ -57,19 +56,21 @@ def load_toml(path: Path) -> dict[str, Any]:
 # ---------------------------------------------------------------------------
 
 def _is_menu_array(value: Any) -> bool:
-    """True when *value* looks like a ``[[menu]]`` array of tables with ``code`` keys."""
+    """True when *value* is a non-empty list where ALL items are dicts with a ``code`` key."""
     return (
         isinstance(value, list)
         and len(value) > 0
-        and isinstance(value[0], dict)
+        and all(isinstance(item, dict) and "code" in item for item in value)
-        and "code" in value[0]
     )
 
 
 def merge_menu(base: list[dict], override: list[dict]) -> list[dict]:
     """Merge-by-code: matching codes replace; new codes append."""
-    result_by_code: dict[str, dict] = {item["code"]: dict(item) for item in base}
+    result_by_code: dict[str, dict] = {item["code"]: dict(item) for item in base if "code" in item}
     for item in override:
+        if "code" not in item:
+            print(f"warning: menu item missing 'code' key, skipping: {item}", file=sys.stderr)
+            continue
         result_by_code[item["code"]] = dict(item)
     return list(result_by_code.values())
 

src/core-skills/bmad-party-mode/scripts/resolve-customization.py

@@ -21,7 +21,6 @@ from __future__ import annotations
 
 import argparse
 import json
-import os
 import sys
 import tomllib
 from pathlib import Path
@@ -57,19 +56,21 @@ def load_toml(path: Path) -> dict[str, Any]:
 # ---------------------------------------------------------------------------
 
 def _is_menu_array(value: Any) -> bool:
-    """True when *value* looks like a ``[[menu]]`` array of tables with ``code`` keys."""
+    """True when *value* is a non-empty list where ALL items are dicts with a ``code`` key."""
     return (
         isinstance(value, list)
         and len(value) > 0
-        and isinstance(value[0], dict)
+        and all(isinstance(item, dict) and "code" in item for item in value)
-        and "code" in value[0]
     )
 
 
 def merge_menu(base: list[dict], override: list[dict]) -> list[dict]:
     """Merge-by-code: matching codes replace; new codes append."""
-    result_by_code: dict[str, dict] = {item["code"]: dict(item) for item in base}
+    result_by_code: dict[str, dict] = {item["code"]: dict(item) for item in base if "code" in item}
     for item in override:
+        if "code" not in item:
+            print(f"warning: menu item missing 'code' key, skipping: {item}", file=sys.stderr)
+            continue
         result_by_code[item["code"]] = dict(item)
     return list(result_by_code.values())
 

src/core-skills/bmad-review-adversarial-general/scripts/resolve-customization.py

@@ -21,7 +21,6 @@ from __future__ import annotations
 
 import argparse
 import json
-import os
 import sys
 import tomllib
 from pathlib import Path
@@ -57,19 +56,21 @@ def load_toml(path: Path) -> dict[str, Any]:
 # ---------------------------------------------------------------------------
 
 def _is_menu_array(value: Any) -> bool:
-    """True when *value* looks like a ``[[menu]]`` array of tables with ``code`` keys."""
+    """True when *value* is a non-empty list where ALL items are dicts with a ``code`` key."""
     return (
         isinstance(value, list)
         and len(value) > 0
-        and isinstance(value[0], dict)
+        and all(isinstance(item, dict) and "code" in item for item in value)
-        and "code" in value[0]
     )
 
 
 def merge_menu(base: list[dict], override: list[dict]) -> list[dict]:
     """Merge-by-code: matching codes replace; new codes append."""
-    result_by_code: dict[str, dict] = {item["code"]: dict(item) for item in base}
+    result_by_code: dict[str, dict] = {item["code"]: dict(item) for item in base if "code" in item}
     for item in override:
+        if "code" not in item:
+            print(f"warning: menu item missing 'code' key, skipping: {item}", file=sys.stderr)
+            continue
         result_by_code[item["code"]] = dict(item)
     return list(result_by_code.values())
 

src/core-skills/bmad-review-edge-case-hunter/scripts/resolve-customization.py

@@ -21,7 +21,6 @@ from __future__ import annotations
 
 import argparse
 import json
-import os
 import sys
 import tomllib
 from pathlib import Path
@@ -57,19 +56,21 @@ def load_toml(path: Path) -> dict[str, Any]:
 # ---------------------------------------------------------------------------
 
 def _is_menu_array(value: Any) -> bool:
-    """True when *value* looks like a ``[[menu]]`` array of tables with ``code`` keys."""
+    """True when *value* is a non-empty list where ALL items are dicts with a ``code`` key."""
     return (
         isinstance(value, list)
         and len(value) > 0
-        and isinstance(value[0], dict)
+        and all(isinstance(item, dict) and "code" in item for item in value)
-        and "code" in value[0]
     )
 
 
 def merge_menu(base: list[dict], override: list[dict]) -> list[dict]:
     """Merge-by-code: matching codes replace; new codes append."""
-    result_by_code: dict[str, dict] = {item["code"]: dict(item) for item in base}
+    result_by_code: dict[str, dict] = {item["code"]: dict(item) for item in base if "code" in item}
     for item in override:
+        if "code" not in item:
+            print(f"warning: menu item missing 'code' key, skipping: {item}", file=sys.stderr)
+            continue
         result_by_code[item["code"]] = dict(item)
     return list(result_by_code.values())
 

src/core-skills/bmad-shard-doc/scripts/resolve-customization.py

@@ -21,7 +21,6 @@ from __future__ import annotations
 
 import argparse
 import json
-import os
 import sys
 import tomllib
 from pathlib import Path
@@ -57,19 +56,21 @@ def load_toml(path: Path) -> dict[str, Any]:
 # ---------------------------------------------------------------------------
 
 def _is_menu_array(value: Any) -> bool:
-    """True when *value* looks like a ``[[menu]]`` array of tables with ``code`` keys."""
+    """True when *value* is a non-empty list where ALL items are dicts with a ``code`` key."""
     return (
         isinstance(value, list)
         and len(value) > 0
-        and isinstance(value[0], dict)
+        and all(isinstance(item, dict) and "code" in item for item in value)
-        and "code" in value[0]
     )
 
 
 def merge_menu(base: list[dict], override: list[dict]) -> list[dict]:
     """Merge-by-code: matching codes replace; new codes append."""
-    result_by_code: dict[str, dict] = {item["code"]: dict(item) for item in base}
+    result_by_code: dict[str, dict] = {item["code"]: dict(item) for item in base if "code" in item}
     for item in override:
+        if "code" not in item:
+            print(f"warning: menu item missing 'code' key, skipping: {item}", file=sys.stderr)
+            continue
         result_by_code[item["code"]] = dict(item)
     return list(result_by_code.values())