From d37898c565f633bdd3b38782b0f252c78c5f8067 Mon Sep 17 00:00:00 2001 From: Brian Madison Date: Mon, 16 Mar 2026 00:03:35 -0500 Subject: [PATCH] fix(installer): suppress canonicalId warning for type:agent skills Agent-type skill manifests legitimately use canonicalId for agent-manifest mapping (e.g., bmad-analyst). Only warn for regular type:skill manifests. Co-Authored-By: Claude Opus 4.6 (1M context) --- tools/cli/installers/lib/core/manifest-generator.js | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tools/cli/installers/lib/core/manifest-generator.js b/tools/cli/installers/lib/core/manifest-generator.js index 544fabdd6..68d0c9eab 100644 --- a/tools/cli/installers/lib/core/manifest-generator.js +++ b/tools/cli/installers/lib/core/manifest-generator.js @@ -191,7 +191,8 @@ class ManifestGenerator { : `${this.bmadFolderName}/${moduleName}/${skillFile}`; // Skills derive canonicalId from directory name — never from manifest - if (manifest && manifest.__single && manifest.__single.canonicalId) { + // (agent-type skills legitimately use canonicalId for agent-manifest mapping, so skip warning) + if (manifest && manifest.__single && manifest.__single.canonicalId && artifactType !== 'agent') { console.warn( `Warning: Skill manifest at ${dir}/bmad-skill-manifest.yaml contains canonicalId — this field is ignored for skills (directory name is the canonical ID)`, );