From d0cf44ad6b0edde81d44b538d5b80a2dc51a0e03 Mon Sep 17 00:00:00 2001
From: Mark Pundsack <319891+markpundsack@users.noreply.github.com>
Date: Wed, 1 Oct 2025 12:08:38 -0500
Subject: [PATCH] fix: correct status terminology to match story template
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Fixes agents setting invalid status values that don't match the
story-tmpl.yaml choices.

**Problem:**
- story-tmpl.yaml defines valid status choices as:
  [Draft, Approved, InProgress, Review, Done]
- dev.md completion instructed to set status: 'Ready for Review'
- apply-qa-fixes.md instructed to set status: 'Ready for Done' or 'Ready for Review'
- These values don't match the valid choices, causing errors

**Solution:**
- dev.md: 'Ready for Review' → 'Review'
- apply-qa-fixes.md: 'Ready for Done' → 'Done', 'Ready for Review' → 'Review'

This ensures agents only set valid status values defined in the story template.
---
 bmad-core/agents/dev.md           | 2 +-
 bmad-core/tasks/apply-qa-fixes.md | 4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/bmad-core/agents/dev.md b/bmad-core/agents/dev.md
index 3b275ab5..6c7827e3 100644
--- a/bmad-core/agents/dev.md
+++ b/bmad-core/agents/dev.md
@@ -65,7 +65,7 @@ commands:
           - CRITICAL: DO NOT modify Status, Story, Acceptance Criteria, Dev Notes, Testing sections, or any other sections not listed above
       - blocking: 'HALT for: Unapproved deps needed, confirm with user | Ambiguous after story check | 3 failures attempting to implement or fix something repeatedly | Missing config | Failing regression'
       - ready-for-review: 'Code matches requirements + All validations pass + Follows standards + File List complete'
-      - completion: "All Tasks and Subtasks marked [x] and have tests→Validations and full regression passes (DON'T BE LAZY, EXECUTE ALL TESTS and CONFIRM)→Ensure File List is Complete→run the task execute-checklist for the checklist story-dod-checklist→set story status: 'Ready for Review'→HALT"
+      - completion: "All Tasks and Subtasks marked [x] and have tests→Validations and full regression passes (DON'T BE LAZY, EXECUTE ALL TESTS and CONFIRM)→Ensure File List is Complete→run the task execute-checklist for the checklist story-dod-checklist→set story status: 'Review'→HALT"
   - explain: teach me what and why you did whatever you just did in detail so I can learn. Explain to me as if you were training a junior engineer.
   - review-qa: run task `apply-qa-fixes.md'
   - run-tests: Execute linting and tests
diff --git a/bmad-core/tasks/apply-qa-fixes.md b/bmad-core/tasks/apply-qa-fixes.md
index 6af3037e..2047d49e 100644
--- a/bmad-core/tasks/apply-qa-fixes.md
+++ b/bmad-core/tasks/apply-qa-fixes.md
@@ -104,8 +104,8 @@ CRITICAL: Dev agent is ONLY authorized to update these sections of the story fil
 
 Status Rule:
 
-- If gate was PASS and all identified gaps are closed → set `Status: Ready for Done`
-- Otherwise → set `Status: Ready for Review` and notify QA to re-run the review
+- If gate was PASS and all identified gaps are closed → set `Status: Done`
+- Otherwise → set `Status: Review` and notify QA to re-run the review
 
 ### 6) Do NOT Edit Gate Files