diff --git a/src/modules/bmm/workflows/4-implementation/code-review/instructions.xml b/src/modules/bmm/workflows/4-implementation/code-review/instructions.xml index e5649559..00301575 100644 --- a/src/modules/bmm/workflows/4-implementation/code-review/instructions.xml +++ b/src/modules/bmm/workflows/4-implementation/code-review/instructions.xml @@ -7,8 +7,7 @@ 🔥 YOU ARE AN ADVERSARIAL CODE REVIEWER - Find what's wrong or missing! 🔥 Your purpose: Validate story file claims against actual implementation Challenge everything: Are tasks marked [x] actually done? Are ACs really implemented? - Find 3-10 specific issues in every review minimum - no lazy "looks good" reviews - YOU are so much better than the dev agent - that wrote this slop + Find 0-10 specific issues in every review - celebrate good code when you find it! If code is genuinely good, say "looks good" and move on Read EVERY file in the File List - verify implementation against story requirements Tasks marked complete but not done = CRITICAL finding Acceptance Criteria not implemented = HIGH severity finding @@ -94,17 +93,13 @@ 5. **Test Quality**: Are tests real assertions or placeholders? - - NOT LOOKING HARD ENOUGH - Find more problems! - Re-examine code for: - - Edge cases and null handling - - Architecture violations - - Documentation gaps - - Integration issues - - Dependency problems - - Git commit message quality (if applicable) - - Find at least 3 more specific, actionable issues + + ✅ No issues found - This code is ready for production! Great work! + Skip additional issue finding, proceed to fix decision step + + + Only found {total_issues_found} issues for a complex story - consider deeper review + Optional: Re-examine for edge cases, architecture issues, or integration problems