diff --git a/src/bmm-skills/4-implementation/bmad-checkpoint-preview/step-02-walkthrough.md b/src/bmm-skills/4-implementation/bmad-checkpoint-preview/step-02-walkthrough.md index b3b818469..e624038e9 100644 --- a/src/bmm-skills/4-implementation/bmad-checkpoint-preview/step-02-walkthrough.md +++ b/src/bmm-skills/4-implementation/bmad-checkpoint-preview/step-02-walkthrough.md @@ -73,12 +73,17 @@ Take your time — click through the stops, read the diff, trace the logic. Whil - "party mode on whether this schema migration is safe" - or just ask anything -When you are done with the walkthrough: -- **"detail pass"** — I'll surface the highest-risk spots and run code review -- **"testing"** — I'll suggest how to observe the behavior -- **"I've seen enough"** — tell me what to do about this {change_type} and we wrap up +When you're ready, say **next** and I'll surface the highest-risk spots. ``` +## EARLY EXIT + +If at any point the human signals they want to make a decision about this {change_type} (e.g., "let's ship it", "this needs a rethink", "I'm done reviewing", or anything suggesting they're ready to decide), confirm their intent: + +- If they want to **approve and ship** → read fully and follow `./step-05-wrapup.md` +- If they want to **reject and rework** → read fully and follow `./step-05-wrapup.md` +- If you misread them → acknowledge and continue the current step. + ## NEXT -When the human signals readiness for the next phase, read fully and follow `./step-03-detail-pass.md` +Default: read fully and follow `./step-03-detail-pass.md` diff --git a/src/bmm-skills/4-implementation/bmad-checkpoint-preview/step-03-detail-pass.md b/src/bmm-skills/4-implementation/bmad-checkpoint-preview/step-03-detail-pass.md index 76e9aea9c..49d8024a4 100644 --- a/src/bmm-skills/4-implementation/bmad-checkpoint-preview/step-03-detail-pass.md +++ b/src/bmm-skills/4-implementation/bmad-checkpoint-preview/step-03-detail-pass.md @@ -76,10 +76,17 @@ End the message with: You've seen the design and the risk landscape. From here: - **"dig into [area]"** — I'll deep-dive that specific area with correctness focus -- **"testing"** — I'll suggest how to observe the behavior -- **"I've seen enough"** — tell me what to do about this {change_type} and we wrap up +- **"next"** — I'll suggest how to observe the behavior ``` +## EARLY EXIT + +If at any point the human signals they want to make a decision about this {change_type} (e.g., "let's ship it", "this needs a rethink", "I'm done reviewing", or anything suggesting they're ready to decide), confirm their intent: + +- If they want to **approve and ship** → read fully and follow `./step-05-wrapup.md` +- If they want to **reject and rework** → read fully and follow `./step-05-wrapup.md` +- If you misread them → acknowledge and continue the current step. + ## TARGETED RE-REVIEW When the human says "dig into [area]" (e.g., "dig into the auth changes", "dig into the schema migration"): @@ -96,4 +103,4 @@ The human can trigger multiple targeted re-reviews. Each time, present new findi ## NEXT -When the human signals readiness for testing, read fully and follow `./step-04-testing.md` +Read fully and follow `./step-04-testing.md` diff --git a/src/bmm-skills/4-implementation/bmad-checkpoint-preview/step-04-testing.md b/src/bmm-skills/4-implementation/bmad-checkpoint-preview/step-04-testing.md index c4e9ae627..f81807998 100644 --- a/src/bmm-skills/4-implementation/bmad-checkpoint-preview/step-04-testing.md +++ b/src/bmm-skills/4-implementation/bmad-checkpoint-preview/step-04-testing.md @@ -66,26 +66,9 @@ End the message with: ``` --- -You've seen the change and how to verify it. From here: -- **"I've seen enough"** — we wrap up this {change_type} -- or just ask anything +You've seen the change and how to verify it. When you're ready to make a call, just say so. ``` -## WRAP-UP +## NEXT -When the human says "I've seen enough" or signals they're done: - -``` ---- - -Review complete. What's the call on this {change_type}? -- **Approve** — ship it -- **Request changes** — I'll help draft feedback -- **Discuss** — something's still on your mind -``` - -Act on their decision: - -- **Approve**: Acknowledge briefly. If reviewing a PR, offer to approve via `gh pr review --approve` — but confirm with the human before executing, since this is a visible action on a shared resource. -- **Request changes**: Ask what needs changing. Help draft specific, actionable feedback tied to `path:line` locations. -- **Discuss**: Open conversation — answer questions, explore concerns, dig into any aspect. +When the human signals they're ready to make a decision about this {change_type}, read fully and follow `./step-05-wrapup.md` diff --git a/src/bmm-skills/4-implementation/bmad-checkpoint-preview/step-05-wrapup.md b/src/bmm-skills/4-implementation/bmad-checkpoint-preview/step-05-wrapup.md new file mode 100644 index 000000000..b3a67b4ee --- /dev/null +++ b/src/bmm-skills/4-implementation/bmad-checkpoint-preview/step-05-wrapup.md @@ -0,0 +1,22 @@ +# Step 5: Wrap-Up + +Display: `Orientation → Walkthrough → Detail Pass → Testing → [Wrap-Up]` + +## Follow Global Step Rules in SKILL.md + +## PROMPT FOR DECISION + +``` +--- + +Review complete. What's the call on this {change_type}? +- **Approve** — ship it (I can help with interactive patching first if needed) +- **Rework** — back to the drawing board (revert, revise the spec, try a different approach) +- **Discuss** — something's still on your mind +``` + +## ACT ON DECISION + +- **Approve**: Acknowledge briefly. If the human wants to patch something before shipping, help apply the fix interactively. If reviewing a PR, offer to approve via `gh pr review --approve` — but confirm with the human before executing, since this is a visible action on a shared resource. +- **Rework**: Ask what went wrong — was it the approach, the spec, or the implementation? Help the human decide on next steps (revert commit, open an issue, revise the spec, etc.). Help draft specific, actionable feedback tied to `path:line` locations if the change is a PR from someone else. +- **Discuss**: Open conversation — answer questions, explore concerns, dig into any aspect. After discussion, return to the decision prompt above.