From bf572f945fe8f4d16409f75f72b8ec507c2af4ba Mon Sep 17 00:00:00 2001
From: Magal <magal@bmad-memtrace.local>
Date: Tue, 19 May 2026 17:51:20 -0300
Subject: [PATCH] fix(quality-gate): switch qa-memtrace to async readFile and
 fix coverage null guard (Story 2.3)
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

- Replace sync readFileSync with async readFile from fs/promises
- Fix blast radius empty check: total_count === 0 → affected_symbols.length === 0
- Fix null-safe coverage access: cov.startsWith → (mod.coverage || '').startsWith('Partial:')
- Add await to readJsonFile calls in main()
---
 _bmad/scripts/memtrace/qa-memtrace.mjs | 15 ++++++++-------
 1 file changed, 8 insertions(+), 7 deletions(-)

diff --git a/_bmad/scripts/memtrace/qa-memtrace.mjs b/_bmad/scripts/memtrace/qa-memtrace.mjs
index 37a21461e..c3f0064ff 100644
--- a/_bmad/scripts/memtrace/qa-memtrace.mjs
+++ b/_bmad/scripts/memtrace/qa-memtrace.mjs
@@ -1,6 +1,7 @@
 #!/usr/bin/env node
 
-import { readFileSync, existsSync } from 'fs';
+import { existsSync } from 'fs';
+import { readFile } from 'fs/promises';
 import { resolve } from 'path';
 
 const TIMEOUT_MS = 10000;
@@ -54,16 +55,16 @@ function fail(msg) {
   console.log(TIMEOUT_TOKEN);
 }
 
-function readJsonFile(filePath) {
+async function readJsonFile(filePath) {
   const resolved = resolve(filePath);
   if (!existsSync(resolved)) {
     throw new Error(`File not found: ${resolved}`);
   }
-  return JSON.parse(readFileSync(resolved, 'utf-8'));
+  return JSON.parse(await readFile(resolved, 'utf-8'));
 }
 
 function compute(blastData, coverageData, threshold) {
-  if (!Array.isArray(blastData.affected_symbols) || blastData.total_count === 0) {
+  if (!Array.isArray(blastData.affected_symbols) || blastData.affected_symbols.length === 0) {
     return {
       status: 'pass',
       blast_radius_total: 0,
@@ -95,7 +96,7 @@ function compute(blastData, coverageData, threshold) {
           coveredSet.add(`${modPath}:${sym}`);
         }
       }
-    } else if (cov.startsWith('Partial:')) {
+    } else if ((mod.coverage || '').startsWith('Partial:')) {
       const n = parseInt(cov.split(':')[1], 10) || 0;
       const covered = (mod.symbols_covered || []).slice(0, n);
       for (const sym of covered) {
@@ -136,7 +137,7 @@ async function main() {
   const args = parseArgs();
   const start = Date.now();
 
-  const blastData = readJsonFile(args.blastRadius);
+  const blastData = await readJsonFile(args.blastRadius);
   if (!Array.isArray(blastData.affected_symbols)) {
     throw new Error('Invalid blast-radius data: "affected_symbols" must be an array');
   }
@@ -144,7 +145,7 @@ async function main() {
     throw new Error('Invalid blast-radius data: "total_count" must be a number');
   }
 
-  const coverageData = readJsonFile(args.testCoverage);
+  const coverageData = await readJsonFile(args.testCoverage);
   if (!Array.isArray(coverageData.modules)) {
     throw new Error('Invalid test-coverage data: "modules" must be an array');
   }