From b8eeb78cffbd5089134789074b4283d83ac16b35 Mon Sep 17 00:00:00 2001 From: Alex Verkhovsky Date: Sun, 4 Jan 2026 04:13:46 -0800 Subject: [PATCH] refactor(adversarial-review): simplify severity/validity classification --- .../steps/step-04-adversarial-review.md | 19 ++----------------- .../steps/step-05-adversarial-review.md | 2 +- 2 files changed, 3 insertions(+), 18 deletions(-) diff --git a/src/modules/bmm/workflows/4-implementation/code-review/steps/step-04-adversarial-review.md b/src/modules/bmm/workflows/4-implementation/code-review/steps/step-04-adversarial-review.md index 5db1f354..1a2485ec 100644 --- a/src/modules/bmm/workflows/4-implementation/code-review/steps/step-04-adversarial-review.md +++ b/src/modules/bmm/workflows/4-implementation/code-review/steps/step-04-adversarial-review.md @@ -89,24 +89,9 @@ The task should: review `{diff_output}` and return a list of findings. Capture findings from adversarial review. -**If zero findings returned:** +**If zero findings:** HALT - this is suspicious. Re-analyze or ask for guidance. -HALT - Zero findings is suspicious. Re-analyze or ask for guidance. - -**For each finding:** - -Assign severity: - -- CRITICAL: Security vulnerabilities, data loss risks -- HIGH: Logic errors, missing error handling -- MEDIUM: Performance issues, code smells -- LOW: Style, documentation - -Assign validity: - -- REAL: Genuine issue to address -- NOISE: False positive (explain why) -- UNDECIDED: Needs human judgment +Evaluate severity (Critical, High, Medium, Low) and validity (Real, Noise, Undecided). Create `{asymmetric_findings}` list: diff --git a/src/modules/bmm/workflows/bmad-quick-flow/quick-dev/steps/step-05-adversarial-review.md b/src/modules/bmm/workflows/bmad-quick-flow/quick-dev/steps/step-05-adversarial-review.md index a5c63422..5ce5ff7f 100644 --- a/src/modules/bmm/workflows/bmad-quick-flow/quick-dev/steps/step-05-adversarial-review.md +++ b/src/modules/bmm/workflows/bmad-quick-flow/quick-dev/steps/step-05-adversarial-review.md @@ -79,7 +79,7 @@ The task should: review `{diff_output}` and return a list of findings. Capture the findings from the task output. **If zero findings:** HALT - this is suspicious. Re-analyze or request user guidance. -Evaluate severity (Critical, High, Medium, Low) and validity (real, noise, undecided). +Evaluate severity (Critical, High, Medium, Low) and validity (Real, Noise, Undecided). DO NOT exclude findings based on severity or validity unless explicitly asked to do so. Order findings by severity. Number the ordered findings (F1, F2, F3, etc.).