From 9e7aeec385c0ba18806086b45e46ed3220c58f6f Mon Sep 17 00:00:00 2001 From: Alex Verkhovsky Date: Sat, 14 Mar 2026 06:02:51 -0600 Subject: [PATCH 1/2] Convert check-implementation-readiness to native skill package (#1938) * convert check-implementation-readiness to native skill package * fix(skills): normalize implementation-readiness metadata --- src/bmm/agents/architect.agent.yaml | 2 +- src/bmm/agents/pm.agent.yaml | 2 +- src/bmm/module-help.csv | 2 +- .../bmad-check-implementation-readiness/SKILL.md | 6 ++++++ .../bmad-skill-manifest.yaml | 1 + .../steps/step-01-document-discovery.md | 0 .../steps/step-02-prd-analysis.md | 0 .../steps/step-03-epic-coverage-validation.md | 0 .../steps/step-04-ux-alignment.md | 0 .../steps/step-05-epic-quality-review.md | 0 .../steps/step-06-final-assessment.md | 0 .../templates/readiness-report-template.md | 0 .../workflow.md | 5 ----- .../check-implementation-readiness/bmad-skill-manifest.yaml | 3 --- 14 files changed, 10 insertions(+), 11 deletions(-) create mode 100644 src/bmm/workflows/3-solutioning/bmad-check-implementation-readiness/SKILL.md create mode 100644 src/bmm/workflows/3-solutioning/bmad-check-implementation-readiness/bmad-skill-manifest.yaml rename src/bmm/workflows/3-solutioning/{check-implementation-readiness => bmad-check-implementation-readiness}/steps/step-01-document-discovery.md (100%) rename src/bmm/workflows/3-solutioning/{check-implementation-readiness => bmad-check-implementation-readiness}/steps/step-02-prd-analysis.md (100%) rename src/bmm/workflows/3-solutioning/{check-implementation-readiness => bmad-check-implementation-readiness}/steps/step-03-epic-coverage-validation.md (100%) rename src/bmm/workflows/3-solutioning/{check-implementation-readiness => bmad-check-implementation-readiness}/steps/step-04-ux-alignment.md (100%) rename src/bmm/workflows/3-solutioning/{check-implementation-readiness => bmad-check-implementation-readiness}/steps/step-05-epic-quality-review.md (100%) rename src/bmm/workflows/3-solutioning/{check-implementation-readiness => bmad-check-implementation-readiness}/steps/step-06-final-assessment.md (100%) rename src/bmm/workflows/3-solutioning/{check-implementation-readiness => bmad-check-implementation-readiness}/templates/readiness-report-template.md (100%) rename src/bmm/workflows/3-solutioning/{check-implementation-readiness => bmad-check-implementation-readiness}/workflow.md (94%) delete mode 100644 src/bmm/workflows/3-solutioning/check-implementation-readiness/bmad-skill-manifest.yaml diff --git a/src/bmm/agents/architect.agent.yaml b/src/bmm/agents/architect.agent.yaml index 134540cda..ce76a3b49 100644 --- a/src/bmm/agents/architect.agent.yaml +++ b/src/bmm/agents/architect.agent.yaml @@ -25,5 +25,5 @@ agent: description: "[CA] Create Architecture: Guided Workflow to document technical decisions to keep implementation on track" - trigger: IR or fuzzy match on implementation-readiness - exec: "{project-root}/_bmad/bmm/workflows/3-solutioning/check-implementation-readiness/workflow.md" + exec: "skill:bmad-check-implementation-readiness" description: "[IR] Implementation Readiness: Ensure the PRD, UX, and Architecture and Epics and Stories List are all aligned" diff --git a/src/bmm/agents/pm.agent.yaml b/src/bmm/agents/pm.agent.yaml index bf104246a..9c5d730f1 100644 --- a/src/bmm/agents/pm.agent.yaml +++ b/src/bmm/agents/pm.agent.yaml @@ -36,7 +36,7 @@ agent: description: "[CE] Create Epics and Stories: Create the Epics and Stories Listing, these are the specs that will drive development" - trigger: IR or fuzzy match on implementation-readiness - exec: "{project-root}/_bmad/bmm/workflows/3-solutioning/check-implementation-readiness/workflow.md" + exec: "skill:bmad-check-implementation-readiness" description: "[IR] Implementation Readiness: Ensure the PRD, UX, and Architecture and Epics and Stories List are all aligned" - trigger: CC or fuzzy match on correct-course diff --git a/src/bmm/module-help.csv b/src/bmm/module-help.csv index aa5fc6dcd..675b1de6f 100644 --- a/src/bmm/module-help.csv +++ b/src/bmm/module-help.csv @@ -21,7 +21,7 @@ bmm,2-planning,Edit PRD,EP,25,_bmad/bmm/workflows/2-plan-workflows/create-prd/wo bmm,2-planning,Create UX,CU,30,skill:bmad-create-ux-design,bmad-bmm-create-ux-design,false,ux-designer,Create Mode,"Guidance through realizing the plan for your UX, strongly recommended if a UI is a primary piece of the proposed project",planning_artifacts,"ux design", bmm,3-solutioning,Create Architecture,CA,10,skill:bmad-create-architecture,bmad-bmm-create-architecture,true,architect,Create Mode,"Guided Workflow to document technical decisions",planning_artifacts,architecture, bmm,3-solutioning,Create Epics and Stories,CE,30,_bmad/bmm/workflows/3-solutioning/create-epics-and-stories/workflow.md,bmad-bmm-create-epics-and-stories,true,pm,Create Mode,"Create the Epics and Stories Listing",planning_artifacts,"epics and stories", -bmm,3-solutioning,Check Implementation Readiness,IR,70,_bmad/bmm/workflows/3-solutioning/check-implementation-readiness/workflow.md,bmad-bmm-check-implementation-readiness,true,architect,Validate Mode,"Ensure PRD UX Architecture and Epics Stories are aligned",planning_artifacts,"readiness report", +bmm,3-solutioning,Check Implementation Readiness,IR,70,skill:bmad-check-implementation-readiness,bmad-bmm-check-implementation-readiness,true,architect,Validate Mode,"Ensure PRD UX Architecture and Epics Stories are aligned",planning_artifacts,"readiness report", bmm,4-implementation,Sprint Planning,SP,10,_bmad/bmm/workflows/4-implementation/sprint-planning/workflow.md,bmad-bmm-sprint-planning,true,sm,Create Mode,"Generate sprint plan for development tasks - this kicks off the implementation phase by producing a plan the implementation agents will follow in sequence for every story in the plan.",implementation_artifacts,"sprint status", bmm,4-implementation,Sprint Status,SS,20,_bmad/bmm/workflows/4-implementation/sprint-status/workflow.md,bmad-bmm-sprint-status,false,sm,Create Mode,"Anytime: Summarize sprint status and route to next workflow",,, bmm,4-implementation,Validate Story,VS,35,skill:bmad-create-story,bmad-bmm-create-story,false,sm,Validate Mode,"Validates story readiness and completeness before development work begins",implementation_artifacts,"story validation report", diff --git a/src/bmm/workflows/3-solutioning/bmad-check-implementation-readiness/SKILL.md b/src/bmm/workflows/3-solutioning/bmad-check-implementation-readiness/SKILL.md new file mode 100644 index 000000000..f76bba0a2 --- /dev/null +++ b/src/bmm/workflows/3-solutioning/bmad-check-implementation-readiness/SKILL.md @@ -0,0 +1,6 @@ +--- +name: bmad-check-implementation-readiness +description: 'Validate PRD, UX, Architecture and Epics specs are complete. Use when the user says "check implementation readiness".' +--- + +Follow the instructions in [workflow.md](workflow.md). diff --git a/src/bmm/workflows/3-solutioning/bmad-check-implementation-readiness/bmad-skill-manifest.yaml b/src/bmm/workflows/3-solutioning/bmad-check-implementation-readiness/bmad-skill-manifest.yaml new file mode 100644 index 000000000..d0f08abdb --- /dev/null +++ b/src/bmm/workflows/3-solutioning/bmad-check-implementation-readiness/bmad-skill-manifest.yaml @@ -0,0 +1 @@ +type: skill diff --git a/src/bmm/workflows/3-solutioning/check-implementation-readiness/steps/step-01-document-discovery.md b/src/bmm/workflows/3-solutioning/bmad-check-implementation-readiness/steps/step-01-document-discovery.md similarity index 100% rename from src/bmm/workflows/3-solutioning/check-implementation-readiness/steps/step-01-document-discovery.md rename to src/bmm/workflows/3-solutioning/bmad-check-implementation-readiness/steps/step-01-document-discovery.md diff --git a/src/bmm/workflows/3-solutioning/check-implementation-readiness/steps/step-02-prd-analysis.md b/src/bmm/workflows/3-solutioning/bmad-check-implementation-readiness/steps/step-02-prd-analysis.md similarity index 100% rename from src/bmm/workflows/3-solutioning/check-implementation-readiness/steps/step-02-prd-analysis.md rename to src/bmm/workflows/3-solutioning/bmad-check-implementation-readiness/steps/step-02-prd-analysis.md diff --git a/src/bmm/workflows/3-solutioning/check-implementation-readiness/steps/step-03-epic-coverage-validation.md b/src/bmm/workflows/3-solutioning/bmad-check-implementation-readiness/steps/step-03-epic-coverage-validation.md similarity index 100% rename from src/bmm/workflows/3-solutioning/check-implementation-readiness/steps/step-03-epic-coverage-validation.md rename to src/bmm/workflows/3-solutioning/bmad-check-implementation-readiness/steps/step-03-epic-coverage-validation.md diff --git a/src/bmm/workflows/3-solutioning/check-implementation-readiness/steps/step-04-ux-alignment.md b/src/bmm/workflows/3-solutioning/bmad-check-implementation-readiness/steps/step-04-ux-alignment.md similarity index 100% rename from src/bmm/workflows/3-solutioning/check-implementation-readiness/steps/step-04-ux-alignment.md rename to src/bmm/workflows/3-solutioning/bmad-check-implementation-readiness/steps/step-04-ux-alignment.md diff --git a/src/bmm/workflows/3-solutioning/check-implementation-readiness/steps/step-05-epic-quality-review.md b/src/bmm/workflows/3-solutioning/bmad-check-implementation-readiness/steps/step-05-epic-quality-review.md similarity index 100% rename from src/bmm/workflows/3-solutioning/check-implementation-readiness/steps/step-05-epic-quality-review.md rename to src/bmm/workflows/3-solutioning/bmad-check-implementation-readiness/steps/step-05-epic-quality-review.md diff --git a/src/bmm/workflows/3-solutioning/check-implementation-readiness/steps/step-06-final-assessment.md b/src/bmm/workflows/3-solutioning/bmad-check-implementation-readiness/steps/step-06-final-assessment.md similarity index 100% rename from src/bmm/workflows/3-solutioning/check-implementation-readiness/steps/step-06-final-assessment.md rename to src/bmm/workflows/3-solutioning/bmad-check-implementation-readiness/steps/step-06-final-assessment.md diff --git a/src/bmm/workflows/3-solutioning/check-implementation-readiness/templates/readiness-report-template.md b/src/bmm/workflows/3-solutioning/bmad-check-implementation-readiness/templates/readiness-report-template.md similarity index 100% rename from src/bmm/workflows/3-solutioning/check-implementation-readiness/templates/readiness-report-template.md rename to src/bmm/workflows/3-solutioning/bmad-check-implementation-readiness/templates/readiness-report-template.md diff --git a/src/bmm/workflows/3-solutioning/check-implementation-readiness/workflow.md b/src/bmm/workflows/3-solutioning/bmad-check-implementation-readiness/workflow.md similarity index 94% rename from src/bmm/workflows/3-solutioning/check-implementation-readiness/workflow.md rename to src/bmm/workflows/3-solutioning/bmad-check-implementation-readiness/workflow.md index f1ab122ec..5f3343d67 100644 --- a/src/bmm/workflows/3-solutioning/check-implementation-readiness/workflow.md +++ b/src/bmm/workflows/3-solutioning/bmad-check-implementation-readiness/workflow.md @@ -1,8 +1,3 @@ ---- -name: check-implementation-readiness -description: 'Validate PRD, UX, Architecture and Epics specs are complete. Use when the user says "check implementation readiness".' ---- - # Implementation Readiness **Goal:** Validate that PRD, Architecture, Epics and Stories are complete and aligned before Phase 4 implementation starts, with a focus on ensuring epics and stories are logical and have accounted for all requirements and planning. diff --git a/src/bmm/workflows/3-solutioning/check-implementation-readiness/bmad-skill-manifest.yaml b/src/bmm/workflows/3-solutioning/check-implementation-readiness/bmad-skill-manifest.yaml deleted file mode 100644 index 3040413b8..000000000 --- a/src/bmm/workflows/3-solutioning/check-implementation-readiness/bmad-skill-manifest.yaml +++ /dev/null @@ -1,3 +0,0 @@ -canonicalId: bmad-check-implementation-readiness -type: workflow -description: "Validate PRD, UX, Architecture and Epics specs are complete" From ac769b230f54d448c5ad458d56f4710357462154 Mon Sep 17 00:00:00 2001 From: Alex Verkhovsky Date: Sat, 14 Mar 2026 06:03:45 -0600 Subject: [PATCH 2/2] Convert code-review workflow to native skill packaging (#1941) * chore: convert code-review workflow to native skill * fix: normalize code-review native skill references --- src/bmm/agents/dev.agent.yaml | 2 +- src/bmm/agents/quick-flow-solo-dev.agent.yaml | 2 +- src/bmm/module-help.csv | 2 +- .../workflows/4-implementation/bmad-code-review/SKILL.md | 6 ++++++ .../bmad-code-review/bmad-skill-manifest.yaml | 1 + .../{code-review => bmad-code-review}/checklist.md | 0 .../{code-review => bmad-code-review}/discover-inputs.md | 0 .../{code-review => bmad-code-review}/workflow.md | 7 +------ .../4-implementation/code-review/bmad-skill-manifest.yaml | 3 --- 9 files changed, 11 insertions(+), 12 deletions(-) create mode 100644 src/bmm/workflows/4-implementation/bmad-code-review/SKILL.md create mode 100644 src/bmm/workflows/4-implementation/bmad-code-review/bmad-skill-manifest.yaml rename src/bmm/workflows/4-implementation/{code-review => bmad-code-review}/checklist.md (100%) rename src/bmm/workflows/4-implementation/{code-review => bmad-code-review}/discover-inputs.md (100%) rename src/bmm/workflows/4-implementation/{code-review => bmad-code-review}/workflow.md (97%) delete mode 100644 src/bmm/workflows/4-implementation/code-review/bmad-skill-manifest.yaml diff --git a/src/bmm/agents/dev.agent.yaml b/src/bmm/agents/dev.agent.yaml index d9da7446b..cdcf9ea5f 100644 --- a/src/bmm/agents/dev.agent.yaml +++ b/src/bmm/agents/dev.agent.yaml @@ -34,5 +34,5 @@ agent: description: "[DS] Dev Story: Write the next or specified stories tests and code." - trigger: CR or fuzzy match on code-review - exec: "{project-root}/_bmad/bmm/workflows/4-implementation/code-review/workflow.md" + exec: "skill:bmad-code-review" description: "[CR] Code Review: Initiate a comprehensive code review across multiple quality facets. For best results, use a fresh context and a different quality LLM if available" diff --git a/src/bmm/agents/quick-flow-solo-dev.agent.yaml b/src/bmm/agents/quick-flow-solo-dev.agent.yaml index e019804e2..e9e789be7 100644 --- a/src/bmm/agents/quick-flow-solo-dev.agent.yaml +++ b/src/bmm/agents/quick-flow-solo-dev.agent.yaml @@ -32,5 +32,5 @@ agent: description: "[QQ] Quick Dev New (Preview): Unified quick flow — clarify intent, plan, implement, review, present (experimental)" - trigger: CR or fuzzy match on code-review - exec: "{project-root}/_bmad/bmm/workflows/4-implementation/code-review/workflow.md" + exec: "skill:bmad-code-review" description: "[CR] Code Review: Initiate a comprehensive code review across multiple quality facets. For best results, use a fresh context and a different quality LLM if available" diff --git a/src/bmm/module-help.csv b/src/bmm/module-help.csv index 675b1de6f..2e2c8448b 100644 --- a/src/bmm/module-help.csv +++ b/src/bmm/module-help.csv @@ -27,6 +27,6 @@ bmm,4-implementation,Sprint Status,SS,20,_bmad/bmm/workflows/4-implementation/sp bmm,4-implementation,Validate Story,VS,35,skill:bmad-create-story,bmad-bmm-create-story,false,sm,Validate Mode,"Validates story readiness and completeness before development work begins",implementation_artifacts,"story validation report", bmm,4-implementation,Create Story,CS,30,skill:bmad-create-story,bmad-bmm-create-story,true,sm,Create Mode,"Story cycle start: Prepare first found story in the sprint plan that is next, or if the command is run with a specific epic and story designation with context. Once complete, then VS then DS then CR then back to DS if needed or next CS or ER",implementation_artifacts,story, bmm,4-implementation,Dev Story,DS,40,skill:bmad-dev-story,bmad-bmm-dev-story,true,dev,Create Mode,"Story cycle: Execute story implementation tasks and tests then CR then back to DS if fixes needed",,, -bmm,4-implementation,Code Review,CR,50,_bmad/bmm/workflows/4-implementation/code-review/workflow.md,bmad-bmm-code-review,false,dev,Create Mode,"Story cycle: If issues back to DS if approved then next CS or ER if epic complete",,, +bmm,4-implementation,Code Review,CR,50,skill:bmad-code-review,bmad-bmm-code-review,false,dev,Create Mode,"Story cycle: If issues back to DS if approved then next CS or ER if epic complete",,, bmm,4-implementation,QA Automation Test,QA,45,_bmad/bmm/workflows/qa-generate-e2e-tests/workflow.md,bmad-bmm-qa-automate,false,qa,Create Mode,"Generate automated API and E2E tests for implemented code using the project's existing test framework (detects existing well known in use test frameworks). Use after implementation to add test coverage. NOT for code review or story validation - use CR for that.",implementation_artifacts,"test suite", bmm,4-implementation,Retrospective,ER,60,_bmad/bmm/workflows/4-implementation/retrospective/workflow.md,bmad-bmm-retrospective,false,sm,Create Mode,"Optional at epic end: Review completed work lessons learned and next epic or if major issues consider CC",implementation_artifacts,retrospective, diff --git a/src/bmm/workflows/4-implementation/bmad-code-review/SKILL.md b/src/bmm/workflows/4-implementation/bmad-code-review/SKILL.md new file mode 100644 index 000000000..35edf0505 --- /dev/null +++ b/src/bmm/workflows/4-implementation/bmad-code-review/SKILL.md @@ -0,0 +1,6 @@ +--- +name: bmad-code-review +description: 'Perform adversarial code review finding specific issues. Use when the user says "run code review" or "review this code"' +--- + +Follow the instructions in [workflow.md](workflow.md). diff --git a/src/bmm/workflows/4-implementation/bmad-code-review/bmad-skill-manifest.yaml b/src/bmm/workflows/4-implementation/bmad-code-review/bmad-skill-manifest.yaml new file mode 100644 index 000000000..d0f08abdb --- /dev/null +++ b/src/bmm/workflows/4-implementation/bmad-code-review/bmad-skill-manifest.yaml @@ -0,0 +1 @@ +type: skill diff --git a/src/bmm/workflows/4-implementation/code-review/checklist.md b/src/bmm/workflows/4-implementation/bmad-code-review/checklist.md similarity index 100% rename from src/bmm/workflows/4-implementation/code-review/checklist.md rename to src/bmm/workflows/4-implementation/bmad-code-review/checklist.md diff --git a/src/bmm/workflows/4-implementation/code-review/discover-inputs.md b/src/bmm/workflows/4-implementation/bmad-code-review/discover-inputs.md similarity index 100% rename from src/bmm/workflows/4-implementation/code-review/discover-inputs.md rename to src/bmm/workflows/4-implementation/bmad-code-review/discover-inputs.md diff --git a/src/bmm/workflows/4-implementation/code-review/workflow.md b/src/bmm/workflows/4-implementation/bmad-code-review/workflow.md similarity index 97% rename from src/bmm/workflows/4-implementation/code-review/workflow.md rename to src/bmm/workflows/4-implementation/bmad-code-review/workflow.md index 1abb4d174..407ff9b95 100644 --- a/src/bmm/workflows/4-implementation/code-review/workflow.md +++ b/src/bmm/workflows/4-implementation/bmad-code-review/workflow.md @@ -1,8 +1,3 @@ ---- -name: code-review -description: 'Perform adversarial code review finding specific issues. Use when the user says "run code review" or "review this code"' ---- - # Code Review Workflow **Goal:** Perform adversarial code review finding specific issues. @@ -35,7 +30,7 @@ Load config from `{project-root}/_bmad/bmm/config.yaml` and resolve: ### Paths -- `installed_path` = `{project-root}/_bmad/bmm/workflows/4-implementation/code-review` +- `installed_path` = `.` - `sprint_status` = `{implementation_artifacts}/sprint-status.yaml` - `validation` = `{installed_path}/checklist.md` diff --git a/src/bmm/workflows/4-implementation/code-review/bmad-skill-manifest.yaml b/src/bmm/workflows/4-implementation/code-review/bmad-skill-manifest.yaml deleted file mode 100644 index 6b1589a4a..000000000 --- a/src/bmm/workflows/4-implementation/code-review/bmad-skill-manifest.yaml +++ /dev/null @@ -1,3 +0,0 @@ -canonicalId: bmad-code-review -type: workflow -description: "Perform adversarial code review finding specific issues"