ldy26098
/
BMAD-METHOD
mirror of https://github.com/bmad-code-org/BMAD-METHOD.git
1
0
Fork 0
Code Packages Projects Releases Wiki Activity

refactor(installer): make _collectConfigs take clean config only 

Move _quickUpdate short-circuit to the call site in install() so
_collectConfigs receives the clean config object and has no dependency
on customConfig. Uses config.hasCoreConfig() instead of inline check.
This commit is contained in:
Alex Verkhovsky 2026-03-21 05:26:19 -06:00
parent e41cc1f822
commit a9ba16cff5
1 changed files with 9 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

23
tools/cli/installers/lib/core/installer.js
View File

@ -76,7 +76,8 @@ class Installer {
const paths = await InstallPaths.create(config); const paths = await InstallPaths.create(config);
// Collect configurations for official modules // Collect configurations for official modules
const moduleConfigs = await this._collectConfigs(customConfig, paths); // Quick update already collected everything — skip
const moduleConfigs = customConfig._quickUpdate ? this.configCollector.collectedConfig : await this._collectConfigs(config, paths);
await this.customModules.discoverPaths(config, paths); await this.customModules.discoverPaths(config, paths);
this.ideManager.setBmadFolderName(BMAD_FOLDER_NAME); this.ideManager.setBmadFolderName(BMAD_FOLDER_NAME);
@ -871,27 +872,21 @@ class Installer {
* Collect configurations for official modules (core + selected). * Collect configurations for official modules (core + selected).
* Custom module configs are handled separately in CustomModules.discoverPaths. * Custom module configs are handled separately in CustomModules.discoverPaths.
*/ */
async _collectConfigs(customConfig, paths) { async _collectConfigs(config, paths) {
// Seed core config if pre-collected from interactive UI // Seed core config if pre-collected from interactive UI
const hasCoreConfig = customConfig.coreConfig && Object.keys(customConfig.coreConfig).length > 0; if (config.hasCoreConfig()) {
if (hasCoreConfig) { this.configCollector.collectedConfig.core = config.coreConfig;
this.configCollector.collectedConfig.core = customConfig.coreConfig;
this.configCollector.allAnswers = {}; this.configCollector.allAnswers = {};
for (const [key, value] of Object.entries(customConfig.coreConfig)) { for (const [key, value] of Object.entries(config.coreConfig)) {
this.configCollector.allAnswers[`core_${key}`] = value; this.configCollector.allAnswers[`core_${key}`] = value;
} }
} }
// Quick update already collected everything // Modules to collect — skip core if its config was pre-collected
if (customConfig._quickUpdate) { const toCollect = config.hasCoreConfig() ? config.modules.filter((m) => m !== 'core') : [...config.modules];
return this.configCollector.collectedConfig;
}
// Modules to collect configs for — skip core if its config was pre-collected from UI
const toCollect = hasCoreConfig ? (customConfig.modules || []).filter((m) => m !== 'core') : [...(customConfig.modules || [])];
return await this.configCollector.collectAllConfigurations(toCollect, paths.projectRoot, { return await this.configCollector.collectAllConfigurations(toCollect, paths.projectRoot, {
skipPrompts: customConfig.skipPrompts, skipPrompts: config.skipPrompts,
}); });
} }