From a4cdc8275438e5d5074742b067194f5bf430fcbe Mon Sep 17 00:00:00 2001 From: Jerome Revillard Date: Wed, 20 May 2026 11:28:13 +0200 Subject: [PATCH] fix(skills): strengthen activation guardrails for all workflow skills MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Add explicit "Activation is complete" boundary markers that require confirming activation_steps_prepend and activation_steps_append were fully executed before beginning the main workflow. Previously, the guardrail was either missing (bmad-product-brief, bmad-prd, bmad-investigate) or too weak ("Begin the workflow below"). LLM agents would short-circuit complex activation sequences (INCLUDE → READ → RUN → CHECK → FILTER → CD) by guessing variables instead of executing steps in order, causing append steps and on_complete hooks to be silently skipped. The new guardrail explicitly names both prepend and append steps, requiring confirmation before proceeding. This prevents agents from starting the main workflow in parallel with activation. 23 skills updated: bmad-product-brief, bmad-prd, bmad-prfaq, bmad-investigate, bmad-create-story, bmad-dev-story, bmad-quick-dev, bmad-code-review, bmad-correct-course, bmad-sprint-planning, bmad-sprint-status, bmad-retrospective, bmad-qa-generate-e2e-tests, bmad-checkpoint-preview, bmad-check-implementation-readiness, bmad-create-architecture, bmad-create-epics-and-stories, bmad-generate-project-context, bmad-create-ux-design, bmad-document-project, bmad-market-research, bmad-technical-research, bmad-domain-research. --- src/bmm-skills/1-analysis/bmad-document-project/SKILL.md | 2 +- src/bmm-skills/1-analysis/bmad-prfaq/SKILL.md | 2 +- src/bmm-skills/1-analysis/bmad-product-brief/SKILL.md | 2 ++ .../1-analysis/research/bmad-domain-research/SKILL.md | 2 +- .../1-analysis/research/bmad-market-research/SKILL.md | 2 +- .../1-analysis/research/bmad-technical-research/SKILL.md | 2 +- src/bmm-skills/2-plan-workflows/bmad-create-ux-design/SKILL.md | 2 +- src/bmm-skills/2-plan-workflows/bmad-prd/SKILL.md | 2 ++ .../3-solutioning/bmad-check-implementation-readiness/SKILL.md | 2 +- src/bmm-skills/3-solutioning/bmad-create-architecture/SKILL.md | 2 +- .../3-solutioning/bmad-create-epics-and-stories/SKILL.md | 2 +- .../3-solutioning/bmad-generate-project-context/SKILL.md | 2 +- .../4-implementation/bmad-checkpoint-preview/SKILL.md | 2 +- src/bmm-skills/4-implementation/bmad-code-review/SKILL.md | 2 +- src/bmm-skills/4-implementation/bmad-correct-course/SKILL.md | 2 +- src/bmm-skills/4-implementation/bmad-create-story/SKILL.md | 2 +- src/bmm-skills/4-implementation/bmad-dev-story/SKILL.md | 2 +- src/bmm-skills/4-implementation/bmad-investigate/SKILL.md | 2 ++ .../4-implementation/bmad-qa-generate-e2e-tests/SKILL.md | 2 +- src/bmm-skills/4-implementation/bmad-quick-dev/SKILL.md | 2 +- src/bmm-skills/4-implementation/bmad-retrospective/SKILL.md | 2 +- src/bmm-skills/4-implementation/bmad-sprint-planning/SKILL.md | 2 +- src/bmm-skills/4-implementation/bmad-sprint-status/SKILL.md | 2 +- 23 files changed, 26 insertions(+), 20 deletions(-) diff --git a/src/bmm-skills/1-analysis/bmad-document-project/SKILL.md b/src/bmm-skills/1-analysis/bmad-document-project/SKILL.md index 112732031..045ffb254 100644 --- a/src/bmm-skills/1-analysis/bmad-document-project/SKILL.md +++ b/src/bmm-skills/1-analysis/bmad-document-project/SKILL.md @@ -55,7 +55,7 @@ Greet `{user_name}` (if you have not already), speaking in `{communication_langu Execute each entry in `{workflow.activation_steps_append}` in order. -Activation is complete. Begin the workflow below. +Activation is complete. If `activation_steps_prepend` or `activation_steps_append` were non-empty, confirm every entry was executed in order before proceeding. Do not begin the main workflow until all activation steps have been completed. ## Execution diff --git a/src/bmm-skills/1-analysis/bmad-prfaq/SKILL.md b/src/bmm-skills/1-analysis/bmad-prfaq/SKILL.md index 6ce2d33ed..580d8ec75 100644 --- a/src/bmm-skills/1-analysis/bmad-prfaq/SKILL.md +++ b/src/bmm-skills/1-analysis/bmad-prfaq/SKILL.md @@ -65,7 +65,7 @@ Greet `{user_name}`, speaking in `{communication_language}`. Be warm but efficie Execute each entry in `{workflow.activation_steps_append}` in order. -Activation is complete. Continue below. +Activation is complete. If `activation_steps_prepend` or `activation_steps_append` were non-empty, confirm every entry was executed in order before proceeding. Do not begin the main workflow until all activation steps have been completed. ## Pre-workflow Setup diff --git a/src/bmm-skills/1-analysis/bmad-product-brief/SKILL.md b/src/bmm-skills/1-analysis/bmad-product-brief/SKILL.md index 671079999..1d278c6d5 100644 --- a/src/bmm-skills/1-analysis/bmad-product-brief/SKILL.md +++ b/src/bmm-skills/1-analysis/bmad-product-brief/SKILL.md @@ -23,6 +23,8 @@ At the opening greeting, let the user know they can invoke `bmad-party-mode` for 6. Greet `{user_name}` in `{communication_language}` — and stay in `{communication_language}` for every turn for the entire run, not just the greeting. Detect intent (create / update / validate). If interactive and intent is unclear, ask; for headless behavior see `## Headless Mode`. 7. Execute each entry in `{workflow.activation_steps_append}` in order. +Activation is complete. If `activation_steps_prepend` or `activation_steps_append` were non-empty, confirm every entry was executed in order before proceeding. Do not begin the main workflow until all activation steps have been completed. + ## Intent Operating Modes **Create.** A brief the user is proud of, that meets their needs, drawn out through real conversation — do not assume: instead converse and understand, and then help craft the best product brief for their needs. Begin in `## Discovery` before drafting; the brief comes after the picture is on the table. Shape follows the product and need. Treat `{workflow.brief_template}` as a starting structure, not a contract: drop sections that do not earn their place, add sections the product needs, reorder freely - create sections for specialized domains or concerns also as needed. The brief serves the product's story, not the template's shape. Bind `{doc_workspace}` to a fresh folder at `{workflow.brief_output_path}/{workflow.run_folder_pattern}/` and write `brief.md` there with YAML frontmatter (title, status, created, updated). For Update and Validate, `{doc_workspace}` is the existing folder of the brief being targeted. diff --git a/src/bmm-skills/1-analysis/research/bmad-domain-research/SKILL.md b/src/bmm-skills/1-analysis/research/bmad-domain-research/SKILL.md index be364aa2f..9ea915f08 100644 --- a/src/bmm-skills/1-analysis/research/bmad-domain-research/SKILL.md +++ b/src/bmm-skills/1-analysis/research/bmad-domain-research/SKILL.md @@ -59,7 +59,7 @@ Greet `{user_name}`, speaking in `{communication_language}`. Execute each entry in `{workflow.activation_steps_append}` in order. -Activation is complete. Begin the workflow below. +Activation is complete. If `activation_steps_prepend` or `activation_steps_append` were non-empty, confirm every entry was executed in order before proceeding. Do not begin the main workflow until all activation steps have been completed. ## QUICK TOPIC DISCOVERY diff --git a/src/bmm-skills/1-analysis/research/bmad-market-research/SKILL.md b/src/bmm-skills/1-analysis/research/bmad-market-research/SKILL.md index 964049085..29fefa4de 100644 --- a/src/bmm-skills/1-analysis/research/bmad-market-research/SKILL.md +++ b/src/bmm-skills/1-analysis/research/bmad-market-research/SKILL.md @@ -59,7 +59,7 @@ Greet `{user_name}`, speaking in `{communication_language}`. Execute each entry in `{workflow.activation_steps_append}` in order. -Activation is complete. Begin the workflow below. +Activation is complete. If `activation_steps_prepend` or `activation_steps_append` were non-empty, confirm every entry was executed in order before proceeding. Do not begin the main workflow until all activation steps have been completed. ## QUICK TOPIC DISCOVERY diff --git a/src/bmm-skills/1-analysis/research/bmad-technical-research/SKILL.md b/src/bmm-skills/1-analysis/research/bmad-technical-research/SKILL.md index 582a05c60..511816415 100644 --- a/src/bmm-skills/1-analysis/research/bmad-technical-research/SKILL.md +++ b/src/bmm-skills/1-analysis/research/bmad-technical-research/SKILL.md @@ -59,7 +59,7 @@ Greet `{user_name}`, speaking in `{communication_language}`. Execute each entry in `{workflow.activation_steps_append}` in order. -Activation is complete. Begin the workflow below. +Activation is complete. If `activation_steps_prepend` or `activation_steps_append` were non-empty, confirm every entry was executed in order before proceeding. Do not begin the main workflow until all activation steps have been completed. ## QUICK TOPIC DISCOVERY diff --git a/src/bmm-skills/2-plan-workflows/bmad-create-ux-design/SKILL.md b/src/bmm-skills/2-plan-workflows/bmad-create-ux-design/SKILL.md index 496473b1e..921416102 100644 --- a/src/bmm-skills/2-plan-workflows/bmad-create-ux-design/SKILL.md +++ b/src/bmm-skills/2-plan-workflows/bmad-create-ux-design/SKILL.md @@ -62,7 +62,7 @@ Greet `{user_name}`, speaking in `{communication_language}`. Execute each entry in `{workflow.activation_steps_append}` in order. -Activation is complete. Begin the workflow below. +Activation is complete. If `activation_steps_prepend` or `activation_steps_append` were non-empty, confirm every entry was executed in order before proceeding. Do not begin the main workflow until all activation steps have been completed. ## Paths diff --git a/src/bmm-skills/2-plan-workflows/bmad-prd/SKILL.md b/src/bmm-skills/2-plan-workflows/bmad-prd/SKILL.md index 310b59be0..a8ea64bbb 100644 --- a/src/bmm-skills/2-plan-workflows/bmad-prd/SKILL.md +++ b/src/bmm-skills/2-plan-workflows/bmad-prd/SKILL.md @@ -22,6 +22,8 @@ You are a master facilitator and coach helping the user create, edit, or validat 5. Detect intent: **Create** (no PRD), **Update** (existing PRD), **Validate** (critique only). If ambiguous, ask. For Create intent, before binding a fresh workspace, scan `{workflow.prd_output_path}` for prior in-progress runs (folders matching `{workflow.run_folder_pattern}` whose `prd.md` frontmatter `status` is not `final`); if any exist, offer to resume rather than starting over. 6. Run `{workflow.activation_steps_append}`. +Activation is complete. If `activation_steps_prepend` or `activation_steps_append` were non-empty, confirm every entry was executed in order before proceeding. Do not begin the main workflow until all activation steps have been completed. + ## Intent Modes **Create.** Bind `{doc_workspace}` to `{workflow.prd_output_path}/{workflow.run_folder_pattern}/`. Write `prd.md` with YAML frontmatter (title, status, created, updated — initial `status: draft`), and create the `.decision-log.md` skeleton at the workspace root so subsequent decisions land in a known file. Tell the user the path. Run `## Discovery`, then `## Finalize`. diff --git a/src/bmm-skills/3-solutioning/bmad-check-implementation-readiness/SKILL.md b/src/bmm-skills/3-solutioning/bmad-check-implementation-readiness/SKILL.md index 1d5133f90..a34a25a7d 100644 --- a/src/bmm-skills/3-solutioning/bmad-check-implementation-readiness/SKILL.md +++ b/src/bmm-skills/3-solutioning/bmad-check-implementation-readiness/SKILL.md @@ -84,7 +84,7 @@ Greet `{user_name}`, speaking in `{communication_language}`. Execute each entry in `{workflow.activation_steps_append}` in order. -Activation is complete. Begin the workflow below. +Activation is complete. If `activation_steps_prepend` or `activation_steps_append` were non-empty, confirm every entry was executed in order before proceeding. Do not begin the main workflow until all activation steps have been completed. ## Execution diff --git a/src/bmm-skills/3-solutioning/bmad-create-architecture/SKILL.md b/src/bmm-skills/3-solutioning/bmad-create-architecture/SKILL.md index ca89a71cf..e7f024ed2 100644 --- a/src/bmm-skills/3-solutioning/bmad-create-architecture/SKILL.md +++ b/src/bmm-skills/3-solutioning/bmad-create-architecture/SKILL.md @@ -65,7 +65,7 @@ Greet `{user_name}`, speaking in `{communication_language}`. Execute each entry in `{workflow.activation_steps_append}` in order. -Activation is complete. Begin the workflow below. +Activation is complete. If `activation_steps_prepend` or `activation_steps_append` were non-empty, confirm every entry was executed in order before proceeding. Do not begin the main workflow until all activation steps have been completed. ## Execution diff --git a/src/bmm-skills/3-solutioning/bmad-create-epics-and-stories/SKILL.md b/src/bmm-skills/3-solutioning/bmad-create-epics-and-stories/SKILL.md index a3f0f61c8..a97bc2404 100644 --- a/src/bmm-skills/3-solutioning/bmad-create-epics-and-stories/SKILL.md +++ b/src/bmm-skills/3-solutioning/bmad-create-epics-and-stories/SKILL.md @@ -86,7 +86,7 @@ Greet `{user_name}`, speaking in `{communication_language}`. Execute each entry in `{workflow.activation_steps_append}` in order. -Activation is complete. Begin the workflow below. +Activation is complete. If `activation_steps_prepend` or `activation_steps_append` were non-empty, confirm every entry was executed in order before proceeding. Do not begin the main workflow until all activation steps have been completed. ## Execution diff --git a/src/bmm-skills/3-solutioning/bmad-generate-project-context/SKILL.md b/src/bmm-skills/3-solutioning/bmad-generate-project-context/SKILL.md index 42fd2e8fc..b452de5d4 100644 --- a/src/bmm-skills/3-solutioning/bmad-generate-project-context/SKILL.md +++ b/src/bmm-skills/3-solutioning/bmad-generate-project-context/SKILL.md @@ -65,7 +65,7 @@ Greet `{user_name}`, speaking in `{communication_language}`. Execute each entry in `{workflow.activation_steps_append}` in order. -Activation is complete. Begin the workflow below. +Activation is complete. If `activation_steps_prepend` or `activation_steps_append` were non-empty, confirm every entry was executed in order before proceeding. Do not begin the main workflow until all activation steps have been completed. ## Paths diff --git a/src/bmm-skills/4-implementation/bmad-checkpoint-preview/SKILL.md b/src/bmm-skills/4-implementation/bmad-checkpoint-preview/SKILL.md index 101dcf2bc..e512ab675 100644 --- a/src/bmm-skills/4-implementation/bmad-checkpoint-preview/SKILL.md +++ b/src/bmm-skills/4-implementation/bmad-checkpoint-preview/SKILL.md @@ -55,7 +55,7 @@ Greet the user, speaking in `{communication_language}`. Execute each entry in `{workflow.activation_steps_append}` in order. -Activation is complete. Begin the workflow below. +Activation is complete. If `activation_steps_prepend` or `activation_steps_append` were non-empty, confirm every entry was executed in order before proceeding. Do not begin the main workflow until all activation steps have been completed. ## Global Step Rules (apply to every step) diff --git a/src/bmm-skills/4-implementation/bmad-code-review/SKILL.md b/src/bmm-skills/4-implementation/bmad-code-review/SKILL.md index 44223f11a..b4c88fde3 100644 --- a/src/bmm-skills/4-implementation/bmad-code-review/SKILL.md +++ b/src/bmm-skills/4-implementation/bmad-code-review/SKILL.md @@ -58,7 +58,7 @@ Greet `{user_name}`, speaking in `{communication_language}`. Execute each entry in `{workflow.activation_steps_append}` in order. -Activation is complete. Begin the workflow below. +Activation is complete. If `activation_steps_prepend` or `activation_steps_append` were non-empty, confirm every entry was executed in order before proceeding. Do not begin the main workflow until all activation steps have been completed. ## WORKFLOW ARCHITECTURE diff --git a/src/bmm-skills/4-implementation/bmad-correct-course/SKILL.md b/src/bmm-skills/4-implementation/bmad-correct-course/SKILL.md index adea0bda0..f62b91780 100644 --- a/src/bmm-skills/4-implementation/bmad-correct-course/SKILL.md +++ b/src/bmm-skills/4-implementation/bmad-correct-course/SKILL.md @@ -62,7 +62,7 @@ Greet `{user_name}`, speaking in `{communication_language}`. Execute each entry in `{workflow.activation_steps_append}` in order. -Activation is complete. Begin the workflow below. +Activation is complete. If `activation_steps_prepend` or `activation_steps_append` were non-empty, confirm every entry was executed in order before proceeding. Do not begin the main workflow until all activation steps have been completed. ## Paths diff --git a/src/bmm-skills/4-implementation/bmad-create-story/SKILL.md b/src/bmm-skills/4-implementation/bmad-create-story/SKILL.md index cf14039c1..7d407098b 100644 --- a/src/bmm-skills/4-implementation/bmad-create-story/SKILL.md +++ b/src/bmm-skills/4-implementation/bmad-create-story/SKILL.md @@ -63,7 +63,7 @@ Greet `{user_name}`, speaking in `{communication_language}`. Execute each entry in `{workflow.activation_steps_append}` in order. -Activation is complete. Begin the workflow below. +Activation is complete. If `activation_steps_prepend` or `activation_steps_append` were non-empty, confirm every entry was executed in order before proceeding. Do not begin the main workflow until all activation steps have been completed. ## Paths diff --git a/src/bmm-skills/4-implementation/bmad-dev-story/SKILL.md b/src/bmm-skills/4-implementation/bmad-dev-story/SKILL.md index 218b234ab..dc8634021 100644 --- a/src/bmm-skills/4-implementation/bmad-dev-story/SKILL.md +++ b/src/bmm-skills/4-implementation/bmad-dev-story/SKILL.md @@ -63,7 +63,7 @@ Greet `{user_name}`, speaking in `{communication_language}`. Execute each entry in `{workflow.activation_steps_append}` in order. -Activation is complete. Begin the workflow below. +Activation is complete. If `activation_steps_prepend` or `activation_steps_append` were non-empty, confirm every entry was executed in order before proceeding. Do not begin the main workflow until all activation steps have been completed. ## Paths diff --git a/src/bmm-skills/4-implementation/bmad-investigate/SKILL.md b/src/bmm-skills/4-implementation/bmad-investigate/SKILL.md index 3e0442809..0f7e2419e 100644 --- a/src/bmm-skills/4-implementation/bmad-investigate/SKILL.md +++ b/src/bmm-skills/4-implementation/bmad-investigate/SKILL.md @@ -84,6 +84,8 @@ Run each entry in `{workflow.activation_steps_append}` in order. Acknowledge the input as a reference (record paths and IDs; don't read raw content). Path to an existing case file → Outcome 0. Otherwise → Outcome 1. +Activation is complete. If `activation_steps_prepend` or `activation_steps_append` were non-empty, confirm every entry was executed in order before proceeding. Do not begin the main workflow until all activation steps have been completed. + ## Procedure ### Outcome 0: Existing case is loaded and surfaced diff --git a/src/bmm-skills/4-implementation/bmad-qa-generate-e2e-tests/SKILL.md b/src/bmm-skills/4-implementation/bmad-qa-generate-e2e-tests/SKILL.md index ef9d7e87a..cbf358027 100644 --- a/src/bmm-skills/4-implementation/bmad-qa-generate-e2e-tests/SKILL.md +++ b/src/bmm-skills/4-implementation/bmad-qa-generate-e2e-tests/SKILL.md @@ -56,7 +56,7 @@ Greet `{user_name}`, speaking in `{communication_language}`. Execute each entry in `{workflow.activation_steps_append}` in order. -Activation is complete. Begin the workflow below. +Activation is complete. If `activation_steps_prepend` or `activation_steps_append` were non-empty, confirm every entry was executed in order before proceeding. Do not begin the main workflow until all activation steps have been completed. ## Paths diff --git a/src/bmm-skills/4-implementation/bmad-quick-dev/SKILL.md b/src/bmm-skills/4-implementation/bmad-quick-dev/SKILL.md index f5326fc3f..c62358be6 100644 --- a/src/bmm-skills/4-implementation/bmad-quick-dev/SKILL.md +++ b/src/bmm-skills/4-implementation/bmad-quick-dev/SKILL.md @@ -79,7 +79,7 @@ Greet `{user_name}`, speaking in `{communication_language}`. Execute each entry in `{workflow.activation_steps_append}` in order. -Activation is complete. Begin the workflow below. +Activation is complete. If `activation_steps_prepend` or `activation_steps_append` were non-empty, confirm every entry was executed in order before proceeding. Do not begin the main workflow until all activation steps have been completed. ## WORKFLOW ARCHITECTURE diff --git a/src/bmm-skills/4-implementation/bmad-retrospective/SKILL.md b/src/bmm-skills/4-implementation/bmad-retrospective/SKILL.md index b6d0c96c6..d885d0d99 100644 --- a/src/bmm-skills/4-implementation/bmad-retrospective/SKILL.md +++ b/src/bmm-skills/4-implementation/bmad-retrospective/SKILL.md @@ -73,7 +73,7 @@ Greet `{user_name}`, speaking in `{communication_language}`. Execute each entry in `{workflow.activation_steps_append}` in order. -Activation is complete. Begin the workflow below. +Activation is complete. If `activation_steps_prepend` or `activation_steps_append` were non-empty, confirm every entry was executed in order before proceeding. Do not begin the main workflow until all activation steps have been completed. ## Paths diff --git a/src/bmm-skills/4-implementation/bmad-sprint-planning/SKILL.md b/src/bmm-skills/4-implementation/bmad-sprint-planning/SKILL.md index 25266d716..a7dc63208 100644 --- a/src/bmm-skills/4-implementation/bmad-sprint-planning/SKILL.md +++ b/src/bmm-skills/4-implementation/bmad-sprint-planning/SKILL.md @@ -58,7 +58,7 @@ Greet `{user_name}`, speaking in `{communication_language}`. Execute each entry in `{workflow.activation_steps_append}` in order. -Activation is complete. Begin the workflow below. +Activation is complete. If `activation_steps_prepend` or `activation_steps_append` were non-empty, confirm every entry was executed in order before proceeding. Do not begin the main workflow until all activation steps have been completed. ## Paths diff --git a/src/bmm-skills/4-implementation/bmad-sprint-status/SKILL.md b/src/bmm-skills/4-implementation/bmad-sprint-status/SKILL.md index c52a84947..4506cae64 100644 --- a/src/bmm-skills/4-implementation/bmad-sprint-status/SKILL.md +++ b/src/bmm-skills/4-implementation/bmad-sprint-status/SKILL.md @@ -56,7 +56,7 @@ Greet `{user_name}`, speaking in `{communication_language}`. Execute each entry in `{workflow.activation_steps_append}` in order. -Activation is complete. Begin the workflow below. +Activation is complete. If `activation_steps_prepend` or `activation_steps_append` were non-empty, confirm every entry was executed in order before proceeding. Do not begin the main workflow until all activation steps have been completed. ## Paths