ldy26098
/
BMAD-METHOD
mirror of https://github.com/bmad-code-org/BMAD-METHOD.git
1
0
Fork 0
Code Packages Projects Releases Wiki Activity

fix: add error handling and rollback for temp directory cleanup

This commit is contained in:
Alex Verkhovsky 2025-12-08 08:43:35 -07:00
parent c28150f5df
commit a2baaad15b
1 changed files with 29 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

38
tools/cli/installers/lib/core/installer.js
View File

@ -972,19 +972,39 @@ If AgentVibes party mode is enabled, immediately trigger TTS with agent's voice:
if (await fs.pathExists(customDir)) { if (await fs.pathExists(customDir)) {
// Move contents to module directory // Move contents to module directory
const items = await fs.readdir(customDir); const items = await fs.readdir(customDir);
for (const item of items) { const movedItems = [];
const srcPath = path.join(customDir, item); try {
const destPath = path.join(moduleTargetPath, item); for (const item of items) {
const srcPath = path.join(customDir, item);
const destPath = path.join(moduleTargetPath, item);
// If destination exists, remove it first (or we could merge) // If destination exists, remove it first (or we could merge)
if (await fs.pathExists(destPath)) { if (await fs.pathExists(destPath)) {
await fs.remove(destPath); await fs.remove(destPath);
}
await fs.move(srcPath, destPath);
movedItems.push({ src: srcPath, dest: destPath });
} }
} catch (moveError) {
await fs.move(srcPath, destPath); // Rollback: restore any successfully moved items
for (const moved of movedItems) {
try {
await fs.move(moved.dest, moved.src);
} catch {
// Best-effort rollback - log if it fails
console.error(`Failed to rollback ${moved.dest} during cleanup`);
}
}
throw new Error(`Failed to move custom module files: ${moveError.message}`);
} }
} }
await fs.remove(tempCustomPath); try {
await fs.remove(tempCustomPath);
} catch (cleanupError) {
// Non-fatal: temp directory cleanup failed but files were moved successfully
console.warn(`Warning: Could not clean up temp directory: ${cleanupError.message}`);
}
} }
// Create module config (include collected config from module.yaml prompts) // Create module config (include collected config from module.yaml prompts)