diff --git a/src/modules/bmm/workflows/4-implementation/code-review/instructions.xml b/src/modules/bmm/workflows/4-implementation/code-review/instructions.xml
index e57a940d..edc2bade 100644
--- a/src/modules/bmm/workflows/4-implementation/code-review/instructions.xml
+++ b/src/modules/bmm/workflows/4-implementation/code-review/instructions.xml
@@ -104,52 +104,104 @@
Find at least 3 more specific, actionable issues
+
+
+ Set {{context_aware_findings}} = all issues found in this step (numbered list with file:line locations)
-
- Categorize findings: HIGH (must fix), MEDIUM (should fix), LOW (nice to fix)
+
+ Reviewer has FULL repo access but NO knowledge of WHY changes were made
+ DO NOT include story file in prompt - asymmetry is about intent, not visibility
+ Reviewer can explore codebase to understand impact, but judges changes on merit alone
+
+
+ Construct the diff of story-related changes:
+ - Uncommitted changes: `git diff` + `git diff --cached`
+ - Committed changes (if story spans commits): `git log --oneline` to find relevant commits, then `git diff base..HEAD`
+ - Exclude story file from diff: `git diff -- . ':!{{story_path}}'`
+
+ Set {{asymmetric_target}} = the diff output (reviewer can explore repo but is prompted to review this diff)
+
+
+
+ Launch general-purpose subagent with adversarial prompt:
+ "You are a cynical, jaded code reviewer with zero patience for sloppy work.
+ A clueless weasel submitted the following changes and you expect to find problems.
+ Find at least ten findings to fix or improve. Look for what's missing, not just what's wrong.
+ Number each finding (1., 2., 3., ...). Be skeptical of everything.
+
+ Changes to review:
+ {{asymmetric_target}}"
+
+ Collect numbered findings into {{asymmetric_findings}}
+
+
+
+ Execute adversarial review via CLI (e.g., claude --print) in fresh context with same prompt
+ Collect numbered findings into {{asymmetric_findings}}
+
+
+
+ Execute adversarial prompt inline in main context
+ Note: Has context pollution but cynical reviewer persona still adds significant value
+ Collect numbered findings into {{asymmetric_findings}}
+
+
+
+
+ Merge findings from BOTH context-aware review (step 3) AND asymmetric review (step 4)
+
+ Combine {{context_aware_findings}} from step 3 with {{asymmetric_findings}} from step 4
+
+ Deduplicate findings:
+ - Identify findings that describe the same underlying issue
+ - Keep the more detailed/actionable version
+ - Note when both reviews caught the same issue (validates severity)
+
+
+ Assess each finding:
+ - Is this a real issue or noise/false positive?
+ - Assign severity: 🔴 CRITICAL, 🟠HIGH, 🟡 MEDIUM, 🟢 LOW
+
+
+ Filter out non-issues:
+ - Remove false positives
+ - Remove nitpicks that do not warrant action
+ - Keep anything that could cause problems in production
+
+
+ Sort by severity (CRITICAL → HIGH → MEDIUM → LOW)
+
Set {{fixed_count}} = 0
Set {{action_count}} = 0
What should I do with these issues?
- 1. **Fix them automatically** - I'll update the code and tests
+ 1. **Fix them automatically** - I'll fix all HIGH and CRITICAL, you approve each
2. **Create action items** - Add to story Tasks/Subtasks for later
- 3. **Show me details** - Deep dive into specific issues
+ 3. **Details on #N** - Explain specific issue
Choose [1], [2], or specify which issue to examine:
- Fix all HIGH and MEDIUM issues in the code
+ Fix all CRITICAL and HIGH issues in the code
Add/update tests as needed
Update File List in story if files changed
Update story Dev Agent Record with fixes applied
- Set {{fixed_count}} = number of HIGH and MEDIUM issues fixed
+ Set {{fixed_count}} = number of CRITICAL and HIGH issues fixed
Set {{action_count}} = 0
@@ -166,13 +218,13 @@
-
+
-
+
Set {{new_status}} = "done"
Update story Status field to "done"
-
+
Set {{new_status}} = "in-progress"
Update story Status field to "in-progress"