From 9805aa361f2c2a54ee838ffb8998d7faa947c8e1 Mon Sep 17 00:00:00 2001 From: Nikolas de Hor Date: Wed, 11 Mar 2026 21:36:15 -0300 Subject: [PATCH] fix: remove mandatory minimum issue count from code review workflow The code review workflow required finding 3-10 issues minimum per review and forced the agent to keep looking if fewer than 3 were found. This created an endless review cycle where every review manufactures issues even after previous fixes were applied, because the workflow cannot conclude with "no issues found." Replace the hard minimum with a zero-issue sanity check that allows clean reviews after a thorough re-examination, while preserving the adversarial review approach for genuine issues. --- .../4-implementation/code-review/workflow.md | 11 ++++------- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/src/bmm/workflows/4-implementation/code-review/workflow.md b/src/bmm/workflows/4-implementation/code-review/workflow.md index f4dd8188b..1abb4d174 100644 --- a/src/bmm/workflows/4-implementation/code-review/workflow.md +++ b/src/bmm/workflows/4-implementation/code-review/workflow.md @@ -13,7 +13,7 @@ description: 'Perform adversarial code review finding specific issues. Use when - Generate all documents in {document_output_language} - Your purpose: Validate story file claims against actual implementation - Challenge everything: Are tasks marked [x] actually done? Are ACs really implemented? -- Find 3-10 specific issues in every review minimum - no lazy "looks good" reviews - YOU are so much better than the dev agent that wrote this slop +- Be thorough and specific — find real issues, not manufactured ones. If the code is genuinely good after fixes, say so - Read EVERY file in the File List - verify implementation against story requirements - Tasks marked complete but not done = CRITICAL finding - Acceptance Criteria not implemented = HIGH severity finding @@ -136,17 +136,14 @@ Load config from `{project-root}/_bmad/bmm/config.yaml` and resolve: 5. **Test Quality**: Are tests real assertions or placeholders? - - NOT LOOKING HARD ENOUGH - Find more problems! - Re-examine code for: + + Double-check by re-examining code for: - Edge cases and null handling - Architecture violations - - Documentation gaps - Integration issues - Dependency problems - - Git commit message quality (if applicable) - Find at least 3 more specific, actionable issues + If still no issues found after thorough re-examination, that is a valid outcome — report a clean review