From 8d05f327061d8145d5cf42249ae0abc004a90273 Mon Sep 17 00:00:00 2001 From: Brian Madison Date: Mon, 13 Apr 2026 01:02:05 -0500 Subject: [PATCH] fix(installer): stop skill scanner from recursing into discovered skills Skills don't nest. Once the manifest generator finds a valid SKILL.md in a directory, it should not recurse into that skill's subdirectories looking for more skills. Template files (like bmb's setup-skill-template) inside a skill's assets/ would be incorrectly scanned and produce spurious errors. --- tools/installer/core/manifest-generator.js | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/tools/installer/core/manifest-generator.js b/tools/installer/core/manifest-generator.js index 477142888..df8484d8b 100644 --- a/tools/installer/core/manifest-generator.js +++ b/tools/installer/core/manifest-generator.js @@ -193,11 +193,13 @@ class ManifestGenerator { } } - // Recurse into subdirectories - for (const entry of entries) { - if (!entry.isDirectory()) continue; - if (entry.name.startsWith('.') || entry.name.startsWith('_')) continue; - await walk(path.join(dir, entry.name)); + // Recurse into subdirectories — but not inside a discovered skill + if (!skillMeta) { + for (const entry of entries) { + if (!entry.isDirectory()) continue; + if (entry.name.startsWith('.') || entry.name.startsWith('_')) continue; + await walk(path.join(dir, entry.name)); + } } };