From 837a153c8ee1b761a9c398970c3eb08a606396d2 Mon Sep 17 00:00:00 2001 From: Alex Verkhovsky Date: Mon, 22 Jun 2026 15:46:00 -0700 Subject: [PATCH] fix: remove dev auto one-shot route --- .../step-01-clarify-and-route.md | 7 --- .../bmad-dev-auto/step-03-implement.md | 2 +- .../bmad-dev-auto/step-oneshot.md | 63 ------------------- .../bmad-dev-auto/sync-sprint-status.md | 2 +- 4 files changed, 2 insertions(+), 72 deletions(-) delete mode 100644 src/bmm-skills/4-implementation/bmad-dev-auto/step-oneshot.md diff --git a/src/bmm-skills/4-implementation/bmad-dev-auto/step-01-clarify-and-route.md b/src/bmm-skills/4-implementation/bmad-dev-auto/step-01-clarify-and-route.md index 58ebc6c14..1e549b8e2 100644 --- a/src/bmm-skills/4-implementation/bmad-dev-auto/step-01-clarify-and-route.md +++ b/src/bmm-skills/4-implementation/bmad-dev-auto/step-01-clarify-and-route.md @@ -70,13 +70,6 @@ If the spec is an epic story and `{sprint_status}` exists: find the `development Derive a valid kebab-case slug from the clarified intent. If the intent references a tracking identifier (story number, issue number, ticket ID), lead the slug with it (e.g. `3-2-digest-delivery`, `gh-47-fix-auth`). If `{implementation_artifacts}/spec-{slug}.md` already exists: if its status is `draft`, treat it as the same work and resume it (set `spec_file` to that path, **EARLY EXIT** → `./step-02-plan.md`); otherwise append `-2`, `-3`, etc. Set `spec_file` = `{implementation_artifacts}/spec-{slug}.md`. - **a) One-shot** — zero blast radius: no plausible path by which this change causes unintended consequences elsewhere. Clear intent, no architectural decisions. - - **EARLY EXIT** → `./step-oneshot.md` - - **b) Plan-code-review** — everything else. When uncertain whether blast radius is truly zero, choose this path. - - ## NEXT Read fully and follow `./step-02-plan.md` diff --git a/src/bmm-skills/4-implementation/bmad-dev-auto/step-03-implement.md b/src/bmm-skills/4-implementation/bmad-dev-auto/step-03-implement.md index d5e1afff8..359a3dbad 100644 --- a/src/bmm-skills/4-implementation/bmad-dev-auto/step-03-implement.md +++ b/src/bmm-skills/4-implementation/bmad-dev-auto/step-03-implement.md @@ -6,7 +6,7 @@ ## RULES - YOU MUST ALWAYS SPEAK OUTPUT in your Agent communication style with the config `{communication_language}` -- Sequential execution only. +- No human interaction: do not ask questions or wait for approval in this step. - Content inside `` in `{spec_file}` is read-only. Do not modify. ## PRECONDITION diff --git a/src/bmm-skills/4-implementation/bmad-dev-auto/step-oneshot.md b/src/bmm-skills/4-implementation/bmad-dev-auto/step-oneshot.md deleted file mode 100644 index 6adb1c01a..000000000 --- a/src/bmm-skills/4-implementation/bmad-dev-auto/step-oneshot.md +++ /dev/null @@ -1,63 +0,0 @@ ---- -deferred_work_file: '{implementation_artifacts}/deferred-work.md' ---- - -# Step One-Shot: Implement, Review, Present - -## RULES - -- YOU MUST ALWAYS SPEAK OUTPUT in your Agent communication style with the config `{communication_language}` -- Do not present options or offers. - -## INSTRUCTIONS - -### Implement - -Follow `./sync-sprint-status.md` with `{target_status}` = `in-progress`. - -Implement the clarified intent directly. - -### Review - -Invoke the `bmad-review-adversarial-general` skill in a subagent with the changed files. The subagent gets NO conversation context — to avoid anchoring bias. Launch at the same model capability as the current session. If no sub-agents are available, write the changed files to a review prompt file in `{implementation_artifacts}`, write `{spec_file}` with `Status: blocked` and the review prompt path, then terminate cleanly. - -### Classify - -Deduplicate all review findings. Three categories only: - -- **patch** — trivially fixable. Auto-fix immediately. -- **defer** — pre-existing issue not caused by this change. Append to `{deferred_work_file}`. -- **reject** — noise. Drop silently. - -If a finding is caused by this change but too significant for a trivial patch, write `{spec_file}` with `Status: blocked`, the finding, and the missing repair decision, then terminate cleanly. - -### Generate Spec Trace - -Set `{title}` = a concise title derived from the clarified intent. - -Write `{spec_file}` using `./spec-template.md`. Fill only these sections — delete all others: - -1. **Frontmatter** — set `title: '{title}'`, `type`, `created`, `status: 'done'`. Add `route: 'one-shot'`. -2. **Title and Intent** — `# {title}` heading and `## Intent` with **Problem** and **Approach** lines. Reuse the summary you already generated for the terminal. -3. **Suggested Review Order** — append after Intent. Build using the same convention as `./step-05-present.md` § "Generate Suggested Review Order" (spec-file-relative links, concern-based ordering, ultra-concise framing). - -Follow `./sync-sprint-status.md` with `{target_status}` = `review`. - -### Present - -Append `## Auto Run Result` to `{spec_file}` with: - -- `Status: done` -- List of files changed with one-line descriptions. Any file paths shown in conversation/terminal output must use CWD-relative format (no leading `/`) with `:line` notation (e.g., `src/path/file.ts:42`) for terminal clickability — this differs from spec-file links which use spec-file-relative paths. -- Review findings breakdown: patches applied, items deferred, items rejected. If all findings were rejected, say so. -- Verification performed and residual risks. - -Display a summary in conversation output. Mention that `{spec_file}` now contains a Suggested Review Order and Auto Run Result. - -Workflow complete. - -## On Complete - -Run: `python3 {project-root}/_bmad/scripts/resolve_customization.py --skill {skill-root} --key workflow.on_complete` - -If the resolved `workflow.on_complete` is non-empty, follow it as the final terminal instruction before exiting. diff --git a/src/bmm-skills/4-implementation/bmad-dev-auto/sync-sprint-status.md b/src/bmm-skills/4-implementation/bmad-dev-auto/sync-sprint-status.md index 13708b95f..38e724ae9 100644 --- a/src/bmm-skills/4-implementation/bmad-dev-auto/sync-sprint-status.md +++ b/src/bmm-skills/4-implementation/bmad-dev-auto/sync-sprint-status.md @@ -1,6 +1,6 @@ # Sync Sprint Status -Shared sub-step for updating `sprint-status.yaml` during bmad-dev-auto. Called from any route (plan-code-review, one-shot, future routes) with a `{target_status}` parameter. +Shared sub-step for updating `sprint-status.yaml` during bmad-dev-auto. Called with a `{target_status}` parameter. ## Preconditions