ldy26098
/
BMAD-METHOD
mirror of https://github.com/bmad-code-org/BMAD-METHOD.git
1
0
Fork 0
Code Packages Projects Releases Wiki Activity

fix: mandate killing background shells before code review 

Change cleanup logic from "check and maybe kill" to "kill unconditionally".
The previous approach allowed agents to read stale output from lingering
external agent processes, causing context pollution and reuse of old data.

New behavior:
- Kill ALL background shells as the FIRST action
- Do NOT read output from stale shells (BashOutput forbidden)
- Do NOT check what processes are doing - just terminate them
- Only proceed to Step 1 after all shells are dead
This commit is contained in:
Scott Jennings 2025-12-10 19:06:24 -06:00
parent 4c6b492835
commit 81817672af
1 changed files with 17 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

26
src/modules/bmm/workflows/4-implementation/code-review/instructions.xml
View File

@ -5,17 +5,25 @@
<critical>Generate all documents in {document_output_language}</critical> <critical>Generate all documents in {document_output_language}</critical>
<!-- ================================================================ --> <!-- ================================================================ -->
<!-- CLAUDE CODE CLEANUP - KILL LINGERING EXTERNAL AGENT PROCESSES --> <!-- CLAUDE CODE CLEANUP - MANDATORY KILL OF ALL BACKGROUND SHELLS -->
<!-- ================================================================ --> <!-- ================================================================ -->
<!-- If BMAD is running as Claude Code (not the external agent), clean up <!-- CRITICAL: Stale external agent processes cause context pollution.
any terminal processes from previous external agent code reviews. You MUST kill ALL background shells BEFORE doing ANYTHING else.
This prevents context pollution from stale review sessions. --> DO NOT read their output. DO NOT check what they're doing.
<check if="BMAD is running as Claude Code (detected via KillShell tool availability or CLAUDE_CODE env)"> Just KILL them unconditionally. -->
<action>Check for any running background shells/terminals from previous external agent reviews</action> <critical>🚨 FIRST ACTION REQUIRED: Kill all background shells 🚨</critical>
<action>If any `claude -p` or similar external agent processes are found running, use KillShell to terminate them</action> <critical>Before ANY other workflow step, you MUST terminate all background processes.</critical>
<action>This ensures a clean slate for the new code review session</action> <critical>DO NOT use BashOutput to read from stale shells - this causes context pollution.</critical>
<output>🧹 Cleaned up previous external agent review processes (if any)</output> <critical>DO NOT try to "check what they're doing" - just kill them.</critical>
<check if="BMAD is running as Claude Code (KillShell tool is available)">
<action>IMMEDIATELY use KillShell to terminate ALL background shells - no exceptions</action>
<action>Do NOT read output from these shells first - kill them blind</action>
<action>Do NOT rationalize keeping them alive - they contain stale data</action>
<action>If multiple shells exist, kill ALL of them one by one</action>
<output>🔪 Killed all background shells to prevent stale data contamination</output>
</check> </check>
<critical>Only proceed to Step 1 AFTER all background shells are terminated.</critical>
<!-- ================================================================ --> <!-- ================================================================ -->
<!-- EXTERNAL AGENT MANDATE - THIS IS THE MOST IMPORTANT RULE --> <!-- EXTERNAL AGENT MANDATE - THIS IS THE MOST IMPORTANT RULE -->