ldy26098
/
BMAD-METHOD
mirror of https://github.com/bmad-code-org/BMAD-METHOD.git
1
0
Fork 0
Code Packages Projects Releases Wiki Activity

fix(installer): track _bmad/.gitignore in manifest on every install run 

Address review: the early return when config.user.toml was already
ignored skipped installedFiles.add, dropping _bmad/.gitignore from
files-manifest.csv on re-installs. Suite 46 now uses a fresh Installer
per run, as production does, so the regression is actually exercised.
This commit is contained in:
Dov Benyomin Sohacheski 2026-06-11 23:19:35 +03:00
parent 10288d23d3
commit 7b1bfbf2b9
No known key found for this signature in database
2 changed files with 14 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
test/test-installation-components.js
View File

@ -3352,17 +3352,22 @@ async function runTests() {
// The pre-existing custom/*.user.toml rule is still seeded alongside it.
assert(await fs.pathExists(path.join(customDir46, '.gitignore')), '_installSharedScripts still seeds _bmad/custom/.gitignore');
// Idempotent: a second install must not duplicate the entry.
await installer46._installSharedScripts(paths46);
// Idempotent: a second install must not duplicate the entry. Fresh Installer
// per run, as in production — reuse would hide a failure to re-track the file.
const installer46b = new Installer();
await installer46b._installSharedScripts(paths46);
const occurrences46 = (await fs.readFile(bmadGitignore46, 'utf8')).split(/\r?\n/).filter((line) => line === 'config.user.toml').length;
assert(occurrences46 === 1, 'second install does not duplicate the config.user.toml entry');
assert(installer46b.installedFiles.has(bmadGitignore46), 're-install tracks _bmad/.gitignore even when the entry already exists');
// An existing .gitignore with unrelated rules is topped up, not clobbered.
await fs.writeFile(bmadGitignore46, 'notes.local.md\n');
await installer46._installSharedScripts(paths46);
const installer46c = new Installer();
await installer46c._installSharedScripts(paths46);
const toppedUp46 = await fs.readFile(bmadGitignore46, 'utf8');
assert(toppedUp46.includes('notes.local.md'), 'existing .gitignore rules are preserved');
assert(toppedUp46.split(/\r?\n/).includes('config.user.toml'), 'config.user.toml is appended to an existing .gitignore');
assert(installer46c.installedFiles.has(bmadGitignore46), 'appending install tracks _bmad/.gitignore');
} catch (error) {
console.log(`${colors.red}Test Suite 46 setup failed: ${error.message}${colors.reset}`);
console.log(error.stack);

5
tools/installer/core/installer.js
View File

@ -702,12 +702,15 @@ class Installer {
if (await fs.pathExists(gitignorePath)) {
const existing = await fs.readFile(gitignorePath, 'utf8');
if (existing.split(/\r?\n/).some((line) => line.trim() === entry)) return;
if (!existing.split(/\r?\n/).some((line) => line.trim() === entry)) {
const separator = existing.length > 0 && !existing.endsWith('\n') ? '\n' : '';
await fs.writeFile(gitignorePath, `${existing}${separator}${entry}\n`, 'utf8');
}
} else {
await fs.writeFile(gitignorePath, `${entry}\n`, 'utf8');
}
// Track on every path — each run starts a fresh Installer, so skipping the
// already-correct file would drop it from files-manifest.csv on re-installs.
this.installedFiles.add(gitignorePath);
}