From 7b0cad6f295c42c789f9c19004187ee8ca7af18e Mon Sep 17 00:00:00 2001 From: Claude Code Date: Sat, 22 Nov 2025 13:13:37 -0700 Subject: [PATCH] fix: Remove npm link from test script to avoid global namespace pollution - Removed 'npm link' command that was installing BMAD globally - Changed 'bmad install' to direct node execution using local clone - Updated success message to reflect no global installation This keeps testing fully isolated and prevents conflicts with: - Existing BMAD installations - Future official BMAD installs - Orphaned symlinks when test directory is deleted The test script now runs completely self-contained without modifying the user's global npm environment. --- test-bmad-pr.sh | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/test-bmad-pr.sh b/test-bmad-pr.sh index 26c52636..54cde458 100755 --- a/test-bmad-pr.sh +++ b/test-bmad-pr.sh @@ -255,9 +255,8 @@ echo "━━━━━━━━━━━━━━━━━━━━━━━━ echo "" cd tools/cli npm install -npm link echo "" -echo -e "${GREEN}✓ BMAD CLI installed and linked globally${NC}" +echo -e "${GREEN}✓ BMAD CLI dependencies installed${NC}" echo "" # Step 4: Create test project @@ -287,7 +286,7 @@ echo -e " • Provider: ${GREEN}Piper${NC} (free, local TTS)" echo -e " • Download voices: ${GREEN}Yes${NC}" echo "" read -p "Press Enter to start BMAD installer..." -bmad install +node "$TEST_DIR/BMAD-METHOD/tools/cli/bin/bmad.js" install echo "" echo -e "${GREEN}✓ BMAD and AgentVibes installation complete${NC}"