From 7a9f1d4a3cea90724b4776d8519acbbb5a4a78d4 Mon Sep 17 00:00:00 2001
From: Alex Verkhovsky <alexey.verkhovsky@gmail.com>
Date: Thu, 11 Dec 2025 23:20:29 -0700
Subject: [PATCH] fix(bmm): normalize story status references to lowercase
 kebab-case
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Updated status references to use canonical lowercase kebab-case format:

- dev-story/instructions.xml: Status field set to "review" (was "Ready for Review")
- dev-story/instructions.xml: Output messages reference actual "review" status
- dev-story/checklist.md: Status field instruction uses "review"
- daily-standup.xml: Status examples use "in-progress, review"

Story lifecycle: backlog → ready-for-dev → in-progress → review → done

Fixes #1105

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
---
 src/modules/bmm/tasks/daily-standup.xml                |  2 +-
 .../workflows/4-implementation/dev-story/checklist.md  |  2 +-
 .../4-implementation/dev-story/instructions.xml        | 10 +++++-----
 3 files changed, 7 insertions(+), 7 deletions(-)

diff --git a/src/modules/bmm/tasks/daily-standup.xml b/src/modules/bmm/tasks/daily-standup.xml
index d41c362c..2c9950b1 100644
--- a/src/modules/bmm/tasks/daily-standup.xml
+++ b/src/modules/bmm/tasks/daily-standup.xml
@@ -10,7 +10,7 @@
     <step n="1" title="Project Context Discovery">
       <action>Check for stories folder at {project-root}{output_folder}/stories/</action>
       <action>Find current story by identifying highest numbered story file</action>
-      <action>Read story status (In Progress, Ready for Review, etc.)</action>
+      <action>Read story status (in-progress, review, etc.)</action>
       <action>Extract agent notes from Dev Agent Record, TEA Results, PO Notes sections</action>
       <action>Check for next story references from epics</action>
       <action>Identify blockers from story sections</action>
diff --git a/src/modules/bmm/workflows/4-implementation/dev-story/checklist.md b/src/modules/bmm/workflows/4-implementation/dev-story/checklist.md
index 01f4d820..86d6e9be 100644
--- a/src/modules/bmm/workflows/4-implementation/dev-story/checklist.md
+++ b/src/modules/bmm/workflows/4-implementation/dev-story/checklist.md
@@ -57,7 +57,7 @@ validation-rules:
 
 ## 🔚 Final Status Verification
 
-- [ ] **Story Status Updated:** Story Status set to "Ready for Review"
+- [ ] **Story Status Updated:** Story Status set to "review"
 - [ ] **Sprint Status Updated:** Sprint status updated to "review" (when sprint tracking is used)
 - [ ] **Quality Gates Passed:** All quality checks and validations completed successfully
 - [ ] **No HALT Conditions:** No blocking issues or incomplete work remaining
diff --git a/src/modules/bmm/workflows/4-implementation/dev-story/instructions.xml b/src/modules/bmm/workflows/4-implementation/dev-story/instructions.xml
index 507abceb..4b668840 100644
--- a/src/modules/bmm/workflows/4-implementation/dev-story/instructions.xml
+++ b/src/modules/bmm/workflows/4-implementation/dev-story/instructions.xml
@@ -322,7 +322,7 @@
     <action>Run the full regression suite (do not skip)</action>
     <action>Confirm File List includes every changed file</action>
     <action>Execute enhanced definition-of-done validation</action>
-    <action>Update the story Status to: "Ready for Review"</action>
+    <action>Update the story Status to: "review"</action>
 
     <!-- Enhanced Definition of Done Validation -->
     <action>Validate definition-of-done checklist with essential requirements:
@@ -346,17 +346,17 @@
       <action>Verify current status is "in-progress" (expected previous state)</action>
       <action>Update development_status[{{story_key}}] = "review"</action>
       <action>Save file, preserving ALL comments and structure including STATUS DEFINITIONS</action>
-      <output>✅ Story marked Ready for Review in sprint status</output>
+      <output>✅ Story status updated to "review" in sprint-status.yaml</output>
     </check>
 
     <check if="{sprint_status} file does NOT exist OR {{current_sprint_status}} == 'no-sprint-tracking'">
-      <output>ℹ️ Story marked Ready for Review in story file (no sprint tracking configured)</output>
+      <output>ℹ️ Story status updated to "review" in story file (no sprint tracking configured)</output>
     </check>
 
     <check if="story key not found in sprint status">
       <output>⚠️ Story file updated, but sprint-status update failed: {{story_key}} not found
 
-        Story is marked Ready for Review in file, but sprint-status.yaml may be out of sync.
+        Story status is set to "review" in file, but sprint-status.yaml may be out of sync.
       </output>
     </check>
 
@@ -373,7 +373,7 @@
 
     <action>Communicate to {user_name} that story implementation is complete and ready for review</action>
     <action>Summarize key accomplishments: story ID, story key, title, key changes made, tests added, files modified</action>
-    <action>Provide the story file path and current status (now "Ready for Review")</action>
+    <action>Provide the story file path and current status (now "review")</action>
 
     <action>Based on {user_skill_level}, ask if user needs any explanations about:
       - What was implemented and how it works