fix(skill): batch validation cleanup for 6 skills

Remove installed_path definitions, unused intra-skill path variables,
and inline variable references across: bmad-sprint-status,
bmad-document-project, bmad-generate-project-context,
bmad-qa-generate-e2e-tests, bmad-advanced-elicitation, and
bmad-brainstorming.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This commit is contained in:
Alex Verkhovsky 2026-03-14 17:02:04 -06:00
parent 4cbbeb6602
commit 73e5552aad
12 changed files with 16 additions and 45 deletions

View File

@ -20,7 +20,6 @@ Load config from `{project-root}/_bmad/bmm/config.yaml` and resolve:
### Paths
- `installed_path` = `.`
- `sprint_status_file` = `{implementation_artifacts}/sprint-status.yaml`
### Input Files

View File

@ -40,18 +40,18 @@
<action>Load cached project_type_id(s) from state file</action>
<critical>CONDITIONAL CSV LOADING FOR RESUME:</critical>
<action>For each cached project_type_id, load ONLY the corresponding row from: {documentation_requirements_csv}</action>
<action>For each cached project_type_id, load ONLY the corresponding row from: ./documentation-requirements.csv</action>
<action>Skip loading project-types.csv and architecture_registry.csv (not needed on resume)</action>
<action>Store loaded doc requirements for use in remaining steps</action>
<action>Display: "Resuming {{workflow_mode}} from {{current_step}} with cached project type(s): {{cached_project_types}}"</action>
<check if="workflow_mode == deep_dive">
<action>Read fully and follow: {installed_path}/workflows/deep-dive-workflow.md with resume context</action>
<action>Read fully and follow: ./workflows/deep-dive-workflow.md with resume context</action>
</check>
<check if="workflow_mode == initial_scan OR workflow_mode == full_rescan">
<action>Read fully and follow: {installed_path}/workflows/full-scan-workflow.md with resume context</action>
<action>Read fully and follow: ./workflows/full-scan-workflow.md with resume context</action>
</check>
</check>
@ -98,7 +98,7 @@ Your choice [1/2/3]:
<check if="user selects 1">
<action>Set workflow_mode = "full_rescan"</action>
<action>Display: "Starting full project rescan..."</action>
<action>Read fully and follow: {installed_path}/workflows/full-scan-workflow.md</action>
<action>Read fully and follow: ./workflows/full-scan-workflow.md</action>
<action>After sub-workflow completes, continue to Step 4</action>
</check>
@ -106,7 +106,7 @@ Your choice [1/2/3]:
<action>Set workflow_mode = "deep_dive"</action>
<action>Set scan_level = "exhaustive"</action>
<action>Display: "Starting deep-dive documentation mode..."</action>
<action>Read fully and follow: {installed_path}/workflows/deep-dive-workflow.md</action>
<action>Read fully and follow: ./workflows/deep-dive-workflow.md</action>
<action>After sub-workflow completes, continue to Step 4</action>
</check>
@ -119,7 +119,7 @@ Your choice [1/2/3]:
<check if="index.md does not exist">
<action>Set workflow_mode = "initial_scan"</action>
<action>Display: "No existing documentation found. Starting initial project scan..."</action>
<action>Read fully and follow: {installed_path}/workflows/full-scan-workflow.md</action>
<action>Read fully and follow: ./workflows/full-scan-workflow.md</action>
<action>After sub-workflow completes, continue to Step 4</action>
</check>

View File

@ -20,15 +20,8 @@ Load config from `{project-root}/_bmad/bmm/config.yaml` and resolve:
- `user_skill_level`
- `date` as system-generated current datetime
### Paths
- `installed_path` = `.`
- `instructions` = `{installed_path}/instructions.md`
- `validation` = `{installed_path}/checklist.md`
- `documentation_requirements_csv` = `{installed_path}/documentation-requirements.csv`
---
## EXECUTION
Read fully and follow: `{installed_path}/instructions.md`
Read fully and follow: `./instructions.md`

View File

@ -193,7 +193,7 @@ This will read EVERY file in this area. Proceed? [y/n]
- Combine recommended test commands into {{suggested_tests}}
</action>
<action>Load complete deep-dive template from: {installed_path}/templates/deep-dive-template.md</action>
<action>Load complete deep-dive template from: ../templates/deep-dive-template.md</action>
<action>Fill template with all collected data from steps 13b-13d</action>
<action>Write filled template to: {project_knowledge}/deep-dive-{{sanitized_target_name}}.md</action>
<action>Validate deep-dive document completeness</action>

View File

@ -21,13 +21,6 @@ Load config from `{project-root}/_bmad/bmm/config.yaml` and resolve:
✅ YOU MUST ALWAYS SPEAK OUTPUT In your Agent communication style with the configured `{communication_language}`.
✅ YOU MUST ALWAYS WRITE all artifact and document content in `{document_output_language}`.
### Paths
- `installed_path` = `.`
- `instructions` = `{installed_path}/deep-dive-instructions.md`
- `validation` = `../checklist.md`
- `deep_dive_template` = `../templates/deep-dive-template.md`
### Runtime Inputs
- `workflow_mode` = `deep_dive`
@ -38,4 +31,4 @@ Load config from `{project-root}/_bmad/bmm/config.yaml` and resolve:
## EXECUTION
Read fully and follow: `{installed_path}/deep-dive-instructions.md`
Read fully and follow: `./deep-dive-instructions.md`

View File

@ -16,7 +16,7 @@
This workflow uses a single comprehensive CSV file to intelligently document your project:
**documentation-requirements.csv** ({documentation_requirements_csv})
**documentation-requirements.csv** (../documentation-requirements.csv)
- Contains 12 project types (web, mobile, backend, cli, library, desktop, game, data, extension, infra, embedded)
- 24-column schema combining project type detection AND documentation requirements
@ -36,7 +36,7 @@ This workflow uses a single comprehensive CSV file to intelligently document you
<action>Now loading documentation requirements data for fresh start...</action>
<action>Load documentation-requirements.csv from: {documentation_requirements_csv}</action>
<action>Load documentation-requirements.csv from: ../documentation-requirements.csv</action>
<action>Store all 12 rows indexed by project_type_id for project detection and requirements lookup</action>
<action>Display: "Loaded documentation requirements for 12 project types (web, mobile, backend, cli, library, desktop, game, data, extension, infra, embedded)"</action>
@ -810,7 +810,7 @@ Generated in {{project_knowledge}}/:
{{file_list_with_sizes}}
</action>
<action>Run validation checklist from {validation}</action>
<action>Run validation checklist from ../checklist.md</action>
<critical>INCOMPLETE DOCUMENTATION DETECTION:

View File

@ -20,13 +20,6 @@ Load config from `{project-root}/_bmad/bmm/config.yaml` and resolve:
✅ YOU MUST ALWAYS SPEAK OUTPUT In your Agent communication style with the configured `{communication_language}`.
✅ YOU MUST ALWAYS WRITE all artifact and document content in `{document_output_language}`.
### Paths
- `installed_path` = `.`
- `instructions` = `{installed_path}/full-scan-instructions.md`
- `validation` = `../checklist.md`
- `documentation_requirements_csv` = `../documentation-requirements.csv`
### Runtime Inputs
- `workflow_mode` = `""` (set by parent: `initial_scan` or `full_rescan`)
@ -38,4 +31,4 @@ Load config from `{project-root}/_bmad/bmm/config.yaml` and resolve:
## EXECUTION
Read fully and follow: `{installed_path}/full-scan-instructions.md`
Read fully and follow: `./full-scan-instructions.md`

View File

@ -32,8 +32,6 @@ Load config from `{project-root}/_bmad/bmm/config.yaml` and resolve:
### Paths
- `installed_path` = `.`
- `template_path` = `./project-context-template.md`
- `output_file` = `{output_folder}/project-context.md`
---

View File

@ -20,8 +20,6 @@ Load config from `{project-root}/_bmad/bmm/config.yaml` and resolve:
### Paths
- `installed_path` = `.`
- `checklist` = `./checklist.md`
- `test_dir` = `{project-root}/tests`
- `source_dir` = `{project-root}`
- `default_output_file` = `{implementation_artifacts}/tests/test-summary.md`
@ -135,4 +133,4 @@ If the project needs:
Save summary to: `{default_output_file}`
**Done!** Tests generated and verified. Validate against `{checklist}`.
**Done!** Tests generated and verified. Validate against `./checklist.md`.

View File

@ -1,5 +1,4 @@
---
methods: './methods.csv'
agent_party: '{project-root}/_bmad/_config/agent-manifest.csv'
---
@ -35,7 +34,7 @@ When invoked from another prompt or process:
### Step 1: Method Registry Loading
**Action:** Load and read `{methods}` and `{agent_party}`
**Action:** Load and read `./methods.csv` and `{agent_party}`
#### CSV Structure

View File

@ -65,7 +65,7 @@ Create the brainstorming session document:
mkdir -p "$(dirname "{brainstorming_session_output_file}")"
# Initialize from template
cp "{template_path}" "{brainstorming_session_output_file}"
cp "../template.md" "{brainstorming_session_output_file}"
```
#### B. Context File Check and Loading

View File

@ -40,8 +40,6 @@ Load config from `{project-root}/_bmad/core/config.yaml` and resolve:
### Paths
- `template_path` = `./template.md`
- `brain_techniques_path` = `./brain-methods.csv`
- `brainstorming_session_output_file` = `{output_folder}/brainstorming/brainstorming-session-{{date}}-{{time}}.md` (evaluated once at workflow start)
All steps MUST reference `{brainstorming_session_output_file}` instead of the full path pattern.