From 6803727dde00fa5015e03f34a6b348a9ee4d99e9 Mon Sep 17 00:00:00 2001 From: Alex Verkhovsky Date: Thu, 12 Mar 2026 12:33:50 -0600 Subject: [PATCH] chore: convert code-review workflow to native skill --- src/bmm/agents/dev.agent.yaml | 2 +- src/bmm/agents/quick-flow-solo-dev.agent.yaml | 2 +- src/bmm/module-help.csv | 2 +- .../workflows/4-implementation/bmad-code-review/SKILL.md | 6 ++++++ .../bmad-code-review/bmad-skill-manifest.yaml | 1 + .../{code-review => bmad-code-review}/checklist.md | 0 .../{code-review => bmad-code-review}/discover-inputs.md | 0 .../{code-review => bmad-code-review}/workflow.md | 4 ++-- .../4-implementation/code-review/bmad-skill-manifest.yaml | 3 --- 9 files changed, 12 insertions(+), 8 deletions(-) create mode 100644 src/bmm/workflows/4-implementation/bmad-code-review/SKILL.md create mode 100644 src/bmm/workflows/4-implementation/bmad-code-review/bmad-skill-manifest.yaml rename src/bmm/workflows/4-implementation/{code-review => bmad-code-review}/checklist.md (100%) rename src/bmm/workflows/4-implementation/{code-review => bmad-code-review}/discover-inputs.md (100%) rename src/bmm/workflows/4-implementation/{code-review => bmad-code-review}/workflow.md (99%) delete mode 100644 src/bmm/workflows/4-implementation/code-review/bmad-skill-manifest.yaml diff --git a/src/bmm/agents/dev.agent.yaml b/src/bmm/agents/dev.agent.yaml index d9da7446b..795a76a25 100644 --- a/src/bmm/agents/dev.agent.yaml +++ b/src/bmm/agents/dev.agent.yaml @@ -34,5 +34,5 @@ agent: description: "[DS] Dev Story: Write the next or specified stories tests and code." - trigger: CR or fuzzy match on code-review - exec: "{project-root}/_bmad/bmm/workflows/4-implementation/code-review/workflow.md" + exec: "{project-root}/_bmad/bmm/workflows/4-implementation/bmad-code-review/workflow.md" description: "[CR] Code Review: Initiate a comprehensive code review across multiple quality facets. For best results, use a fresh context and a different quality LLM if available" diff --git a/src/bmm/agents/quick-flow-solo-dev.agent.yaml b/src/bmm/agents/quick-flow-solo-dev.agent.yaml index e019804e2..79bfb05b7 100644 --- a/src/bmm/agents/quick-flow-solo-dev.agent.yaml +++ b/src/bmm/agents/quick-flow-solo-dev.agent.yaml @@ -32,5 +32,5 @@ agent: description: "[QQ] Quick Dev New (Preview): Unified quick flow — clarify intent, plan, implement, review, present (experimental)" - trigger: CR or fuzzy match on code-review - exec: "{project-root}/_bmad/bmm/workflows/4-implementation/code-review/workflow.md" + exec: "{project-root}/_bmad/bmm/workflows/4-implementation/bmad-code-review/workflow.md" description: "[CR] Code Review: Initiate a comprehensive code review across multiple quality facets. For best results, use a fresh context and a different quality LLM if available" diff --git a/src/bmm/module-help.csv b/src/bmm/module-help.csv index aa5fc6dcd..14835363a 100644 --- a/src/bmm/module-help.csv +++ b/src/bmm/module-help.csv @@ -27,6 +27,6 @@ bmm,4-implementation,Sprint Status,SS,20,_bmad/bmm/workflows/4-implementation/sp bmm,4-implementation,Validate Story,VS,35,skill:bmad-create-story,bmad-bmm-create-story,false,sm,Validate Mode,"Validates story readiness and completeness before development work begins",implementation_artifacts,"story validation report", bmm,4-implementation,Create Story,CS,30,skill:bmad-create-story,bmad-bmm-create-story,true,sm,Create Mode,"Story cycle start: Prepare first found story in the sprint plan that is next, or if the command is run with a specific epic and story designation with context. Once complete, then VS then DS then CR then back to DS if needed or next CS or ER",implementation_artifacts,story, bmm,4-implementation,Dev Story,DS,40,skill:bmad-dev-story,bmad-bmm-dev-story,true,dev,Create Mode,"Story cycle: Execute story implementation tasks and tests then CR then back to DS if fixes needed",,, -bmm,4-implementation,Code Review,CR,50,_bmad/bmm/workflows/4-implementation/code-review/workflow.md,bmad-bmm-code-review,false,dev,Create Mode,"Story cycle: If issues back to DS if approved then next CS or ER if epic complete",,, +bmm,4-implementation,Code Review,CR,50,skill:bmad-code-review,bmad-bmm-code-review,false,dev,Create Mode,"Story cycle: If issues back to DS if approved then next CS or ER if epic complete",,, bmm,4-implementation,QA Automation Test,QA,45,_bmad/bmm/workflows/qa-generate-e2e-tests/workflow.md,bmad-bmm-qa-automate,false,qa,Create Mode,"Generate automated API and E2E tests for implemented code using the project's existing test framework (detects existing well known in use test frameworks). Use after implementation to add test coverage. NOT for code review or story validation - use CR for that.",implementation_artifacts,"test suite", bmm,4-implementation,Retrospective,ER,60,_bmad/bmm/workflows/4-implementation/retrospective/workflow.md,bmad-bmm-retrospective,false,sm,Create Mode,"Optional at epic end: Review completed work lessons learned and next epic or if major issues consider CC",implementation_artifacts,retrospective, diff --git a/src/bmm/workflows/4-implementation/bmad-code-review/SKILL.md b/src/bmm/workflows/4-implementation/bmad-code-review/SKILL.md new file mode 100644 index 000000000..35edf0505 --- /dev/null +++ b/src/bmm/workflows/4-implementation/bmad-code-review/SKILL.md @@ -0,0 +1,6 @@ +--- +name: bmad-code-review +description: 'Perform adversarial code review finding specific issues. Use when the user says "run code review" or "review this code"' +--- + +Follow the instructions in [workflow.md](workflow.md). diff --git a/src/bmm/workflows/4-implementation/bmad-code-review/bmad-skill-manifest.yaml b/src/bmm/workflows/4-implementation/bmad-code-review/bmad-skill-manifest.yaml new file mode 100644 index 000000000..d0f08abdb --- /dev/null +++ b/src/bmm/workflows/4-implementation/bmad-code-review/bmad-skill-manifest.yaml @@ -0,0 +1 @@ +type: skill diff --git a/src/bmm/workflows/4-implementation/code-review/checklist.md b/src/bmm/workflows/4-implementation/bmad-code-review/checklist.md similarity index 100% rename from src/bmm/workflows/4-implementation/code-review/checklist.md rename to src/bmm/workflows/4-implementation/bmad-code-review/checklist.md diff --git a/src/bmm/workflows/4-implementation/code-review/discover-inputs.md b/src/bmm/workflows/4-implementation/bmad-code-review/discover-inputs.md similarity index 100% rename from src/bmm/workflows/4-implementation/code-review/discover-inputs.md rename to src/bmm/workflows/4-implementation/bmad-code-review/discover-inputs.md diff --git a/src/bmm/workflows/4-implementation/code-review/workflow.md b/src/bmm/workflows/4-implementation/bmad-code-review/workflow.md similarity index 99% rename from src/bmm/workflows/4-implementation/code-review/workflow.md rename to src/bmm/workflows/4-implementation/bmad-code-review/workflow.md index 1abb4d174..d1805acd1 100644 --- a/src/bmm/workflows/4-implementation/code-review/workflow.md +++ b/src/bmm/workflows/4-implementation/bmad-code-review/workflow.md @@ -1,5 +1,5 @@ --- -name: code-review +name: bmad-code-review description: 'Perform adversarial code review finding specific issues. Use when the user says "run code review" or "review this code"' --- @@ -35,7 +35,7 @@ Load config from `{project-root}/_bmad/bmm/config.yaml` and resolve: ### Paths -- `installed_path` = `{project-root}/_bmad/bmm/workflows/4-implementation/code-review` +- `installed_path` = `.` - `sprint_status` = `{implementation_artifacts}/sprint-status.yaml` - `validation` = `{installed_path}/checklist.md` diff --git a/src/bmm/workflows/4-implementation/code-review/bmad-skill-manifest.yaml b/src/bmm/workflows/4-implementation/code-review/bmad-skill-manifest.yaml deleted file mode 100644 index 6b1589a4a..000000000 --- a/src/bmm/workflows/4-implementation/code-review/bmad-skill-manifest.yaml +++ /dev/null @@ -1,3 +0,0 @@ -canonicalId: bmad-code-review -type: workflow -description: "Perform adversarial code review finding specific issues"