refactor(skills): convert review-pr and audit-file-refs to bmad-os skills (#1732)
Move Raven PR review and file-ref audit from tools/ into .claude/skills/ as proper bmad-os skills with SKILL.md + prompts/ instructions.md split pattern. Strip XML tags from Raven content, promote sections to H2 headings. Delete originals from tools/. Co-authored-by: Brian <bmadcode@gmail.com>
This commit is contained in:
parent
276fcb1042
commit
675e753e9b
|
|
@ -0,0 +1,7 @@
|
||||||
|
---
|
||||||
|
name: bmad-os-audit-file-refs
|
||||||
|
description: Audit BMAD source files for file-reference convention violations using parallel Haiku subagents. Use when checking path references in workflow and task files.
|
||||||
|
disable-model-invocation: true
|
||||||
|
---
|
||||||
|
|
||||||
|
Read `prompts/instructions.md` and execute.
|
||||||
|
|
@ -6,9 +6,9 @@ Adversarial code review for GitHub PRs. Works with any LLM agent.
|
||||||
|
|
||||||
## How It Works
|
## How It Works
|
||||||
|
|
||||||
Point your agent at `review-pr.md` and ask it to review a specific PR:
|
Use `/bmad-os-review-pr` to review a specific PR:
|
||||||
|
|
||||||
> "Read tools/maintainer/review-pr.md and apply it to PR #123"
|
> "Use /bmad-os-review-pr to review PR #123"
|
||||||
|
|
||||||
The tool will:
|
The tool will:
|
||||||
|
|
||||||
|
|
@ -17,7 +17,7 @@ The tool will:
|
||||||
3. Transform findings into professional tone
|
3. Transform findings into professional tone
|
||||||
4. Preview the review and ask before posting
|
4. Preview the review and ask before posting
|
||||||
|
|
||||||
See `review-pr.md` for full prompt structure, severity ratings, and sandboxing rules.
|
See `prompts/instructions.md` for full prompt structure, severity ratings, and sandboxing rules.
|
||||||
|
|
||||||
## When to Use
|
## When to Use
|
||||||
|
|
||||||
|
|
@ -0,0 +1,7 @@
|
||||||
|
---
|
||||||
|
name: bmad-os-review-pr
|
||||||
|
description: Adversarial PR review tool (Raven's Verdict). Cynical deep review transformed into professional engineering findings. Use when asked to review a PR.
|
||||||
|
disable-model-invocation: true
|
||||||
|
---
|
||||||
|
|
||||||
|
Read `prompts/instructions.md` and execute.
|
||||||
|
|
@ -2,8 +2,7 @@
|
||||||
|
|
||||||
A cynical adversarial review, transformed into cold engineering professionalism.
|
A cynical adversarial review, transformed into cold engineering professionalism.
|
||||||
|
|
||||||
<orientation>
|
## CRITICAL: Sandboxed Execution Rules
|
||||||
CRITICAL: Sandboxed Execution Rules
|
|
||||||
|
|
||||||
Before proceeding, you MUST verify:
|
Before proceeding, you MUST verify:
|
||||||
|
|
||||||
|
|
@ -14,9 +13,6 @@ Before proceeding, you MUST verify:
|
||||||
|
|
||||||
**If no explicit PR number/URL was provided, STOP immediately and ask:**
|
**If no explicit PR number/URL was provided, STOP immediately and ask:**
|
||||||
"What PR number or URL should I review?"
|
"What PR number or URL should I review?"
|
||||||
</orientation>
|
|
||||||
|
|
||||||
<preflight-checks>
|
|
||||||
|
|
||||||
## Preflight Checks
|
## Preflight Checks
|
||||||
|
|
||||||
|
|
@ -97,9 +93,7 @@ gh pr diff {PR_NUMBER} [--repo {REPO}] --name-only | grep -E '\.(png|jpg|jpeg|gi
|
||||||
|
|
||||||
Store list of binary files to skip. Note them in final output.
|
Store list of binary files to skip. Note them in final output.
|
||||||
|
|
||||||
</preflight-checks>
|
## Adversarial Review
|
||||||
|
|
||||||
<adversarial-review>
|
|
||||||
|
|
||||||
### 1.1 Run Cynical Review
|
### 1.1 Run Cynical Review
|
||||||
|
|
||||||
|
|
@ -130,9 +124,7 @@ Likely tag:
|
||||||
- Add `[likely]` to findings with high confidence, e.g. with direct evidence
|
- Add `[likely]` to findings with high confidence, e.g. with direct evidence
|
||||||
- Sort findings by severity (Critical → Moderate → Minor), not by confidence
|
- Sort findings by severity (Critical → Moderate → Minor), not by confidence
|
||||||
|
|
||||||
</adversarial-review>
|
## Tone Transformation
|
||||||
|
|
||||||
<tone-transformation>
|
|
||||||
|
|
||||||
**Transform the cynical output into cold engineering professionalism.**
|
**Transform the cynical output into cold engineering professionalism.**
|
||||||
|
|
||||||
|
|
@ -177,9 +169,8 @@ Output format after transformation:
|
||||||
_Review generated by Raven's Verdict. LLM-produced analysis - findings may be incorrect or lack context. Verify before acting._
|
_Review generated by Raven's Verdict. LLM-produced analysis - findings may be incorrect or lack context. Verify before acting._
|
||||||
```
|
```
|
||||||
|
|
||||||
</tone-transformation>
|
## Post Review
|
||||||
|
|
||||||
<post-review>
|
|
||||||
### 3.1 Preview
|
### 3.1 Preview
|
||||||
|
|
||||||
Display the complete transformed review to the user.
|
Display the complete transformed review to the user.
|
||||||
|
|
@ -231,12 +222,10 @@ Do NOT use heredocs or `echo` - Markdown code blocks will break shell parsing. U
|
||||||
|
|
||||||
Keep the temp file and inform user of location.
|
Keep the temp file and inform user of location.
|
||||||
|
|
||||||
</post-review>
|
## Notes
|
||||||
|
|
||||||
<notes>
|
|
||||||
- The "cynical asshole" phase is internal only - never posted
|
- The "cynical asshole" phase is internal only - never posted
|
||||||
- Tone transform MUST happen before any external output
|
- Tone transform MUST happen before any external output
|
||||||
- When in doubt, ask the user - never assume
|
- When in doubt, ask the user - never assume
|
||||||
- If you're unsure about severity, err toward higher severity
|
- If you're unsure about severity, err toward higher severity
|
||||||
- If you're unsure about confidence, be honest and use Medium or Low
|
- If you're unsure about confidence, be honest and use Medium or Low
|
||||||
</notes>
|
|
||||||
Loading…
Reference in New Issue